Skip to content

[WAITING ON CHECKLIST] Send money - Amount sent is copied as NaN in send money report page #29441

New issue
New issue
Closed
Closed
[WAITING ON CHECKLIST] Send money - Amount sent is copied as NaN in send money report page#29441
Assignees
jakub-trzebiatowskijliexpensifyjasperhuanggsaranshbalyan-1234
Labels
BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Description

@lanitochka17
lanitochka17
opened on Oct 12, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.83-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to + > Send money
  3. Send money to any user
  4. Click on the IOU preview to open report page
  5. Click on the avatar on the header
  6. Right click on the IOU card and select Copy to clipboard
  7. Paste it in the composer

Expected Result:

The amount sent is copied correctly

Actual Result:

The amount sent is copied as NaN

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Bug6234471_1697117342855.20231012_194342.mp4
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b326fbae821e5272
  • Upwork Job ID: 1712524952357588992
  • Last Price Increase: 2023-10-12
  • Automatic offers:
    • cubuspl42 | Reviewer | 27446145
    • saranshbalyan-1234 | Contributor | 27446146

Activity

  1. lanitochka17
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 12, 2023
  2. melvin-bot
    assigned
    jliexpensify
    on Oct 12, 2023

  3. melvin-bot commented on Oct 12, 2023

    @melvin-bot
    melvin-botBot
    on Oct 12, 2023

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Oct 12, 2023

    @melvin-bot
    melvin-botBot
    on Oct 12, 2023

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. mountiny
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 12, 2023
  6. melvin-bot
    changed the title [-]Send money - Amount sent is copied as NaN in send money report page[/-] [+][$500] Send money - Amount sent is copied as NaN in send money report page[/+] on Oct 12, 2023

  7. melvin-bot commented on Oct 12, 2023

    @melvin-bot
    melvin-botBot
    on Oct 12, 2023

    Job added to Upwork: https://www.upwork.com/jobs/~01b326fbae821e5272

  8. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 12, 2023
  9. melvin-bot
    assigned
    jakub-trzebiatowski
    on Oct 12, 2023

  10. mountiny commented on Oct 12, 2023

    @mountiny
    mountiny
    on Oct 12, 2023
    Contributor

    I dont think this has to be a deploy blocker

  11. melvin-bot commented on Oct 12, 2023

    @melvin-bot
    melvin-botBot
    on Oct 12, 2023

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

  12. mountiny
    changed the title [-][$500] Send money - Amount sent is copied as NaN in send money report page[/-] [+][$125] Send money - Amount sent is copied as NaN in send money report page[/+] on Oct 12, 2023

  13. 50 remaining items

  14. melvin-bot commented on Nov 6, 2023

    @melvin-bot
    melvin-botBot
    on Nov 6, 2023 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.95-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-11-13. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Nov 6, 2023

    @melvin-bot
    melvin-botBot
    on Nov 6, 2023 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@cubuspl42] The PR that introduced the bug has been identified. Link to the PR:
    • [@cubuspl42] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@cubuspl42] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@cubuspl42] Determine if we should create a regression test for this bug.
    • [@cubuspl42] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    DailyKSv2
    on Nov 13, 2023

  17. greg-schroeder commented on Nov 13, 2023

    @greg-schroeder
    greg-schroeder
    on Nov 13, 2023
    Contributor

    fyi: #30796 (comment)

  18. jliexpensify commented on Nov 13, 2023

    @jliexpensify
    jliexpensify
    on Nov 13, 2023
    Contributor

    Thanks Greg - so to summarise: no penalty for regression here?

    If so, Payment Summary:

    Upworks job here

    Will pay today

  19. jliexpensify commented on Nov 13, 2023

    @jliexpensify
    jliexpensify
    on Nov 13, 2023
    Contributor

    Paid and job closed. @cubuspl42 please complete the checklist!

  20. jliexpensify
    changed the title [-][HOLD for payment 2023-11-13] [$125] Send money - Amount sent is copied as NaN in send money report page[/-] [+][WAITING ON CHECKLIST] Send money - Amount sent is copied as NaN in send money report page[/+] on Nov 13, 2023
  21. jliexpensify
    removed
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Nov 13, 2023

  22. jakub-trzebiatowski commented on Nov 14, 2023

    @jakub-trzebiatowski
    jakub-trzebiatowski
    on Nov 14, 2023
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR:
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
      • No need for additional discussion
    • Determine if we should create a regression test for this bug.
      • Up to the QA team
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
      • Press to the "+" button, then select "Send money"
      • Proceed to send money to any user
      • Click on the IOU preview to access the report page
      • Click on the avatar located in the header
      • Right-click on the IOU card and choose "Copy to clipboard"
      • Paste the copied content into the composer
      • Verify that the pasted text correctly displays the user's name and amount
  23. jliexpensify
    closed this as completedon Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions