You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-12-12] [$1000] No I cursor on text in keyboard shortcut #29613
Please re-state the problem that we are trying to solve in this issue.
No I cursor is shown when hovering on text in the keyboard shortcut page
What is the root cause of that problem?
We use MenuItem to render the elements inside the page, which doesn't enable the I cursor to be showing on hovering on text by default (because of the outer Hover component ).
Please re-state the problem that we are trying to solve in this issue.
No I cursor is shown when hovering on text in the keyboard shortcut page
What is the root cause of that problem?
We use MenuItem for shortcuts which applies cursorDefault when interactivity is disabled and for shortcuts we disable interactivity and when it is interactive it applies cursorPointer.
What changes do you think we should make in order to solve the problem?
We can pass styles.cursorAuto to wrapperStyle prop passed to MenuItem which will override all cursor styles. wrapperStyle={[styles.ph0, styles.cursorAuto]}
Or we can remove !props.interactive && styles.cursorDefault and pass styles.cursorDefault when its needed in components like TaskView.
Option 3
Since we are using MenuItem in multiple places, we can introduce new prop(shouldRenderAsText) just like shouldRenderAsHTML and based on that we will override default cursor style.
Activity
[-]No I cursor on text in keyboard shortcut[/-][+][$500] No I cursor on text in keyboard shortcut[/+]melvin-bot commentedon Oct 14, 2023
Triggered auto assignment to @kevinksullivan (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 14, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01023480685f62e4c3
melvin-bot commentedon Oct 14, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)abzokhattab commentedon Oct 14, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
No I cursor is shown when hovering on text in the keyboard shortcut page
What is the root cause of that problem?
We use
MenuItemto render the elements inside the page, which doesn't enable theIcursor to be showing on hovering on text by default (because of the outerHovercomponent ).App/src/pages/KeyboardShortcutsPage.js
Lines 33 to 41 in 1201077
What changes do you think we should make in order to solve the problem?
we need to add the styling props that shows the
Icursor on hovering over the text:OR
we remove the
MenuItemand bring back the simple text component that was used before:POC
Screen.Recording.2023-10-14.at.2.09.54.PM.mov
melvin-bot commentedon Oct 14, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)Krishna2323 commentedon Oct 14, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
No I cursor is shown when hovering on text in the keyboard shortcut page
What is the root cause of that problem?
We use
MenuItemfor shortcuts which applies cursorDefault when interactivity is disabled and for shortcuts we disable interactivity and when it is interactive it applies cursorPointer.App/src/components/MenuItem.js
Lines 156 to 163 in 1201077
What changes do you think we should make in order to solve the problem?
We can pass
styles.cursorAutotowrapperStyleprop passed toMenuItemwhich will override all cursor styles.wrapperStyle={[styles.ph0, styles.cursorAuto]}App/src/pages/KeyboardShortcutsPage.js
Lines 33 to 41 in 1201077
Option 2
Or we can remove
!props.interactive && styles.cursorDefaultand passstyles.cursorDefaultwhen its needed in components likeTaskView.Option 3
Since we are using
MenuItemin multiple places, we can introduce new prop(shouldRenderAsText) just likeshouldRenderAsHTMLand based on that we will override default cursor style.Result
tienifr commentedon Oct 16, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
No I cursor on text in keyboard shortcut
What is the root cause of that problem?
We're disabling interactive in
App/src/pages/KeyboardShortcutsPage.js
Line 39 in ae36e7b
In
App/src/components/MenuItem.js
Line 158 in ae36e7b
we add cursorDefault to style if interactive is false.
Because we didn't set the cursor style for Text so it will use the cursor style from parent component
What changes do you think we should make in order to solve the problem?
For consistency, we should fix this problem in MenuItem
when interactive is false and disabled is false we should add
styles.cursorTextto both titleTextStyle and descriptionTextStyleResult
91 remaining items
Krishna2323 commentedon Dec 14, 2023
@kevinksullivan bump.
kevinksullivan commentedon Dec 14, 2023
Payment summary:
mananjadhav commentedon Dec 14, 2023
@kevinksullivan I am confused if this should $1000 or $1500 ?
melvin-bot commentedon Dec 18, 2023
@mananjadhav, @Beamanator, @kevinksullivan, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Dec 18, 2023
@mananjadhav, @Beamanator, @kevinksullivan, @Krishna2323 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
mananjadhav commentedon Dec 19, 2023
@kevinksullivan Quick bump on this one. Can you please reconfirm the payout?
kevinksullivan commentedon Dec 19, 2023
chatting with Manan in DM.
mananjadhav commentedon Dec 20, 2023
Please ignore my comment, the bonus applies. We announced discontinuing the bonus on Oct 25th and this was created before that.
kevinksullivan commentedon Dec 22, 2023
Sounds good. This is paid out, so feel free to request in NewDot @mananjadhav
JmillsExpensify commentedon Dec 26, 2023
$1,500 payment approved for @mananjadhav based on this comment.