[$500] Desktop/Web - IOU - CMD+Enter allows you to select users and WS into one Split Bill

@garrettmknight

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.84-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Prerequisites:
Use an HT account that already has WS in it or create one in advance.

Open New Expensify app
Log into your HT account
Click on the FAB button
Click on 'Request Money'
Choose 'Manual' and add an amount
Click on the "Split" button next to WS
Click on the "Split" button next to any user
Press CMD+Enter(CTRL+Enter)

Expected Result:

CMD+Enter commands should not work in forbidden cases such as Split Bill with normal user and WorkSpace at the same time

Actual Result:

The CMD+Enter command takes you to the final Split Bill page, which includes normal users and WS at the same time, although this is not allowed by the system

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6237291_1697311077086.Recording__528.mp4

MacOS: Desktop

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @garrettmknight

@garrettmknight

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

We can bypass Confirm button and navigate via shortcut even though confirm button is not shown.

What is the root cause of that problem?

We hide the confirm button when we don't want the user to progress. but we allow the shortcut to navigate without checking this.

What changes do you think we should make in order to solve the problem?

We should not navigate further if the confirm button is not on the screen.

In BaseOptionsSelector, we will check for visibility of the confirm button before executing the onConfirmSelection() callback:

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 195 to 199 in fe282b4

    
           () => { 
        
               if (this.props.canSelectMultipleOptions) { 
        
                   this.props.onConfirmSelection(); 
        
                   return; 
        
               }

Implementation:

shouldShowFooter is declared in the render block:

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 367 to 369 in fe282b4

    
           render() { 
        
               const shouldShowFooter = 
        
                   !this.props.isReadOnly && (this.props.shouldShowConfirmButton || this.props.footerContent) && !(this.props.canSelectMultipleOptions && _.isEmpty(this.props.selectedOptions));

We will have to declare it in the constructor to make it available to other functions. Add here:

this.shouldShowFooter = false;

And change const shouldShowFooter to this.shouldShowFooter

Update all mentions of shouldShowFooter to this.shouldShowFooter

Update this line to:

if (this.props.canSelectMultipleOptions && this.shouldShowFooter) { 
  // only carry out the callback if user can see the confirm button.
  ...
}

This makes sure we don't go to the invalid state of splitting with a workspace.

Behaviour After Change:
CTRLEnter still allows selectRow to to be called (equivalent of pressing enter):

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 195 to 207 in fe282b4

    
           () => { 
        
               if (this.props.canSelectMultipleOptions) { 
        
                   this.props.onConfirmSelection(); 
        
                   return; 
        
               } 
        
               const focusedOption = this.state.allOptions[this.state.focusedIndex]; 
        
               if (!focusedOption) { 
        
                   return; 
        
               } 
        
               this.selectRow(focusedOption); 
        
           },

Which means user will go to manual request with the focused option. Same as pressing enter.

Making sure no regressions:

OptionsSelector is used in these places

Option lists that don't have a footer call SelectRow() which is outside the condition we are focusing on.

We will be blocking onConfirmSelection() that is passed to option lists only when they have a footer. This is in Three Places in the app:

MoneyRequestParticipantsSelector (this issue)
MoneyRequestConfirmationList
NewChatPage

MoneyRequestConfirmList

No regressions.

NewChatPage is also bugging:

We allow onConfirmSelection to be carried out in NewChatPage also. Which tries to create a chat without selecting participants.
This results in abrupt navigation to Conceirge (as a fallback).

Current behaviour on pressing CTRL+Enter on newChat Page:

Screencast.from.19-10-23.12.07.53.AM.IST.webm

This bug will also be fixed.

Reproduced, opening up.

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

@hoangzinh

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@neonbhai

@neonbhai Thanks for your proposal. Can you check if it won't cause any regression bugs on options lists that don't have a footer?

PR ready for review!

@garrettmknight

@garrettmknight It seems the issue was fixed by another PR when we were about to merge this PR and if I remember correctly, we still should issue payment since this wasn't the contributor's fault. Could you handle it?

@neonbhai

We've issued payment for work that turned out to be unnecessary, historically. I can do that this time, but @neonbhai I'd appreciate a little more urgency getting PRs up in the future. 🙇 Payment offer sent.

Paid, closing.

@garrettmknight

@garrettmknight Thank you!

@garrettmknight

Hi @garrettmknight can you help to issue payment for me as well? I helped review proposals, PR and completed the review check list already.

@hoangzinh

Sorry about that @hoangzinh - offer sent!

@garrettmknight

Accepted. Thanks @garrettmknight

Navigation Menu

Repository navigation

[$500] Desktop/Web - IOU - CMD+Enter allows you to select users and WS into one Split Bill #29628

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Implementation:

Making sure no regressions:

MoneyRequestConfirmList

NewChatPage is also bugging:

55 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	() => {
	if (this.props.canSelectMultipleOptions) {
	this.props.onConfirmSelection();
	return;
	}

	render() {
	const shouldShowFooter =
	!this.props.isReadOnly && (this.props.shouldShowConfirmButton \|\| this.props.footerContent) && !(this.props.canSelectMultipleOptions && _.isEmpty(this.props.selectedOptions));

[$500] Desktop/Web - IOU - CMD+Enter allows you to select users and WS into one Split Bill #29628

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 14, 2023

melvin-bot commented on Oct 14, 2023

Bug0 Triage Checklist (Main S/O)

neonbhai commented on Oct 14, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Implementation:

Making sure no regressions:

MoneyRequestConfirmList

NewChatPage is also bugging:

garrettmknight commented on Oct 16, 2023

melvin-bot commented on Oct 16, 2023

melvin-bot commented on Oct 16, 2023

melvin-bot commented on Oct 16, 2023

hoangzinh commented on Oct 18, 2023

55 remaining items

neonbhai commented on Jan 8, 2024

pecanoro commented on Jan 15, 2024

garrettmknight commented on Jan 16, 2024

garrettmknight commented on Jan 16, 2024

neonbhai commented on Jan 16, 2024

hoangzinh commented on Jan 16, 2024

garrettmknight commented on Jan 17, 2024

hoangzinh commented on Jan 17, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions