You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-24] [$125] IOU - Expense preview card is wider than the Pay button #29639
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [$125] IOU - Expense preview card is wider than the Pay button[/-][+][HOLD for payment 2023-10-24][$125] IOU - Expense preview card is wider than the Pay button[/+]on Oct 23, 2023
changed the title [-][HOLD for payment 2023-10-24][$125] IOU - Expense preview card is wider than the Pay button[/-][+][HOLD for payment 2023-10-24] [$125] IOU - Expense preview card is wider than the Pay button[/+]on Oct 23, 2023
I think deploy blockers are some of the most important bugs to fix in a timely manner so the urgency bonus makes sense. I'm unsure if we're thoroughly discussed or documented anywhere though.
Ah, I was coming from another issue which I think conflated some payment logic - my apologies! I agree we need to have a much simplified payment structure (we're doing away with urgency bonuses anyways, so kind of a moot point).
Activity
melvin-bot commentedon Oct 15, 2023
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 15, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Oct 15, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Oct 15, 2023
Triggered auto assignment to @robertjchen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.ishpaul777 commentedon Oct 15, 2023
Proposal
Problem
Expense preview card is wider than the Pay button
Root Cause
We have applied the maxWidth of
reportPreviewMaxWidthto the Pay button inMoneyReportViewbefore it wassidebarWidthoffending PR #29431
Changes
We can safely remove the maxwidth from SettlementButton in MoneyReportView or change it back to
sidebarWidth(or a new variable with same value)ishpaul777 commentedon Oct 15, 2023
I have reported this here https://expensify.slack.com/archives/C049HHMV9SM/p1697387154663989, @lanitochka17 can you check if i have reported this before Applause - Internal Team
situchan commentedon Oct 15, 2023
@ishpaul777 you linked wrong PR. This is regression from #29431
58 remaining items
[-][HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [$125] IOU - Expense preview card is wider than the Pay button[/-][+][HOLD for payment 2023-10-24][$125] IOU - Expense preview card is wider than the Pay button[/+][-][HOLD for payment 2023-10-24][$125] IOU - Expense preview card is wider than the Pay button[/-][+][HOLD for payment 2023-10-24] [$125] IOU - Expense preview card is wider than the Pay button[/+]mountiny commentedon Oct 23, 2023
No checklist required as this was a deploy blocker so the offending PR has been identified already, we do not need a regression test for this either
We need to pay $125 to @ishpaul777 and @situchan for this quick PR to resolve a deploy blocker I believe
mallenexpensify commentedon Oct 23, 2023
@mountiny, @ishpaul777 and @situchan should also receive the urgency bonus, right?
mountiny commentedon Oct 23, 2023
I guess yes, it was a deploy blocker so it had to be fixed fast
mallenexpensify commentedon Oct 24, 2023
Issue reporter: Applause
Contributor: @ishpaul777 paid $200 via Upwork
Contributor+: @situchan paid $200 via Upwork
@situchan , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~019741438087b10f75
situchan commentedon Oct 25, 2023
@mallenexpensify accepted, thanks
mallenexpensify commentedon Oct 26, 2023
@situchan paid, updated the above payment breakdown.
Also... updated price above from $250 to $200, the correct amount.
Thanks y'all!
sophiepintoraetz commentedon Oct 29, 2023
@mallenexpensify @mountiny - no, reviews are a flat fee no bonus applies here.
mallenexpensify commentedon Oct 30, 2023
@sophiepintoraetz in post that was linked in the link you sent it says
I think deploy blockers are some of the most important bugs to fix in a timely manner so the urgency bonus makes sense. I'm unsure if we're thoroughly discussed or documented anywhere though.
sophiepintoraetz commentedon Oct 30, 2023
Ah, I was coming from another issue which I think conflated some payment logic - my apologies! I agree we need to have a much simplified payment structure (we're doing away with urgency bonuses anyways, so kind of a moot point).