Skip to content

[HOLD for payment 2023-10-24] [$125] IOU - Expense preview card is wider than the Pay button #29639

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.84-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Click + > Request money > Manual
  4. Complete the request flow
    Note that the expense preview card is wider than the Pay button

Expected Result:

The expense preview card and the Pay button have similar width

Actual Result:

The expense preview card is wider than the Pay button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Bug6237521_1697332502428.20231015_041509.mp4

Staging
Screenshot 2023-10-15 at 04 26 19

Production
Bug6237521_1697332502451!Screenshot_2023-10-15_at_04 18 39

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019741438087b10f75
  • Upwork Job ID: 1713665637747257344
  • Last Price Increase: 2023-10-15
  • Automatic offers:
    • ntdiary | Reviewer | 27209686
    • ishpaul777 | Contributor | 27209690
    • situchan | Contributor | 27216588

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 15, 2023
  2. melvin-bot commented on Oct 15, 2023

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Oct 15, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Oct 15, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Oct 15, 2023

    @melvin-bot

    Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. ishpaul777 commented on Oct 15, 2023

    @ishpaul777
    Contributor

    Proposal

    Problem

    Expense preview card is wider than the Pay button

    Root Cause

    We have applied the maxWidth of reportPreviewMaxWidth to the Pay button in MoneyReportView before it was sidebarWidth

    offending PR #29431

    Changes

    We can safely remove the maxwidth from SettlementButton in MoneyReportView or change it back to sidebarWidth (or a new variable with same value)

    <SettlementButton
       // rest of props
       style={[styles.mt3]}
    />
  7. ishpaul777 commented on Oct 15, 2023

    @ishpaul777
    Contributor

    I have reported this here https://expensify.slack.com/archives/C049HHMV9SM/p1697387154663989, @lanitochka17 can you check if i have reported this before Applause - Internal Team

  8. situchan commented on Oct 15, 2023

    @situchan
    Contributor

    @ishpaul777 you linked wrong PR. This is regression from #29431

  9. 58 remaining items

  10. changed the title [-][HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [$125] IOU - Expense preview card is wider than the Pay button[/-] [+][HOLD for payment 2023-10-24][$125] IOU - Expense preview card is wider than the Pay button[/+] on Oct 23, 2023
  11. changed the title [-][HOLD for payment 2023-10-24][$125] IOU - Expense preview card is wider than the Pay button[/-] [+][HOLD for payment 2023-10-24] [$125] IOU - Expense preview card is wider than the Pay button[/+] on Oct 23, 2023
  12. mountiny commented on Oct 23, 2023

    @mountiny
    Contributor

    No checklist required as this was a deploy blocker so the offending PR has been identified already, we do not need a regression test for this either

    We need to pay $125 to @ishpaul777 and @situchan for this quick PR to resolve a deploy blocker I believe

  13. mallenexpensify commented on Oct 23, 2023

    @mallenexpensify
    Contributor

    @mountiny, @ishpaul777 and @situchan should also receive the urgency bonus, right?

  14. mountiny commented on Oct 23, 2023

    @mountiny
    Contributor

    I guess yes, it was a deploy blocker so it had to be fixed fast

  15. mallenexpensify commented on Oct 24, 2023

    @mallenexpensify
    Contributor

    Issue reporter: Applause
    Contributor: @ishpaul777 paid $200 via Upwork
    Contributor+: @situchan paid $200 via Upwork

    @situchan , can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~019741438087b10f75

  16. situchan commented on Oct 25, 2023

    @situchan
    Contributor

    @mallenexpensify accepted, thanks

  17. mallenexpensify commented on Oct 26, 2023

    @mallenexpensify
    Contributor

    @situchan paid, updated the above payment breakdown.
    Also... updated price above from $250 to $200, the correct amount.

    Thanks y'all!

  18. sophiepintoraetz commented on Oct 29, 2023

    @sophiepintoraetz
    Contributor

    @mountiny, @ishpaul777 and @situchan should also receive the urgency bonus, right?

    @mallenexpensify @mountiny - no, reviews are a flat fee no bonus applies here.

  19. mallenexpensify commented on Oct 30, 2023

    @mallenexpensify
    Contributor

    @sophiepintoraetz in post that was linked in the link you sent it says

    The 50% urgency bonus will be remaining in place

    I think deploy blockers are some of the most important bugs to fix in a timely manner so the urgency bonus makes sense. I'm unsure if we're thoroughly discussed or documented anywhere though.

  20. sophiepintoraetz commented on Oct 30, 2023

    @sophiepintoraetz
    Contributor

    Ah, I was coming from another issue which I think conflated some payment logic - my apologies! I agree we need to have a much simplified payment structure (we're doing away with urgency bonuses anyways, so kind of a moot point).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions