Skip to content

[HOLD for payment 2023-10-24] [$125] Bank Account - Some menu items left icon alignment is broken #29650

New issue
New issue
Closed
Closed
[HOLD for payment 2023-10-24] [$125] Bank Account - Some menu items left icon alignment is broken#29650
Assignees
puneetlathmountiny
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Description

@kbecciv
kbecciv
opened on Oct 16, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.84.1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @Pujan92
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697378426782819

Action Performed:

  1. Go to any workspace -> Click Bank account
  2. On the bank account step observe the left icon for
    • Connect online with plaid
    • Connect manually

Expected Result:

Left icon should be aligned on same place for all menu items

Actual Result:

Left icon is misaligned for connect manually button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native

Screenshot_1697378579 (1)

Android: mWeb Chrome

Screenshot_1697378971 (1)

iOS: Native

Simulator Screen Shot - iPhone 14 Pro Max - 2023-10-15 at 19 31 24 (1)

iOS: mWeb Safari

Simulator Screen Shot - iPhone 14 Pro Max - 2023-10-15 at 19 33 37 (1)

MacOS: Chrome / Safari
Recording.5003.mp4
MacOS: Desktop

Screenshot 2023-10-15 at 19 31 19 (1)

View all open jobs on GitHub

Activity

  1. kbecciv
    added
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 16, 2023

  2. kbecciv commented on Oct 16, 2023

    @kbecciv
    kbecciv
    on Oct 16, 2023
    Author

    Proposal by: @Pujan92
    Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697378426782819

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Menu items left icon alignment is not consistent

    What is the root cause of that problem?

    It seems a regression from PR where left padding has been removed from cardMenuItem which we have used for this kind of buttons. Earlier we had the left padding of 8px.
    https://github.com/Expensify/App/pull/26406/files#diff-8ab8ba45ab927f1430b8d1209d187e003a9cdfe476f809e4483ef64cdba253ebL3080

    App/src/styles/styles.ts

    Lines 3143 to 3144 in 0b06446

    cardMenuItem: {
    paddingLeft: 0,

    What changes do you think we should make in order to solve the problem?

    Correct the paddingLeft with 8px like the same it was earlier. Bcoz I see that class isn’t used in the offended PR. Might be changed unintentionally. cc: @pac-guerreiro
    https://github.com/Expensify/App/assets/14358475/594432d1-70d6-4188-9093-6a52863fc471

  3. melvin-bot
    added
    DailyKSv2
    on Oct 16, 2023
  4. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Oct 16, 2023

  5. OSBotify commented on Oct 16, 2023

    @OSBotify
    OSBotify
    on Oct 16, 2023
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot
    assigned
    arosiclair
    on Oct 16, 2023

  7. melvin-bot commented on Oct 16, 2023

    @melvin-bot
    melvin-botBot
    on Oct 16, 2023

    Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  8. mountiny
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 16, 2023

  9. melvin-bot commented on Oct 16, 2023

    @melvin-bot
    melvin-botBot
    on Oct 16, 2023

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

  10. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 16, 2023
  11. melvin-bot
    assigned
    ntdiary
    on Oct 16, 2023

  12. melvin-bot commented on Oct 16, 2023

    @melvin-bot
    melvin-botBot
    on Oct 16, 2023

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

  13. mountiny
    removed
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 16, 2023

  14. 36 remaining items

  15. ntdiary
    removed their assignment
    on Oct 17, 2023
  16. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Oct 23, 2023
  17. mountiny
    changed the title [-][HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$125] Bank Account - Some menu items left icon alignment is broken[/-] [+][HOLD for payment 2023-10-24] [$125] Bank Account - Some menu items left icon alignment is broken[/+] on Oct 23, 2023

  18. mountiny commented on Oct 23, 2023

    @mountiny
    mountiny
    on Oct 23, 2023
    Contributor

    No checklist are needed here as a deploy blocker the offending pr has been identified and we do not need regression test for this one either imho

  19. melvin-bot
    added
    DailyKSv2
    Overdue
    and removed
    DailyKSv2
    on Oct 23, 2023

  20. puneetlath commented on Oct 25, 2023

    @puneetlath
    puneetlath
    on Oct 25, 2023
    Contributor

    So only the bug reporter needs payment here, is that right @mountiny?

  21. melvin-bot
    removed
    Overdue
    on Oct 25, 2023

  22. mountiny commented on Oct 25, 2023

    @mountiny
    mountiny
    on Oct 25, 2023
    Contributor

    Correct @Pujan92 $50

  23. puneetlath commented on Oct 25, 2023

    @puneetlath
    puneetlath
    on Oct 25, 2023
    Contributor

    @Pujan92 sent you an offer here: https://www.upwork.com/nx/wm/offer/27370555

    Please comment on this issue once you've accepted it.

  24. Pujan92 commented on Oct 25, 2023

    @Pujan92
    Pujan92
    on Oct 25, 2023
    Contributor

    @puneetlath Accepted! Linking a comment here where @mountiny proposed $100 if that is considered.

  25. puneetlath commented on Oct 25, 2023

    @puneetlath
    puneetlath
    on Oct 25, 2023
    Contributor

    Thanks for the link. Paid!

  26. puneetlath
    closed this as completedon Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions