You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-23] Payment issue for E/App PR#29551 #29658
Issue created to compensate the Contributor+ member for their work on #29551
E/E issue linked to the PR - no internal issue.
Contributor+ member who reviewed the PR - @situchan.
Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.
The PR that introduced the bug has been identified. Link to the PR: N/A
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
I am not sure regression test proposal is needed here as the fix applies to corporate policy only.
Activity
melvin-bot commentedon Oct 16, 2023
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 16, 2023
Job added to Upwork: https://www.upwork.com/jobs/~014d14eeed13d23854
melvin-bot commentedon Oct 16, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Oct 16, 2023
Current assignee @situchan is eligible for the Internal assigner, not assigning anyone new.
[-]Payment issue for E/App PR#29551[/-][+][HOLD for payment 2023-10-23] Payment issue for E/App PR#29551[/+]JmillsExpensify commentedon Oct 17, 2023
Offer sent. Please make sure to fill out BZ checklist before payment is due.
2 remaining items
JmillsExpensify commentedon Oct 24, 2023
Still waiting for the checklist/regression test recommendation.
melvin-bot commentedon Oct 30, 2023
@JmillsExpensify, @situchan Huh... This is 4 days overdue. Who can take care of this?
JmillsExpensify commentedon Nov 1, 2023
Still waiting for contributors checklist/regression test recommendation
situchan commentedon Nov 1, 2023
I am not sure regression test proposal is needed here as the fix applies to
corporatepolicy only.Regression Test Proposal
JmillsExpensify commentedon Nov 8, 2023
I think it'd be good to add one. I'll do that. Thanks!
JmillsExpensify commentedon Nov 8, 2023
Payment issued via Upwork!