Skip to content

[HOLD for payment 2023-10-23] Payment issue for E/App PR#29551 #29658

Closed

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #29551
E/E issue linked to the PR - no internal issue.
Contributor+ member who reviewed the PR - @situchan.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014d14eeed13d23854
  • Upwork Job ID: 1713832120099913728
  • Last Price Increase: 2023-10-16

Activity

  1. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 16, 2023
  2. added
    InternalRequires API changes or must be handled by Expensify staff
    on Oct 16, 2023
  3. melvin-bot commented on Oct 16, 2023

    @melvin-bot
    Author

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Oct 16, 2023

    @melvin-bot
    Author
  5. melvin-bot commented on Oct 16, 2023

    @melvin-bot
    Author

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. melvin-bot commented on Oct 16, 2023

    @melvin-bot
    Author

    Current assignee @situchan is eligible for the Internal assigner, not assigning anyone new.

  7. changed the title [-]Payment issue for E/App PR#29551[/-] [+][HOLD for payment 2023-10-23] Payment issue for E/App PR#29551[/+] on Oct 17, 2023
  8. JmillsExpensify commented on Oct 17, 2023

    @JmillsExpensify
    Contributor

    Offer sent. Please make sure to fill out BZ checklist before payment is due.

  9. 2 remaining items

  10. JmillsExpensify commented on Oct 24, 2023

    @JmillsExpensify
    Contributor

    Still waiting for the checklist/regression test recommendation.

  11. melvin-bot commented on Oct 30, 2023

    @melvin-bot
    Author

    @JmillsExpensify, @situchan Huh... This is 4 days overdue. Who can take care of this?

  12. JmillsExpensify commented on Nov 1, 2023

    @JmillsExpensify
    Contributor

    Still waiting for contributors checklist/regression test recommendation

  13. situchan commented on Nov 1, 2023

    @situchan
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: N/A
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug.
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    I am not sure regression test proposal is needed here as the fix applies to corporate policy only.

    Regression Test Proposal

    1. Sign up as a teacher using https://stagin.new.expensify.com/teachersunite/i-am-a-teacher
    2. Note down the principal email used
    3. Navigate to the workspace chat and verify that 'Split bill' shows in composer menu
    4. Log in as the principal now
    5. Verify that 'Split bill' option doesn't show in composer menu in the teacher's workspace chat
  14. JmillsExpensify commented on Nov 8, 2023

    @JmillsExpensify
    Contributor

    I think it'd be good to add one. I'll do that. Thanks!

  15. JmillsExpensify commented on Nov 8, 2023

    @JmillsExpensify
    Contributor

    Payment issued via Upwork!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staffTask

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions