Repository navigation
IOU - Unable to create IOU transaction via request money on conversation #2969
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Expected Result:
User should be able to request money via the + button in the compose box.
Actual Result:
Blank page is displayed after adding the amount.
Action Performed:
- Log in to a expensifail account
- Navigate to a conversation
- Click on the + button in the compose box
- Click on request money
- Set the amount
Workaround:
Unknown
Platform:
Where is this issue occurring?
Web ✔️
iOS
Android
Desktop App
Mobile Web
Version Number: 1.0.47-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
JS error
TypeError: Cannot read property 'length' of undefined
at Uv (app-512ed1dd006b4b14742c.bundle.js:85)
at Yi (app-512ed1dd006b4b14742c.bundle.js:57)
at gs (app-512ed1dd006b4b14742c.bundle.js:57)
at lc (app-512ed1dd006b4b14742c.bundle.js:57)
at sc (app-512ed1dd006b4b14742c.bundle.js:57)
at Zs (app-512ed1dd006b4b14742c.bundle.js:57)
at app-512ed1dd006b4b14742c.bundle.js:57
at t.unstable_runWithPriority (app-512ed1dd006b4b14742c.bundle.js:65)
at Xo (app-512ed1dd006b4b14742c.bundle.js:57)
at Go (app-512ed1dd006b4b14742c.bundle.js:57)
Expensify/Expensify Issue URL:
Found while executing https://github.com/Expensify/Web-Expensify/pull/30957
https://expensify.slack.com/archives/C9YU7BX5M/p1621284097385700
Activity
MelvinBot commentedon May 17, 2021
Triggered auto assignment to @mateocole (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.MelvinBot commentedon May 17, 2021
@github-actions[bot] the
Demolitionlabel can only be added by an Engineer or a member of the Engineering Demolition Team.MelvinBot commentedon May 17, 2021
Triggered auto assignment to @roryabraham (
Demolition), see https://stackoverflow.com/c/expensify/questions/8099 for more details.1 remaining item
roryabraham commentedon May 17, 2021
Investigating this one now.
roryabraham commentedon May 17, 2021
Sorry, delayed by unrelated VM issues currently.
roryabraham commentedon May 18, 2021
Okay, VM is not working, will try to run the app with the web proxy instead
roryabraham commentedon May 18, 2021
Okay, testing this locally I'm unable to enter an amount at all in the IOU modal
roryabraham commentedon May 18, 2021
One thing I'm seeing is that this function seems to be entirely unused
roryabraham commentedon May 18, 2021
Okay, I suspect there may be a number of problems with the IOU code, but I was able to track down the cause of this regression, and hopefully should have a fix up soon.
roryabraham commentedon May 18, 2021
Got a PR here, just testing it on other platforms.
roryabraham commentedon May 18, 2021
Due to unrelated VM issues, I was blocked from testing locally on desktop. But I'm pretty sure that the PR will solve the problem and it's safe because it's just doing a
lodashGeton something which was being unsafely referenced.Julesssss commentedon May 18, 2021
Pretty sure this regression was introduced by this PR, but thanks for looking into this.
roryabraham commentedon May 18, 2021
https://github.com/Expensify/Expensify.cash/pull/2724/files#r633954686 😉
roryabraham commentedon May 18, 2021
VM issues resolved, PR is passing on all platforms! Just needs to be reviewed + merged
roryabraham commentedon May 18, 2021
@isagoico Please retest this during today's QA cycle. Should be resolved 🤞