You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-03] [$125] Split Bill - Merchant must have the same value after creating the split bill #29691
Click show more => Merchant, Observe that the default value is "Request"
Click split
Click Split preview
Click show more, in merchant, Observe "Split with...."
Expected Result:
Merchant must have the same value after creating the split bill
Actual Result:
There is a difference between the merchant after splitting the bill, when they create the merchant the value is "Request" but when the slit bill is created the merchant has the value "Split with...."
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Please re-state the problem that we are trying to solve in this issue.
Instead of taking in the user input in the merchant field (by default "Request") in the split bill screen, it automatically defaults to "Split with [participants]".
What is the root cause of that problem?
The cause of this issue is that in this code the merchant is automatically formatted on splits to the above mentioned:
What changes do you think we should make in order to solve the problem?
Instead of automatically formatting it to the "Split with [participants]" by default like it is currently, line 922 above should instead take in the submitted user input when building the transaction so that it reflects that value on submission like it does for the other fields. Specifically, that line and one other just need to be changed to the input prop var merchant .
changed the title [-]Split Bill - Merchant must have the same value after creating the split bill[/-][+][$125] Split Bill - Merchant must have the same value after creating the split bill[/+]on Oct 16, 2023
changed the title [-][$125] Split Bill - Merchant must have the same value after creating the split bill[/-][+][HOLD for payment 2024-01-03] [$125] Split Bill - Merchant must have the same value after creating the split bill[/+]on Dec 27, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.17-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-03. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@aimane-chnaif requires payment (Needs manual offer from BZ)
@namhihi237 requires payment (Needs manual offer from BZ)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Oct 16, 2023
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.
melvin-bot commentedon Oct 16, 2023
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 16, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Oct 16, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (
External)sicarius97 commentedon Oct 16, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Instead of taking in the user input in the merchant field (by default "Request") in the split bill screen, it automatically defaults to "Split with [participants]".
What is the root cause of that problem?
The cause of this issue is that in this code the merchant is automatically formatted on splits to the above mentioned:
App/src/libs/actions/IOU.js
Lines 914 to 927 in a456ef9
What changes do you think we should make in order to solve the problem?
Instead of automatically formatting it to the "Split with [participants]" by default like it is currently, line 922 above should instead take in the submitted user input when building the transaction so that it reflects that value on submission like it does for the other fields. Specifically, that line and one other just need to be changed to the input prop var
merchant.trjExpensify commentedon Oct 16, 2023
Oh interesting, I think @youssef-lr should have solved this.
[-]Split Bill - Merchant must have the same value after creating the split bill[/-][+][$125] Split Bill - Merchant must have the same value after creating the split bill[/+]melvin-bot commentedon Oct 16, 2023
35 remaining items
[-][$125] Split Bill - Merchant must have the same value after creating the split bill[/-][+][HOLD for payment 2024-01-03] [$125] Split Bill - Merchant must have the same value after creating the split bill[/+]melvin-bot commentedon Dec 27, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 27, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.17-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-03. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 27, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
trjExpensify commentedon Jan 3, 2024
👋 @aimane-chnaif checklist time, please!
aimane-chnaif commentedon Jan 3, 2024
Not able to find offending PR. There were back and forth changes related to merchant field.
Regression Test Proposal
aimane-chnaif commentedon Jan 3, 2024
Payment will be handled in #29732
trjExpensify commentedon Jan 3, 2024
Nice, so similarly I think the regression test will get added holistically with the project. So we can close this now.
namhihi237 commentedon Jan 3, 2024
@trjExpensify i think i can receive bonus as a reporter
trjExpensify commentedon Jan 3, 2024
Yup, Oct 24th the program change went into effect, so I've sent you an offer of $50 for the bug report.