You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-25] [HOLD for payment 2023-10-24] Login - User is not automatically logged in with magic link in different tab #29807
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
This pull request just made it to staging and modified some sign-in logic. Not sure yet if it's the culprit but sounds like a possibility.
cc @NikkiWines@MonilBhavsar if you're around and have an idea.
:hmm: If it's not that, it probably is related to some subscriber on the login page that is no longer prompting a refresh. I am looking at changes on that page but not seeing anything obvious
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-24. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@francoisl / @thienlnam] The PR that introduced the bug has been identified. Link to the PR:
[@francoisl / @thienlnam] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@francoisl / @thienlnam] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@francoisl / @thienlnam] Determine if we should create a regression test for this bug.
[@francoisl / @thienlnam] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2023-10-24] Login - User is not automatically logged in with magic link in different tab[/-][+][HOLD for payment 2023-10-25] [HOLD for payment 2023-10-24] Login - User is not automatically logged in with magic link in different tab[/+]on Oct 18, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-25. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@francoisl / @thienlnam] The PR that introduced the bug has been identified. Link to the PR:
[@francoisl / @thienlnam] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@francoisl / @thienlnam] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@francoisl / @thienlnam] Determine if we should create a regression test for this bug.
[@francoisl / @thienlnam] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Oct 17, 2023
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 17, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Oct 17, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Oct 17, 2023
Triggered auto assignment to @thienlnam (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.francoisl commentedon Oct 17, 2023
This pull request just made it to staging and modified some sign-in logic. Not sure yet if it's the culprit but sounds like a possibility.cc @NikkiWines @MonilBhavsar if you're around and have an idea.
francoisl commentedon Oct 17, 2023
I reverted 28372 on dev and can still reproduce the issue, so I don't think it's that.
thienlnam commentedon Oct 17, 2023
:hmm: If it's not that, it probably is related to some subscriber on the login page that is no longer prompting a refresh. I am looking at changes on that page but not seeing anything obvious
19 remaining items
melvin-bot commentedon Oct 17, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 17, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-24. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 17, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Beamanator commentedon Oct 18, 2023
Oof thanks for fixing, y'all 🙈
[-][HOLD for payment 2023-10-24] Login - User is not automatically logged in with magic link in different tab[/-][+][HOLD for payment 2023-10-25] [HOLD for payment 2023-10-24] Login - User is not automatically logged in with magic link in different tab[/+]melvin-bot commentedon Oct 18, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-25. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 18, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
zanyrenney commentedon Oct 25, 2023
Should be all good here as the payment is being handled here, all other assignees here are internal - #29577 !