[SMARTSCAN] [$500] [Regression fix] LOW: Expense - Incorrect placement of the red dot in expense report

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.86-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Precondition: There is some failed Scan requests with red dot

Go to staging.new.expensify.com
Go to the chat containg the requests in the precondition
Click on the request preview

Expected Result:

The red dot in the expense in 1:1 DM, expense report and expense details page has consistent placement on the right end of the content

Actual Result:

The red dot in the expense report is right next to the word 'Cash' instead of on the right end like it does in 1:1 DM and expense details page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6242013_1697649205328!Red_dot_on_the_right_end_placement

Bug6242013_1697649205327.20231019_010845.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f43fdbc3c0a0e63e
Upwork Job ID: 1716756487011663872
Last Price Increase: 2023-10-24

@anmurali

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Problem

Expense - Incorrect placement of the red dot in expense report

Root Cause

We have not added any style that seperates the text and the error "RedDot" in MoneyReportView, no root cause just a styling issue.

Changes

We can add style justifyContentBetween and alignItemsCenter (optional) for container of Text and the RedDot in MoneyReportView.

                         <View style={[styles.flexRow, styles.justifyContentBetween]}> // add here
                                <Text style={[styles.textLabelSupporting, styles.lh20, styles.mb1]}>{getPreviewHeaderText() + (isSettled ? ` • ${getSettledMessage()}` : '')}</Text>
                                {hasFieldErrors && (
                                    <Icon
                                        src={Expensicons.DotIndicator}
                                        fill={themeColors.danger}
                                    />
                                )}
                            </View>

Screen.Recording.2023-10-18.at.11.41.20.PM.mov

Optionally, we can add margin right to the text, but that would inconsistent with request preview.

Regression from #29544 where extra View is removed which has theflex1 prop to take available width.
9d04cf9#diff-d8e6b69ad4461bebf91e940a67ddc07adf36a3f7c156d6066363c3bde06a0f8aL265

I think this is the same as I reported here, right? #29733

@tienifr

@tienifr will be fixing the regression because it's under regression period

Yup, makes sense!

The PR #30231 is up

@anmurali

Niceee! @anmurali I'll just snag this from you.

@rushatgabhane

@rushatgabhane what's the ETA on reviewing the PR?

@cead22

@cead22, @trjExpensify, @rushatgabhane, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick!

PR is merged melv, awaiting a staging deploy.

@cead22

@cead22, @trjExpensify, @rushatgabhane, @tienifr Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

Going to close this as it was an issue for a regression from #29543

Navigation Menu

Repository navigation

[SMARTSCAN] [$500] [Regression fix] LOW: Expense - Incorrect placement of the red dot in expense report #29888

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Problem

Root Cause

Changes

15 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[SMARTSCAN] [$500] [Regression fix] LOW: Expense - Incorrect placement of the red dot in expense report #29888

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 18, 2023

melvin-bot commented on Oct 18, 2023

Bug0 Triage Checklist (Main S/O)

ishpaul777 commented on Oct 18, 2023

Proposal

Problem

Root Cause

Changes

Pujan92 commented on Oct 18, 2023

trjExpensify commented on Oct 23, 2023

rushatgabhane commented on Oct 23, 2023

trjExpensify commented on Oct 23, 2023

tienifr commented on Oct 24, 2023

trjExpensify commented on Oct 24, 2023

15 remaining items

trjExpensify commented on Oct 30, 2023

melvin-bot commented on Nov 6, 2023

trjExpensify commented on Nov 6, 2023

melvin-bot commented on Nov 20, 2023

trjExpensify commented on Nov 22, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions