Skip to content

[HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] [ECard Settings] Card Settings Follow Up  #30067

Closed

Description

@grgia

Implement changes from pending slack convo - https://expensify.slack.com/archives/C027726KHT4/p1697778334627559

  • Show wallet card if user has an available balance
  • Fix missing BG color behind animation
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bbe8007fd38ca212
  • Upwork Job ID: 1715311128445767680
  • Last Price Increase: 2023-10-20

Activity

  1. self-assigned this
    on Oct 20, 2023
  2. added
    InternalRequires API changes or must be handled by Expensify staff
    on Oct 20, 2023
  3. melvin-bot commented on Oct 20, 2023

    @melvin-bot
  4. melvin-bot commented on Oct 20, 2023

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @narefyev91 (Internal)

  5. changed the title [-][ECard Settings] Show Wallet if User has a Balance[/-] [+][ECard Settings] Card Settings Follow Up [/+] on Oct 20, 2023
  6. added
    ReviewingHas a PR in review
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 21, 2023
  7. changed the title [-][ECard Settings] Card Settings Follow Up [/-] [+][HOLD for payment 2023-10-30] [ECard Settings] Card Settings Follow Up [/+] on Oct 23, 2023
  8. melvin-bot commented on Oct 23, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Oct 23, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-30. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  10. changed the title [-][HOLD for payment 2023-10-30] [ECard Settings] Card Settings Follow Up [/-] [+][HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] [ECard Settings] Card Settings Follow Up [/+] on Oct 24, 2023
  11. melvin-bot commented on Oct 24, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.89-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-31. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions