[$500] Request - Participant deep link opens Participant page briefly and keyboard opens in Scan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.88-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #26149

Action Performed:

Precondition: Make sure Scan tab is selected when Request money tab is opened

Navigate to https://staging.new.expensify.com/
Paste the link https://staging.new.expensify.com/request/new/participants/
in chat
Tap on the link

Expected Result:

User is redirected to Request money selector page without opening Participants page and keyboard

Actual Result:

The link opens Participants page briefly with keyboard showing up. Sometimes Participants page is not shown but keyboard still appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Bug6245643_1697905602424.Screen_Recording_20231021_205927_New_Expensify__2_.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~014061867ab191f52d
Upwork Job ID: 1715778155199119360
Last Price Increase: 2023-11-18

@anmurali

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Job added to Upwork: https://www.upwork.com/jobs/~014061867ab191f52d

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@abdulrahuman5196

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

@tgolen

can you check if the refactoring issue is really removing the deep link? If I remember correctly, I think @tgolen is making change in a way that still supports deep linking to money-request related pages

Proposal

Please re-state the problem that we are trying to solve in this issue.

If Scan option is originally selected (where the keyboard is not normally needed), coming there using a Participant deep link opens the keyboard briefly.

What is the root cause of that problem?

With the introduction of the autoFocus prop in BaseOptionsSelector.js, which appears to have originally aimed to fix a focus issue in web and desktop (relevant commits: 4c478d3, 90b96de, f45b2ca, 7ff6e00, 0d2d560, 70beac8, 5d28fdb, 5788291), the relevant platform specific constraint ([CONST.PLATFORM.DESKTOP, CONST.PLATFORM.WEB].includes(getPlatform())) to allow this.textInput.focus() to execute inside setTimeout was only introduced in componentDidUpdate and is missing from componentDidMount.

What changes do you think we should make in order to solve the problem?

The same platform specific constraint ([CONST.PLATFORM.DESKTOP, CONST.PLATFORM.WEB].includes(getPlatform())) should be introduced in componentDidMount to this.textInput.focus() inside setTimeout.

What alternative solutions did you explore? (Optional)

NA

Additional note

Note that shouldDelayFocus in src/components/OptionsSelector/index.android.js could be removed as part of this change as it appears to be unnecessary, it's not being used in BaseOptionsSelector.js at all.

Also note that I could not reproduce the part where the participant list appeared briefly first, but I do believe this solution should resolve the issue of the keyboard unnecessarily opening in that case as well, otherwise it should probably be investigated as a separate issue.

@anmurali

@anmurali, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@anmurali

@anmurali, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@anmurali

@anmurali @abdulrahuman5196 this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@anmurali

Hi! I was looking at this, and I think the problem is solved in my PR that refactors these components. This can probably be closed as won't fix for now.

cc: @anmurali / Or we can keep in hold also

Gentle Ping @anmurali

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@anmurali

@anmurali, @abdulrahuman5196 Still overdue 6 days?! Let's take care of this!

Closing per #30127 (comment)

Navigation Menu

Repository navigation

[$500] Request - Participant deep link opens Participant page briefly and keyboard opens in Scan #30127

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Additional note

31 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$500] Request - Participant deep link opens Participant page briefly and keyboard opens in Scan #30127

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 21, 2023

melvin-bot commented on Oct 21, 2023

melvin-bot commented on Oct 21, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Oct 21, 2023

hayata-suenaga commented on Oct 23, 2023

benomatis commented on Oct 23, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Additional note

31 remaining items

melvin-bot commented on Nov 10, 2023

melvin-bot commented on Nov 10, 2023

melvin-bot commented on Nov 11, 2023

melvin-bot commented on Nov 11, 2023

abdulrahuman5196 commented on Nov 13, 2023

melvin-bot commented on Nov 18, 2023

melvin-bot commented on Nov 20, 2023

anmurali commented on Nov 21, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions