[HOLD for payment 2023-10-31] Address - 'Hmm it's not here' page shows up when selecting a country

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.88-3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Go to Settings > Profile > Personal details > Address > Country
Select a country

Expected Result:

Country is selected successfully

Actual Result:

'Hmm it's not here' page shows up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6245644_1697905786399.bandicam_2023-10-21_20-14-31-107.mp4

MacOS: Desktop

View all open jobs on GitHub

@JmillsExpensify

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@luacmartins

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Address - 'Hmm it's not here' page shows up when selecting a country

What is the root cause of that problem?

After select country we backTo using route.params.backTo

App/src/pages/settings/Profile/PersonalDetails/CountrySelectionPage.js

Line 70 in 6031f3e

Navigation.navigate(`${route.params.backTo}?country=${option.value}`);

the issue here is the URL is not correct, so the route.params.backTo is return undifined
the url has 2 "?" ?country=US?backTo=
http://localhost:8082/settings/profile/personal-details/address/country?country=US?backTo=%2Fsettings%2Fprofile%2Fpersonal-details%2Faddress

this because getBackToParam is start with "?" regardless the main URL has "?" or not

App/src/ROUTES.ts

Lines 14 to 16 in 6031f3e

    
           function getBackToParam(backTo?: string): string { 
        
               return backTo ? `?backTo=${encodeURIComponent(backTo)}` : ''; 
        
           }

What changes do you think we should make in order to solve the problem?

We need to change getBackToParam to start with "?" if is first params and else start with "&".

function getBackToParam(backTo?: string, isFirstParam: boolean = true): string {
    return backTo ? `${isFirstParam ? "?" : "&"}backTo=${encodeURIComponent(backTo)}` : '';
}

What alternative solutions did you explore? (Optional)

or replace getBackToParam with new method getUrlWithBackToParam

function getUrlWithBackToParam(url: string, backTo?: string): string {
    const backToParam = backTo ? `${url.includes("?") ? "&" : "?"}backTo=${encodeURIComponent(backTo)}` : '';
    return url + backToParam;
}

// use it like this
// getRoute: (accountID: string | number, backTo?: string) => `a/${accountID}${getBackToParam(backTo)}`
getRoute: (accountID: string | number, backTo?: string) => getUrlWithBackToParam(`a/${accountID}`)

@tgolen

This is a regression from the PR #29813

cc @tgolen

Hmm I tried the revert of that PR but still running into a different problem when trying the reproduction steps
http://localhost:8082/settings/profile/personal-details/address

Uncaught Error: allCountries.a was not found in the default language

Just missing payment

@JmillsExpensify

@JmillsExpensify, @luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

@ahmedGaber93

@ahmedGaber93 Do you mind confirming that you haven't been paid for this issue? I'm unable to find a linked Upwork job, so I just want to be sure before creating another job.

@JmillsExpensify

@JmillsExpensify no, I haven't been paid for this issue.

Thanks I'll create an Upwork job now.

Mind applying here: https://www.upwork.com/jobs/~0172d8e78897a88014

@JmillsExpensify

@JmillsExpensify Applied.

Offer sent! Thank you

Offer paid via Upwork. Thanks everyone!

Navigation Menu

Repository navigation

[HOLD for payment 2023-10-31] Address - 'Hmm it's not here' page shows up when selecting a country #30128

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

41 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	function getBackToParam(backTo?: string): string {
	return backTo ? `?backTo=${encodeURIComponent(backTo)}` : '';
	}

[HOLD for payment 2023-10-31] Address - 'Hmm it's not here' page shows up when selecting a country #30128

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 21, 2023

melvin-bot commented on Oct 21, 2023

Bug0 Triage Checklist (Main S/O)

OSBotify commented on Oct 21, 2023

melvin-bot commented on Oct 21, 2023

ahmedGaber93 commented on Oct 21, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

dummy-1111 commented on Oct 21, 2023

thienlnam commented on Oct 22, 2023

41 remaining items

luacmartins commented on Nov 20, 2023

melvin-bot commented on Nov 24, 2023

JmillsExpensify commented on Nov 24, 2023

ahmedGaber93 commented on Nov 24, 2023

JmillsExpensify commented on Nov 24, 2023

JmillsExpensify commented on Nov 24, 2023

ahmedGaber93 commented on Nov 24, 2023

JmillsExpensify commented on Nov 24, 2023

JmillsExpensify commented on Nov 24, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions