Skip to content

[HOLD] [LOW] [Splits] IOU - Re-creating Split Bill with anonymous gmail members causes IOU to crash #30140

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.88-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

  1. Open New Expensify app
  2. Log in with an expensifail account
  3. Create Split Bill with gmail accounts with which there was no conversation history before
  4. In the created group DM with these members, request the Split Bill again

Expected Result:

Re-creating Split Bill with anonymous gmail members should register IOU with no errors for both the re-request and the first

Actual Result:

Re-creating Split Bill with anonymous gmail members causes IOU to crash

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Windows: Chrome
Bug6245877_1697922883003.Recording_1_Desktop.mp4
MacOS: Desktop

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @youssef-lr
Issue OwnerCurrent Issue Owner: @youssef-lr

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 21, 2023
  2. melvin-bot commented on Oct 21, 2023

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Oct 21, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Oct 21, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Oct 21, 2023

    @melvin-bot

    Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. pradeepmdk commented on Oct 22, 2023

    @pradeepmdk
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    IOU - Re-creating Split Bill with anonymous gmail members causes IOU to crash

    What is the root cause of that problem?

    Screenshot 2023-10-22 at 7 53 38 AM Screenshot 2023-10-22 at 7 56 06 AM Screenshot 2023-10-22 at 10 00 22 AM the root cause when we call `SplitBill` its throwing the error

    What changes do you think we should make in order to solve the problem?

    this is backend issue.
    because first time we re calling SplitBillAndOpenReport after that we are personal details with real account id. then we are calling SplitBill with those id when create split from report

    onemore issue when we call SplitBillAndOpenReport it will return personal details without login key.

  7. 150 remaining items

  8. stephanieelliott commented on Sep 17, 2024

    @stephanieelliott
    Contributor
  9. youssef-lr commented on Sep 18, 2024

    @youssef-lr
    Contributor

    Same

  10. youssef-lr commented on Oct 21, 2024

    @youssef-lr
    Contributor

    Same

  11. stephanieelliott commented on Nov 12, 2024

    @stephanieelliott
    Contributor

    Still held, looks like the blocking PR is moving though

  12. cead22 commented on Nov 19, 2024

    @cead22
    Contributor

    @davidcardoza should this be on the #billpay project?

  13. stephanieelliott commented on Nov 26, 2024

    @stephanieelliott
    Contributor

    Seems like this has been fixed! Could not repro, split expense worked fine with no error or crash:

    image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringMonthlyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions