[HOLD for payment 2023-11-09] [$500] Task - Task assignee profile opens when clicking on the header of task report

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.89-4

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Go to any chat > + > Assign task
Create a task with no assignee
On the task report, click on the report header
Verify that the task details page shows up
Repeat Step 1 to 3 with task with an assignee

Expected Result:

Task details modal opens when clicking on the report header of the task with assignee

Actual Result:

Task assignee profile opens instead of task details modal

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6247499_1698072098279.20231023_221048.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01852a4aad8299505f
Upwork Job ID: 1716479601614000128
Last Price Increase: 2023-10-23

Job added to Upwork: https://www.upwork.com/jobs/~01852a4aad8299505f

@alexpensify

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@shubham1206agra

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

I am able to repro this.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task assignee profile opens when clicking on task report header

What is the root cause of that problem?

Because of this line:

App/src/libs/ReportUtils.js

Lines 2074 to 2077 in 844b3b9

    
           if (isDM(report) && participantAccountIDs.length === 1) { 
        
               Navigation.navigate(ROUTES.PROFILE.getRoute(participantAccountIDs[0])); 
        
               return; 
        
           }

It navigates to participant or assignee detail when the task has an assignee

What changes do you think we should make in order to solve the problem?

We should change those lines to display the task detail whether there is participant( assignee) is there or not
Change

App/src/libs/ReportUtils.js

Lines 2074 to 2077 in 844b3b9

    
           if (isDM(report) && participantAccountIDs.length === 1) { 
        
               Navigation.navigate(ROUTES.PROFILE.getRoute(participantAccountIDs[0])); 
        
               return; 
        
           }

to
`

function navigateToDetailsPage(report) {
const participantAccountIDs = lodashGet(report, 'participantAccountIDs', []);
const type = lodashGet(report, 'type', '');

if (isDM(report) && participantAccountIDs.length === 1 && type !== 'task') {
    Navigation.navigate(ROUTES.PROFILE.getRoute(participantAccountIDs[0]));
    return;
}
Navigation.navigate(ROUTES.REPORT_WITH_ID_DETAILS.getRoute(report.reportID));

}

`

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task - Task assignee profile opens when clicking on the header of task report

What is the root cause of that problem?

This condition is not sufficient since isDM function is returning true for task reports also

App/src/libs/ReportUtils.js

Lines 2074 to 2077 in 844b3b9

    
           if (isDM(report) && participantAccountIDs.length === 1) { 
        
               Navigation.navigate(ROUTES.PROFILE.getRoute(participantAccountIDs[0])); 
        
               return; 
        
           }

What changes do you think we should make in order to solve the problem?

We should update the condition so that it takes task reports into consideration, like this:

isDM(report) && participantAccountIDs.length === 1 && !isTaskReport(report)

What alternative solutions did you explore? (Optional)

@FitseTLT

@FitseTLT @alitoshmatov Thank you for your proposals.
Both have very similar proposals but need more reasoning in their RCA.
Can you both elaborate on why this happens when we only assign during creating a task but not on the task where we have no assignee while creating the task?
And please also post a video too

@shubham1206agra

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
[@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@shubham1206agra] Determine if we should create a regression test for this bug.
[@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@shubham1206agra

@shubham1206agra - to prepare for the payment date, can you please complete the checklist? Thanks!

@shubham1206agra

@shubham1206agra bumping again, I'm trying to get ready for the payment date. Thanks!

@shubham1206agra

BugZero Checklist:

[@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: Add notification preference for all the reports and update the design for the group chats #28200
[@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/28200/files#r1384260896
[@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required as this is an edge case
[@shubham1206agra] Determine if we should create a regression test for this bug. Not required as this is an edge case
[@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

@bernhardoj

Here is the payment summary:

External issue reporter - N/A
Contributor that fixed the issue - @bernhardoj $500
Contributor+ that helped on the issue and/or PR - @shubham1206agra $500

Upwork Job: https://www.upwork.com/jobs/~01852a4aad8299505f

*If applicable, the bonuses will be applied on the final payment

Extra Notes regarding payment: This one was before the pre-urgency bonus change, and was merged in 3 business days.

@bernhardoj

@bernhardoj and @shubham1206agra - can you please apply to the job here:

https://www.upwork.com/jobs/~01852a4aad8299505f

It looks like the automation didn't assign it to you. Thanks, I'll complete the required steps tomorrow.

Applied

@bernhardoj

@bernhardoj and @shubham1206agra - I've started the process in Upwork. Please accept and I can apply the bonuses and close this GH. Thanks!

After reviewing the payment summary again, I confirmed with the team that the PR for this one was created after the announcement (on October 24) related to the discontinuation of the urgency bonus. The conversation is here:

https://expensify.slack.com/archives/C01GTK53T8Q/p1698191269281379

My apology for not catching this sooner, but the base payment will remain the same.

@shubham1206agra

@shubham1206agra has been paid in Upwork. @bernhardoj needs to accept and then we can pay in Upwork. Thanks!

Accepted!

Perfect, everyone has been paid via Upwork!

Navigation Menu

Repository navigation

[HOLD for payment 2023-11-09] [$500] Task - Task assignee profile opens when clicking on the header of task report #30182

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

23 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (isDM(report) && participantAccountIDs.length === 1) {
	Navigation.navigate(ROUTES.PROFILE.getRoute(participantAccountIDs[0]));
	return;
	}

[HOLD for payment 2023-11-09] [$500] Task - Task assignee profile opens when clicking on the header of task report #30182

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 23, 2023

melvin-bot commented on Oct 23, 2023

melvin-bot commented on Oct 23, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Oct 23, 2023

shubham1206agra commented on Oct 23, 2023

FitseTLT commented on Oct 23, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

alitoshmatov commented on Oct 23, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

shubham1206agra commented on Oct 24, 2023

23 remaining items

melvin-bot commented on Nov 2, 2023

alexpensify commented on Nov 3, 2023

alexpensify commented on Nov 6, 2023

shubham1206agra commented on Nov 7, 2023

alexpensify commented on Nov 9, 2023

alexpensify commented on Nov 9, 2023

bernhardoj commented on Nov 9, 2023

alexpensify commented on Nov 9, 2023

alexpensify commented on Nov 9, 2023

alexpensify commented on Nov 9, 2023

bernhardoj commented on Nov 10, 2023

alexpensify commented on Nov 10, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions