[$500] Private Note - "hmm... it's not here" page is shown when reloading in Private Notes

@daveSeife

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.89.6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1698067117518239

Action Performed:

Go to Private notes > My notes > notes
Reload page
Click on the back button

Expected Result:

Navigates back to the previous page

Actual Result:

"hmm... it's not here" page is shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

XRecorder_23102023_162246.mp4

iOS: Native

iOS: mWeb Safari

t6privatenotesReload.iOSSafari.mp4

MacOS: Chrome / Safari

t6privatenotesReload.mp4

Recording.5127.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018db0726a7be74290
Upwork Job ID: 1716562302714707968
Last Price Increase: 2023-10-30
Automatic offers:

aimane-chnaif | Reviewer | 27475744
c3024 | Contributor | 27475746
daveSeife | Reporter | 27475748

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reloading the private notes edit page and clicking on back icon shows not found page.

What is the root cause of that problem?

We have a typo here for reportID

App/src/pages/PrivateNotes/PrivateNotesEditPage.js

Line 134 in e968637

    
           onBackButtonPress={() => Navigation.goBack(ROUTES.PRIVATE_NOTES_VIEW.getRoute(report.repotID, route.params.accountID))}

What changes do you think we should make in order to solve the problem?

Fix the typo and change that to reportID

What alternative solutions did you explore? (Optional)

Result

reportIDTypo.mov

Job added to Upwork: https://www.upwork.com/jobs/~018db0726a7be74290

@lschurr

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@aimane-chnaif

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

When opening a specific private note and reloading, pressing back triggers a 404.

What is the root cause of that problem?

While on other similar routes a goBack url parameter is utilized to ensure that this specific issue doesn't happen in modals, in this one there is no goBack parameter.

When the Navigation.goBack function is triggered on the private notes edit page, it calls:
Navigation.goBack(ROUTES.PRIVATE_NOTES_VIEW.getRoute(report.reportID, route.params.accountID));

But because it is a modal, there is no report defined. Other modals use the goBack parameter for this very reason.

The private notes view routing:

    PRIVATE_NOTES_VIEW: {
        route: 'r/:reportID/notes/:accountID',
        getRoute: (reportID: string, accountID: string | number) => `r/${reportID}/notes/${accountID}`,
    },

The currency request edit view routing:

    EDIT_CURRENCY_REQUEST: {
        route: 'r/:threadReportID/edit/currency',
        getRoute: (threadReportID: string, currency: string, backTo: string) => `r/${threadReportID}/edit/currency?currency=${currency}&backTo=${backTo}`,
    },

What changes do you think we should make in order to solve the problem?

Add a back to parameter in the private notes view routing. This would also entail passing the proper report ID to the backTo parameter when calling getRoute on the private notes view.

@aimane-chnaif

@aimane-chnaif could you review the proposal here?

@daveSeife

📣 @daveSeife 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@chiragsalian

This issue has not been updated in over 15 days. @chiragsalian, @lschurr, @aimane-chnaif, @c3024 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@lschurr

PR was deployed on Nov 9.
Automation seems broken.
@lschurr can you please remove Reviewing and replace Monthly with Daily?

Looks like the automation didn't work for this one. I'll review today.

@daveSeife

Payment summary:

Bug reporter: @daveSeife $50
Contributor: @c3024 $500
Contributor+: @aimane-chnaif $500

All are paid in Upwork. Closing.

Navigation Menu

Repository navigation

[$500] Private Note - "hmm... it's not here" page is shown when reloading in Private Notes #30211

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

17 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$500] Private Note - "hmm... it's not here" page is shown when reloading in Private Notes #30211

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

c3024 commented on Oct 23, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Oct 23, 2023

melvin-bot commented on Oct 23, 2023

melvin-bot commented on Oct 23, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Oct 23, 2023

graylewis commented on Oct 23, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

lschurr commented on Oct 26, 2023

17 remaining items

melvin-bot commented on Nov 1, 2023

melvin-bot commented on Nov 27, 2023

aimane-chnaif commented on Nov 27, 2023

lschurr commented on Dec 8, 2023

lschurr commented on Dec 8, 2023

lschurr commented on Dec 8, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions