You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-17] [$500] The request money preview does not change to "delete" after the request money has been deleted. #30219
changed the title [-]The request money preview does not change to "delete" after the request money has been deleted.[/-][+][$500] The request money preview does not change to "delete" after the request money has been deleted.[/+]on Oct 23, 2023
Please re-state the problem that we are trying to solve in this issue.
The Request Money preview does not update to Delete even after the money request has been deleted after editing the amount.
What is the root cause of that problem?
The issue doesn't arise when we initially add a receipt. This bug can be easily reproducible when we edit a money request by modifying the amount or merchant fields and then deleting the chat.
We encounter two scenarios here:
In the first scenario, when text is present in the money request, the request is converted to a thread after deletion.
In the second scenario, when there is no text in the money request, it is completely removed
When we only have edit request messages in the money request chat, the conversation is transformed into a thread upon deletion and not entirely removed. In such cases, the money request should be entirely removed.
What changes do you think we should make in order to solve the problem?
When the chat contains only edited request messages, the money request should be completely removed, rather than being converted into a thread.
What alternative solutions did you explore? (Optional)
Please re-state the problem that we are trying to solve in this issue.
The request money preview does not change to "delete" after the request money has been deleted
The amount in the money request report and main chat report is shown as TBD, which should not be the case since TBD is only for distance request transactions.
What is the root cause of that problem?
When users edit the amount/description... we add the new modified message to IOU report, but did not increase childVisibleActionCount. That makes isDeletedParentAction is false -> [Deleted Request] is not shown
This logic to calculate whether a report only has distance request is incorrect. If the transaction list is empty, _.allhere will always return true, so a report without any transactions is considered as a report with only distance request transactions.
What changes do you think we should make in order to solve the problem?
When edit amount/description,... we should increase the childVisibleActionCount of parentReportAction
Please re-state the problem that we are trying to solve in this issue.
When the last money request is deleted from the IOU report, the corresponding report preview in chat report should change to [Deleted request] . While this is not required for the case where the IOU Report has no visible child actions (also the BE deletes the IOUReport and corresponding Report Preview in chat report), [Deleted request] needs to be displayed in scenarios where IOU Report has visible child actions. This is the problem we are trying to solve here.
What is the root cause of that problem?
These are improvements over an existing implementation of money requests.
What changes do you think we should make in order to solve the problem?
To solve this problem, instead of displaying the usual Report Preview content, we can display [Deleted request] when there are visible actions but there are no money requests left in the IOU Report. We can make the changes like this here
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@allroundexperts] Determine if we should create a regression test for this bug.
[@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
If no regressions arise, payment will be issued on 2024-01-17
@isabelastisser@rlinoz@allroundexperts
Would it be fair to increase the compensation to $750 for @rojiphil (C Contributor) and @allroundexperts (C+ contributor) as this PR also fixes an additional issue (with a different root cause) here.
In all, we have fixed three different issues here.
What do you think?
Activity
melvin-bot commentedon Oct 23, 2023
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.[-]The request money preview does not change to "delete" after the request money has been deleted.[/-][+][$500] The request money preview does not change to "delete" after the request money has been deleted.[/+]melvin-bot commentedon Oct 23, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01105d20ae33f4b56d
melvin-bot commentedon Oct 23, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Oct 23, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (
External)Nodebrute commentedon Oct 24, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The Request Money preview does not update to Delete even after the money request has been deleted after editing the amount.
What is the root cause of that problem?
The issue doesn't arise when we initially add a receipt. This bug can be easily reproducible when we edit a money request by modifying the amount or merchant fields and then deleting the chat.
We encounter two scenarios here:
In the first scenario, when text is present in the money request, the request is converted to a thread after deletion.
In the second scenario, when there is no text in the money request, it is completely removed
When we only have edit request messages in the money request chat, the conversation is transformed into a thread upon deletion and not entirely removed. In such cases, the money request should be entirely removed.
What changes do you think we should make in order to solve the problem?
When the chat contains only edited request messages, the money request should be completely removed, rather than being converted into a thread.
What alternative solutions did you explore? (Optional)
tienifr commentedon Oct 24, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
TBD, which should not be the case sinceTBDis only for distance request transactions.What is the root cause of that problem?
childVisibleActionCount. That makes isDeletedParentAction is false -> [Deleted Request] is not shown_.allhere will always return true, so a report without any transactions is considered as a report with only distance request transactions.What changes do you think we should make in order to solve the problem?
childVisibleActionCountof parentReportActionallTransactionsas well hereWhat alternative solutions did you explore? (Optional)
Result
Screen.Recording.2023-11-09.at.18.39.07.mov
isabelastisser commentedon Oct 25, 2023
Hey @allroundexperts, can you please review the proposals above? Thanks!
rojiphil commentedon Oct 27, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
When the last money request is deleted from the IOU report, the corresponding report preview in chat report should change to [Deleted request] . While this is not required for the case where the IOU Report has no visible child actions (also the BE deletes the IOUReport and corresponding Report Preview in chat report), [Deleted request] needs to be displayed in scenarios where IOU Report has visible child actions. This is the problem we are trying to solve here.
What is the root cause of that problem?
These are improvements over an existing implementation of money requests.
What changes do you think we should make in order to solve the problem?
To solve this problem, instead of displaying the usual
Report Previewcontent, we can display [Deleted request] when there are visible actions but there are no money requests left in the IOU Report. We can make the changes like this hereAdditionally, LHN messages also need to be updated accordingly so that [Deleted request] is displayed.
Test Video
Here is how the test video looks once this fix + fix of proposal here is implemented.
Also, refer discussion here
26511-30219-fix.mp4
What alternative solutions did you explore? (Optional)
99 remaining items
melvin-bot commentedon Jan 10, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-17. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 10, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
rojiphil commentedon Jan 17, 2024
@isabelastisser @rlinoz @allroundexperts
Would it be fair to increase the compensation to $750 for @rojiphil (C Contributor) and @allroundexperts (C+ contributor) as this PR also fixes an additional issue (with a different root cause) here.
In all, we have fixed three different issues here.
What do you think?
melvin-bot commentedon Jan 17, 2024
Payment Summary
[Upwork Job]https://www.upwork.com/jobs/~01039c8780fdfa2166
BugZero Checklist (@isabelastisser)
isabelastisser commentedon Jan 18, 2024
We are discussing the payment amount here.
isabelastisser commentedon Jan 19, 2024
Offers sent in Upwork.
Reviewer: @allroundexperts owed $750 via NewDot PENDING
isabelastisser commentedon Jan 19, 2024
@allroundexperts please complete the checklist above. Thanks!
allroundexperts commentedon Jan 21, 2024
Checklist
isabelastisser commentedon Jan 22, 2024
Thaks @allroundexperts!
JmillsExpensify commentedon Jan 30, 2024
$750 approved for @allroundexperts based on this comment.