You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-11-30] [$500] Web - Animation is not visible on desktop but visible on Mobile in sign in Modal #30252
changed the title [-]Web - Animation is not visible on desktop but visible on Mobile in sign in Modal[/-][+][$500] Web - Animation is not visible on desktop but visible on Mobile in sign in Modal[/+]on Oct 24, 2023
We can have isInModal prop from parent component SignInPageLayout passed to SignInPageContent and show the animation when the SignInPageContent used in Modal.
2. We also need to pass the `isInModal` to `SignInHeroImage` to set the dimensions of lottie animation.
```jsx
// src/pages/signin/SignInHeroImage.js
if (props.isSmallScreenWidth || props.isInModal) {
imageSize = {
height: variables.signInHeroImageMobileHeight,
width: variables.signInHeroImageMobileWidth,
};
}
Animation is not visible on desktop but visible on Mobile in sign in Modal
Root Cause
in SignInPageContent, We are showing the animation for smallscreen, This is because the same component is used for signInpage and we have different layout for the desktop in signInpage that is why the Animation only visible on smallscreen and not on desktop.
Changes
We can have isInModal prop from parent component SignInPageLayout passed to SignInPageContent and show the animation when the SignInPageContent used in Modal.
Please re-state the problem that we are trying to solve in this issue.
Animation not visible on Desktop screen.
There's another issue that I notice while investigating: When resizing the screen from Desktop to Mobile view, there's a significant lag in the sign ui changes, the UI stays as mobile UI for some time, then changes to the Desktop UI, see the video below:
What is the root cause of that problem?
The hero image currently only shows in small screen, it's missing the case where it's inside the RHN on Desktop
We're using the withWindowDimensions to render the components in the SignIn page. That HOC has the issue where the dimensions is only updated after a 300ms debounce here, that's why we can see the lag.
What changes do you think we should make in order to solve the problem?
Pass the existing shouldShowSmallScreen (which will work for both mobile screen width in modal) into here and remove the isInModal.
Pass shouldShowSmallScreen to inside SignInPageContent
Replace this condition with the shouldShowSmallScreen props, same in here.
We should use the useWindowDimensions in those places rather than the withWindowDimensions HOC, we're gradually moving the codebase to using the hook and the HOC will be deprecated soon.
What alternative solutions did you explore? (Optional)
@tienifr, it seems like passing shouldShowSmallScreen is somewhat similar to passing isInModal, given that isSmallScreenWidth is already being passed to SignInPageContent from the HOC. While transitioning to hooks from the HOC might be considered an improvement, it's not necessarily required to address the issue, but it could be a nice-to-have enhancement. Please don't take this the wrong way, but I'd have to stand by my proposal
changed the title [-][$500] Web - Animation is not visible on desktop but visible on Mobile in sign in Modal[/-][+][HOLD for payment 2023-11-30] [$500] Web - Animation is not visible on desktop but visible on Mobile in sign in Modal[/+]on Nov 23, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-30. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@thesahindiadoes not require payment (Eligible for Manual Requests)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
[@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@thesahindia] Determine if we should create a regression test for this bug.
[@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
[-]Web - Animation is not visible on desktop but visible on Mobile in sign in Modal[/-][+][$500] Web - Animation is not visible on desktop but visible on Mobile in sign in Modal[/+]melvin-bot commentedon Oct 24, 2023
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 24, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01262777214760530e
melvin-bot commentedon Oct 24, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Oct 24, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (
External)kbecciv commentedon Oct 24, 2023
Proposal by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1698067583812339
Proposal
Problem
Animation is not visible on desktop but visible on Mobile in sign in Modal
Root Cause
in [SignInPageContent] (https://github.com/Expensify/App/blob/5005161e0a4cbb0fa9e6afb693fa0690cac994c7/src/pages/signin/SignInPageLayout/SignInPageContent.js), We are showing the animation for smallscreen, This is because the same component is used for signInpage and we have different layout for the desktop in signInpage that is why the Animation only visible on smallscreen and not on desktop.
Changes
isInModalprop from parent component SignInPageLayout passed to SignInPageContent and show the animation when the SignInPageContent used in Modal.``jsx
{props.isSmallScreenWidth || props.isInModal ? (
) : null}
ishpaul777 commentedon Oct 24, 2023
Proposal
Problem
Animation is not visible on desktop but visible on Mobile in sign in Modal
Root Cause
in SignInPageContent, We are showing the animation for smallscreen, This is because the same component is used for signInpage and we have different layout for the desktop in signInpage that is why the Animation only visible on smallscreen and not on desktop.
Changes
We can have isInModal prop from parent component SignInPageLayout passed to SignInPageContent and show the animation when the SignInPageContent used in Modal.
isInModaltoSignInHeroImageto set the dimensions of lottie animation.tienifr commentedon Oct 24, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
withWindowDimensionsto render the components in the SignIn page. That HOC has the issue where the dimensions is only updated after a 300ms debounce here, that's why we can see the lag.What changes do you think we should make in order to solve the problem?
shouldShowSmallScreen(which will work for both mobile screen width in modal) into here and remove theisInModal.shouldShowSmallScreenhereshouldShowSmallScreento insideSignInPageContentshouldShowSmallScreenprops, same in here.useWindowDimensionsin those places rather than thewithWindowDimensionsHOC, we're gradually moving the codebase to using the hook and the HOC will be deprecated soon.What alternative solutions did you explore? (Optional)
NA
ishpaul777 commentedon Oct 24, 2023
@tienifr, it seems like passing shouldShowSmallScreen is somewhat similar to passing isInModal, given that isSmallScreenWidth is already being passed to SignInPageContent from the HOC. While transitioning to hooks from the HOC might be considered an improvement, it's not necessarily required to address the issue, but it could be a nice-to-have enhancement. Please don't take this the wrong way, but I'd have to stand by my proposal
29 remaining items
[-][$500] Web - Animation is not visible on desktop but visible on Mobile in sign in Modal[/-][+][HOLD for payment 2023-11-30] [$500] Web - Animation is not visible on desktop but visible on Mobile in sign in Modal[/+]melvin-bot commentedon Nov 23, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 23, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-30. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 23, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
adelekennedy commentedon Dec 1, 2023
Payouts due:
Issue Reporter: $50 @ishpaul777 (reported on the 23rd)
Contributor: $500 @tienifr (Upwork)
Contributor+: $500 @thesahindia (NewDot)
thesahindia commentedon Dec 4, 2023
I don't think we need a test case for this.
JmillsExpensify commentedon Jan 14, 2024
$500 payment approved for @thesahindia based on comment above.