Skip to content

[HOLD for payment 2023-11-30] [$500] Web - Animation is not visible on desktop but visible on Mobile in sign in Modal #30252

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.90.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1698067583812339

Action Performed:

  1. Sign out of app and open a public room - https://staging.new.expensify.com/r/7735299187836520
  2. Click Sign in Button Obsereve there is no animation.
  3. Open public room on mobile screen Observe there is animation visible

Expected Result:

Animation should be visible on Desktop screen also

Actual Result:

Animation not visible on Desktop screen.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Screenshot 2023-10-23 at 6 57 22 PM

Recording.5130.mp4
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01262777214760530e
  • Upwork Job ID: 1716804131884302336
  • Last Price Increase: 2023-10-31
  • Automatic offers:
    • tienifr | Contributor | 27550623
    • ishpaul777 | Reporter | 27550625

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 24, 2023
  2. changed the title [-]Web - Animation is not visible on desktop but visible on Mobile in sign in Modal[/-] [+][$500] Web - Animation is not visible on desktop but visible on Mobile in sign in Modal[/+] on Oct 24, 2023
  3. melvin-bot commented on Oct 24, 2023

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Oct 24, 2023

    @melvin-bot
  5. melvin-bot commented on Oct 24, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 24, 2023
  7. melvin-bot commented on Oct 24, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

  8. kbecciv commented on Oct 24, 2023

    @kbecciv
    Author

    Proposal by: @ishpaul777
    Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1698067583812339

    Proposal

    Problem

    Animation is not visible on desktop but visible on Mobile in sign in Modal

    Root Cause

    in [SignInPageContent] (https://github.com/Expensify/App/blob/5005161e0a4cbb0fa9e6afb693fa0690cac994c7/src/pages/signin/SignInPageLayout/SignInPageContent.js), We are showing the animation for smallscreen, This is because the same component is used for signInpage and we have different layout for the desktop in signInpage that is why the Animation only visible on smallscreen and not on desktop.

    Changes

    1. We can have isInModal prop from parent component SignInPageLayout passed to SignInPageContent and show the animation when the SignInPageContent used in Modal.

    ``jsx
    {props.isSmallScreenWidth || props.isInModal ? (



    ) : null}

    2. We also need to pass the `isInModal` to `SignInHeroImage` to set the dimensions of lottie animation.
    ```jsx
    // src/pages/signin/SignInHeroImage.js
    if (props.isSmallScreenWidth || props.isInModal) {
            imageSize = {
                height: variables.signInHeroImageMobileHeight,
                width: variables.signInHeroImageMobileWidth,
            };
        }
    
  9. ishpaul777 commented on Oct 24, 2023

    @ishpaul777
    Contributor

    Proposal

    Problem

    Animation is not visible on desktop but visible on Mobile in sign in Modal

    Root Cause

    in SignInPageContent, We are showing the animation for smallscreen, This is because the same component is used for signInpage and we have different layout for the desktop in signInpage that is why the Animation only visible on smallscreen and not on desktop.

    Changes

    We can have isInModal prop from parent component SignInPageLayout passed to SignInPageContent and show the animation when the SignInPageContent used in Modal.

    {props.isSmallScreenWidth || props.isInModal ? (
    <View style={[styles.mt8]}>
        <SignInHeroImage />
    </View>
    ) : null}
    1. We also need to pass the isInModal to SignInHeroImage to set the dimensions of lottie animation.
    // src/pages/signin/SignInHeroImage.js
    if (props.isSmallScreenWidth || props.isInModal) {
            imageSize = {
                height: variables.signInHeroImageMobileHeight,
                width: variables.signInHeroImageMobileWidth,
            };
        }
  10. tienifr commented on Oct 24, 2023

    @tienifr
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    1. Animation not visible on Desktop screen.
    2. There's another issue that I notice while investigating: When resizing the screen from Desktop to Mobile view, there's a significant lag in the sign ui changes, the UI stays as mobile UI for some time, then changes to the Desktop UI, see the video below:

    What is the root cause of that problem?

    1. The hero image currently only shows in small screen, it's missing the case where it's inside the RHN on Desktop
    2. We're using the withWindowDimensions to render the components in the SignIn page. That HOC has the issue where the dimensions is only updated after a 300ms debounce here, that's why we can see the lag.

    What changes do you think we should make in order to solve the problem?

    • Pass the existing shouldShowSmallScreen (which will work for both mobile screen width in modal) into here and remove the isInModal.
    • Use the shouldShowSmallScreen here
    • Pass shouldShowSmallScreen to inside SignInPageContent
    • Replace this condition with the shouldShowSmallScreen props, same in here.
    1. We should use the useWindowDimensions in those places rather than the withWindowDimensions HOC, we're gradually moving the codebase to using the hook and the HOC will be deprecated soon.

    What alternative solutions did you explore? (Optional)

    NA

  11. ishpaul777 commented on Oct 24, 2023

    @ishpaul777
    Contributor

    @tienifr, it seems like passing shouldShowSmallScreen is somewhat similar to passing isInModal, given that isSmallScreenWidth is already being passed to SignInPageContent from the HOC. While transitioning to hooks from the HOC might be considered an improvement, it's not necessarily required to address the issue, but it could be a nice-to-have enhancement. Please don't take this the wrong way, but I'd have to stand by my proposal

  12. 29 remaining items

  13. changed the title [-][$500] Web - Animation is not visible on desktop but visible on Mobile in sign in Modal[/-] [+][HOLD for payment 2023-11-30] [$500] Web - Animation is not visible on desktop but visible on Mobile in sign in Modal[/+] on Nov 23, 2023
  14. melvin-bot commented on Nov 23, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Nov 23, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-11-30. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Nov 23, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
    • [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@thesahindia] Determine if we should create a regression test for this bug.
    • [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. adelekennedy commented on Dec 1, 2023

    @adelekennedy
    Contributor

    Payouts due:

    Issue Reporter: $50 @ishpaul777 (reported on the 23rd)
    Contributor: $500 @tienifr (Upwork)
    Contributor+: $500 @thesahindia (NewDot)

  18. thesahindia commented on Dec 4, 2023

    @thesahindia
    Member

    I don't think we need a test case for this.

  19. JmillsExpensify commented on Jan 14, 2024

    @JmillsExpensify
    Contributor

    $500 payment approved for @thesahindia based on comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions