[HOLD for payment 2023-11-07] [$500] Web - App crash on device toolbar toggle

@Sourcecodedeveloper

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.90.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @Sourcecodedeveloper
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1698075798349259

Action Performed:

Login to https://staging.new.expensify.com/
Press F12 to open console
Click on toggle device toolbar

Expected Result:

App is resized to selected device

Actual Result:

The App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.webm

Recording.5133.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013db618c7bafaf3c8
Upwork Job ID: 1716860148517441536
Last Price Increase: 2023-10-24

Job added to Upwork: https://www.upwork.com/jobs/~013db618c7bafaf3c8

@trjExpensify

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@ArekChr

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

@kacper-mikolajczak

@kacper-mikolajczak is already working on this - #16161 (comment)
cc: @youssef-lr

This error comes from BoundsObserver of BaseTooltip

Proposal

Please re-state the problem that we are trying to solve in this issue.

When switching device screen size the application crashes at <BoundsObserver .../> in BaseTooltip.js

What is the root cause of that problem?

The _childRef.current in BoundsObserver is set to null due to the rendered element from the BoundsObserver's render() function being destroyed.

What changes do you think we should make in order to solve the problem?

The logic in @react-ng/bounds-observer is fairly straight forward and doesn't change often. We can implement our own equivalent that simply ignores and does nothing if the callback or childref are undefined.

What alternative solutions did you explore? (Optional)

@kacper-mikolajczak

cc @kacper-mikolajczak @cubuspl42 , what do you guys think about the proposal above?

@ArekChr

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.93-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[Fix][Web] App crash on device toolbar toggle #30462

If no regressions arise, payment will be issued on 2023-11-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@ArekChr does not require payment (Contractor)
@kacper-mikolajczak does not require payment (Contractor)
@Sourcecodedeveloper requires payment

@youssef-lr

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@youssef-lr] The PR that introduced the bug has been identified. Link to the PR: Update version to 1.0.1-490 #1616
[@youssef-lr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Migrate index.js to function component #16161 (comment)
[@youssef-lr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1699562798622679
[@ArekChr / @kacper-mikolajczak] Determine if we should create a regression test for this bug.
[@ArekChr / @kacper-mikolajczak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@ArekChr

@ArekChr @kacper-mikolajczak can we complete checklist please?

Determine if we should create a regression test for this bug.

I believe we might not require dedicated regression tests for this issue, as it appears that it would be detected during our existing testing processes.

@Sourcecodedeveloper

Yep, I tend to agree this doesn't need a regression test as a customer isn't likely to be using dev tools in the console.

@Sourcecodedeveloper you need to either provide me with your Upwork account profile or apply to this job for me to pay you the $50 bug bounty.

Thanks, sent an offer.

Settled, closing!

Navigation Menu

[HOLD for payment 2023-11-07] [$500] Web - App crash on device toolbar toggle #30278

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

33 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-11-07] [$500] Web - App crash on device toolbar toggle #30278

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 24, 2023

melvin-bot commented on Oct 24, 2023

melvin-bot commented on Oct 24, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Oct 24, 2023

situchan commented on Oct 24, 2023

yh-0218 commented on Oct 24, 2023

iiredalert commented on Oct 24, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

youssef-lr commented on Oct 25, 2023

33 remaining items

melvin-bot commented on Oct 31, 2023

melvin-bot commented on Oct 31, 2023

youssef-lr commented on Nov 9, 2023

ArekChr commented on Nov 13, 2023

trjExpensify commented on Nov 13, 2023

trjExpensify commented on Nov 13, 2023

trjExpensify commented on Nov 13, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions