Repository navigation
Request money - All currencies not displayed in search results #30387
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.3.91-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR #29876
Action Performed:
- Click global green +
- Select Request Money
- Go to Manual tab
- On desktop and on desktop-web, hover over the currency symbol and verify the tooltip says "Select a currency"
- Click on the currency symbol
- Start typing in the search field
Expected Result:
At the top of the search results, the text "All currencies" is translated and displayed properly
Actual Result:
All Currencies not displayed
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- Windows: Chrome
- MacOS: Desktop
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Windows: Chrome
Activity
melvin-bot commentedon Oct 25, 2023
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 25, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Oct 25, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Oct 25, 2023
Triggered auto assignment to @thienlnam (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.thienlnam commentedon Oct 25, 2023
I'm not entirely sure what the bug is - is the problem that the text 'All currencies' is not there?
joekaufmanexpensify commentedon Oct 25, 2023
Agreed.
thienlnam commentedon Oct 25, 2023
@tgolen It doesn't look like the text 'All currencies' is displayed in the results from this PR as expected #29876
Expected:
Actual:
Though I don't think this needs to be a blocker so removing that label for now
tgolen commentedon Oct 27, 2023
Sorry! At the last minute before that PR was merged, another PR was merged that removes the "all currencies" text. I forgot to update the QA steps before it got merged. This can be closed since it's working as expected.