Skip to content

Deploy Checklist: New Expensify 2023-10-30 #30560

Closed

Description

@OSBotify

Release Version: 1.3.93-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Activity

  1. Beamanator commented on Oct 30, 2023

    @Beamanator
    Contributor

    Wrote this little script to help check off old items from new checklist:

    function checkOffOldPRsOnNewChecklist(oldChecklist, newChecklist) {
        const oldPrNums = oldChecklist
            .trim()
            .split('\n')
            .map(prURL => prURL.substr(prURL.lastIndexOf('/') + 1));
    
        const output = newChecklist
            .trim()
            .split('\n')
            .map((prURL) => {
                const prNum = prURL.substr(prURL.lastIndexOf('/') + 1);
                const isChecked = prURL.toLowerCase().indexOf('[x]') >= 0 || oldPrNums.includes(prNum);
                const ghChecklistPrefix = isChecked ? '- [x] ' : '- [ ] ';
    
                return `${ghChecklistPrefix}https://github.com/Expensify/App/pull/${prNum}`;
            })
            .join('\n');
    
        // Copy new checklist with updated checked items to clipboard
        copy(output);
    }
  2. Beamanator commented on Oct 30, 2023

    @Beamanator
    Contributor
    Output:
    - [ ] https://github.com/Expensify/App/pull/23702
    - [x] https://github.com/Expensify/App/pull/26605
    - [x] https://github.com/Expensify/App/pull/27306
    - [x] https://github.com/Expensify/App/pull/27429
    - [x] https://github.com/Expensify/App/pull/27764
    - [ ] https://github.com/Expensify/App/pull/27994
    - [x] https://github.com/Expensify/App/pull/28296
    - [x] https://github.com/Expensify/App/pull/28352
    - [x] https://github.com/Expensify/App/pull/28381
    - [ ] https://github.com/Expensify/App/pull/28587
    - [x] https://github.com/Expensify/App/pull/28596
    - [x] https://github.com/Expensify/App/pull/28887
    - [x] https://github.com/Expensify/App/pull/28939
    - [ ] https://github.com/Expensify/App/pull/29014
    - [x] https://github.com/Expensify/App/pull/29095
    - [x] https://github.com/Expensify/App/pull/29284
    - [x] https://github.com/Expensify/App/pull/29315
    - [ ] https://github.com/Expensify/App/pull/29338
    - [ ] https://github.com/Expensify/App/pull/29434
    - [x] https://github.com/Expensify/App/pull/29443
    - [x] https://github.com/Expensify/App/pull/29643
    - [x] https://github.com/Expensify/App/pull/29668
    - [x] https://github.com/Expensify/App/pull/29757
    - [ ] https://github.com/Expensify/App/pull/29765
    - [x] https://github.com/Expensify/App/pull/29771
    - [x] https://github.com/Expensify/App/pull/29785
    - [ ] https://github.com/Expensify/App/pull/29848
    - [x] https://github.com/Expensify/App/pull/29869
    - [x] https://github.com/Expensify/App/pull/29891
    - [x] https://github.com/Expensify/App/pull/29924
    - [ ] https://github.com/Expensify/App/pull/29927
    - [ ] https://github.com/Expensify/App/pull/29931
    - [ ] https://github.com/Expensify/App/pull/29936
    - [x] https://github.com/Expensify/App/pull/29952
    - [x] https://github.com/Expensify/App/pull/29970
    - [x] https://github.com/Expensify/App/pull/29989
    - [x] https://github.com/Expensify/App/pull/30013
    - [x] https://github.com/Expensify/App/pull/30029
    - [ ] https://github.com/Expensify/App/pull/30049
    - [x] https://github.com/Expensify/App/pull/30058
    - [x] https://github.com/Expensify/App/pull/30071
    - [x] https://github.com/Expensify/App/pull/30091
    - [x] https://github.com/Expensify/App/pull/30099
    - [x] https://github.com/Expensify/App/pull/30163
    - [x] https://github.com/Expensify/App/pull/30164
    - [ ] https://github.com/Expensify/App/pull/30186
    - [ ] https://github.com/Expensify/App/pull/30192
    - [x] https://github.com/Expensify/App/pull/30213
    - [x] https://github.com/Expensify/App/pull/30226
    - [x] https://github.com/Expensify/App/pull/30227
    - [x] https://github.com/Expensify/App/pull/30234
    - [x] https://github.com/Expensify/App/pull/30241
    - [x] https://github.com/Expensify/App/pull/30243
    - [x] https://github.com/Expensify/App/pull/30259
    - [x] https://github.com/Expensify/App/pull/30260
    - [x] https://github.com/Expensify/App/pull/30266
    - [ ] https://github.com/Expensify/App/pull/30270
    - [ ] https://github.com/Expensify/App/pull/30287
    - [x] https://github.com/Expensify/App/pull/30301
    - [x] https://github.com/Expensify/App/pull/30315
    - [x] https://github.com/Expensify/App/pull/30317
    - [x] https://github.com/Expensify/App/pull/30321
    - [x] https://github.com/Expensify/App/pull/30327
    - [x] https://github.com/Expensify/App/pull/30335
    - [ ] https://github.com/Expensify/App/pull/30357
    - [ ] https://github.com/Expensify/App/pull/30363
    - [ ] https://github.com/Expensify/App/pull/30369
    - [x] https://github.com/Expensify/App/pull/30379
    - [x] https://github.com/Expensify/App/pull/30383
    - [ ] https://github.com/Expensify/App/pull/30397
    - [ ] https://github.com/Expensify/App/pull/30402
    - [ ] https://github.com/Expensify/App/pull/30403
    - [x] https://github.com/Expensify/App/pull/30406
    - [ ] https://github.com/Expensify/App/pull/30417
    - [x] https://github.com/Expensify/App/pull/30440
    - [x] https://github.com/Expensify/App/pull/30450
    - [ ] https://github.com/Expensify/App/pull/30461
    - [ ] https://github.com/Expensify/App/pull/30462
    - [x] https://github.com/Expensify/App/pull/30463
    - [ ] https://github.com/Expensify/App/pull/30486
    - [ ] https://github.com/Expensify/App/pull/30497
    - [ ] https://github.com/Expensify/App/pull/30519
    - [ ] https://github.com/Expensify/App/pull/30521
    - [x] https://github.com/Expensify/App/pull/30522
    - [ ] https://github.com/Expensify/App/pull/30534
    
  3. self-assigned this
    on Oct 30, 2023
  4. OSBotify commented on Oct 30, 2023

    @OSBotify
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.93-0 🚀

  5. kavimuru commented on Oct 30, 2023

    @kavimuru
  6. luacmartins commented on Oct 30, 2023

    @luacmartins
    Contributor

    Checking off #30592. Demoted to NAB.

  7. kavimuru commented on Oct 30, 2023

    @kavimuru

    Regression is at 40%
    #27994 failing with #30546
    #28587,#29338,#30497 failing with #30578
    #30521 and #29434 failing with #30584

  8. kavimuru commented on Oct 30, 2023

    @kavimuru

    Regression is at 70% progress
    #27994 failing with #30546
    #28587,#29338,#30497 failing with #30578
    #30521 and #29434 failing with #30584
    #23702 failing with #30610

  9. mvtglobally commented on Oct 31, 2023

    @mvtglobally

    Regression is at 7%. We will wrap it up early EST

    Unchecked PRs
    #23702 failing with #30610. Blocker label removed, Ok to check it off?
    #27994 failing with #30546. Blocker label removed, Ok to check it off?
    #28587 failing with #30578

    #30521 and #29434 failing with #30584. Repro in PROD. Checking off

  10. Beamanator commented on Oct 31, 2023

    @Beamanator
    Contributor

    It looks like there's only 1% left in testrail? It would be amazing if we could get this done this morning, but no worries of not possible

  11. Beamanator commented on Oct 31, 2023

    @Beamanator
    Contributor

    #23702 failing with #30610. Blocker label removed, Ok to check it off?
    #27994 failing with #30546. Blocker label removed, Ok to check it off?

    Great, yes! I checked these off 👍

  12. Beamanator commented on Oct 31, 2023

    @Beamanator
    Contributor

    #28587 failing with #30578

    This has a fix PR here: #30559

    I'll CP then check off the list

  13. Julesssss commented on Oct 31, 2023

    @Julesssss
    Contributor

    I checked off blocker #30593 as its only a console error. No need to block deploy. cc @rlinoz

  14. kavimuru commented on Oct 31, 2023

    @kavimuru

    Regression is completed.
    One open blocker #30607
    unchecked PR #28587 , Seems it is fixed with this CP #30559 (comment) - OK to check it off?

  15. Beamanator commented on Oct 31, 2023

    @Beamanator
    Contributor

    Thanks @kavimuru !

    #30607 is being looked into currently 👍

    unchecked PR #28587 , Seems it is fixed with this CP #30559 (comment) - OK to check it off?

    Yes agreed, OK to check it off! 👍

  16. Beamanator commented on Oct 31, 2023

    @Beamanator
    Contributor

    @kavimuru just checking, did you test #30559 on all platforms? I only tested on Web so far and it's passing

  17. kavimuru commented on Oct 31, 2023

    @kavimuru

    @Beamanator I will test in other platform and update.

  18. Beamanator commented on Oct 31, 2023

    @Beamanator
    Contributor

    Thank so much @kavimuru ! 🙏

  19. kavimuru commented on Oct 31, 2023

    @kavimuru

    @Beamanator It's a pass in all other platforms but Android. If this is expected as per this comment #30559 (comment), good to check it off.

  20. Beamanator commented on Oct 31, 2023

    @Beamanator
    Contributor

    Niiice, thanks for testing & pointing that out, let's check it off!! 👍

  21. Beamanator commented on Oct 31, 2023

    @Beamanator
    Contributor

    #30607 checked off b/c it was fixed with https://github.com/Expensify/Auth/pull/9088 & tested well in staging 👍

    One more DP was added so I'll try to look now!

  22. Beamanator commented on Oct 31, 2023

    @Beamanator
    Contributor

    Checking off #30644 (comment) b/c we agreed it's NAB! That's the last deploy blocker!

  23. Beamanator commented on Oct 31, 2023

    @Beamanator
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions