Closed
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 1.3.93-1
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Show info about workspace members added by secondary logins #23702
- [No QA] Sorted import aliases #26605
- Fix all offline created transaction is deleted when we delete one of the transaction #27306
- Fix: [Violation] Added non-passive event listener to a scroll-blocking 'wheel' event #27429
- Refactor/16226/auth screens components migration to functional #27764
- Add subscribe to parent comment action menu #27994
- Remove the categories beta #28296
- Create Security.md #28352
- [No QA][TS migration] Migrate 'Welcome.js' lib to TypeScript #28381
- [TS migration] Migrate 'PolicyUtils.js' lib to TypeScript #28587
- [TS migration] Migrate 'SidebarUtils.js' lib to TypeScript #28596
- Create Domain-Settings-Overview.md #28887
- Update and rename Get-The-Card.md to Request-the-Card.md #28939
- Update Business-Bank-Accounts-USD.md #29014
- refactor(28902): [FlashList migration] PaymentMethodList #29095
- [No QA] [TS migration] Migrate 'useEnvironment.js' hook and 'withEnvironment.js' HOC #29284
- [No QA] [TS Migration] Migrate useReportScrollManager and ReportScreenContext to TypeScript #29315
- [TS migration] Migrate 'KeyboardShortcut' lib to TypeScript #29338
- RTL Text gets renderd properly #29434
- [TS migration] Migrate 'withAnimatedRef.js' HOC to TypeScript - Remove dead code #29443
- Improved initial value in useRefs - changed useRefs to more suitable hooks #29643
- Update Direct-Bank-Connections.md #29668
- [No QA] [TS migration] Migrate 'FormScrollView.js' component to TypeScript #29757
- [TS migration] Migrate 'SignInPageForm' component to TypeScript #29765
- [Form Provider Refactor] RoomNameInput #29771
- [Form Provider Refactor] LegalNamePage #29785
- Added allOptions to scrollToIndex callback dependencies #29848
- [Form Provider Refactor] NewContactMethodPage #29869
- Update Troubleshooting.md #29891
- Publishing ExpensifyHelp article - Update Currency.md #29924
- Plaid popup continue to open from resume app #29927
- Added 'name' field to waypoint #29931
- Update request money header title #29936
- [Form Provider Refactor] StatusSetPage #29952
- [No QA][TS migration] Migrate 'RadioButtons.js' component to TypeScript #29970
- [No QA] [TS migration] Migrate 'KeyboardDismissingFlatList' component to TypeScript #29989
- Remove hidden reports like threads from the global unread count #30013
- [No QA] Ensure OSBotify key exists before running next steps in setupGitForOSBotifyApp #30029
- Fix report action draft still present after deleting the workspace #30049
- Fix bug with When deleting a money request offline, the IOU skeleton changes the currency to $0.00 #30058
- [Form Provider Refactor] PrivateNotesEditPage #30071
- Update Overview.md #30091
- fix clip icon briefly showing on attachment preview #30099
- [Form Provider Refactor] TaskTitlePage #30163
- [Form Provider Refactor] TaskDescriptionPage #30164
- Update dependencies on desktop package file to fix vulnerabilities #30186
- fix: vertical centering button text without padding #30192
- reduce label size and remove placeholder in new chat room #30213
- Fix: wider gap between mention or emoji suggestion box and composer #30226
- fix: Android 2FA - Input field hides behind the keyboard #30227
- [TS migration] Migrate 'InlineSystemMessage.js' component to TypeScript #30234
- [No QA] [TS migration] Remove 'ExpensifyCashLogo.js' component #30241
- fix: highlighting the first emoji while filtering #30243
- Fix: Double page submission on Edit Amount page #30259
- Fix: email pattern not recognised when sending a comment #30260
- fix: 29950 Reload on title and description of task field does not focus back #30266
- Add github action for imgbot review and merge #30270
- fix error message positioning on amount page #30287
- fix: replace emojis on mount(both the main composer and edit composer) #30301
- [No QA] Skip tests, lint and deploys for unrelated changes #30315
- fix: update parent action only if the action has no visible children #30317
- Update @xmldom/xmldom to avoid critical vulnerabilities #30321
- Update Other-Export-Options.md #30327
- [NO QA]Fix the translation #30335
- Fix/28599: Trim the draft private note #30357
- Fix crash when opening sign in modal as anonymous user #30363
- Update Tags.md #30369
- Update imgbot permissions #30379
- [ImgBot] Optimize images #30383
- [CP staging] fix/30373 - regression fix for NavigationAwareCamera #30397
- Build MacOS Desktop from Intel machines in order to support x86 #30402
- Revert "Amount changing to zero when editing it by going back in spli… #30403
- Memo HeaderView #30406
- fix: update style if icon is in button #30417
- [No QA] update the screenshots template in the reviewer checklist #30440
- Update Card-Settings.md #30450
- Add autoScrollToTopThreshold to main chat list #30461
- [Fix][Web] App crash on device toolbar toggle #30462
- [ImgBot] Optimize images #30463
- chore: use optionRowHeight instead of paymentMethodHeight #30486
- [TS Migration] Style fixes in Text.tsx #30497
- Update formatting per prettier #30519
- emoji/mention suggestion are displayed #30521
- [No QA] Include more paths in lint workflow #30522
- Update QuickBooks-Online.md #30534
- [CP Staging] input of '[' and other special characters fixed #30559
Deploy Blockers:
- [HOLD for payment 2024-01-17] Unsubscribe icon shows up after leaving your own thread #30546
- [HOLD for payment 2023-11-09] Can't write some symbols in newDot #30578
- Chat - Unable to type a few symbols and console error shows up #30583
- Threads - Context menu shows 'Unsubscribe from thread' after leaving the thread #30587
- [$500] Bank account - Extra padding between bank account selector and ToS checkbox #30588
- [HOLD for payment 2023-11-17] Connect bank account - "You're all set!" message appears for a moment when deleting BA #30592
- [$500] [HOLD for payment 2023-11-09] Error thrown when left and right arrow keys pressed #30593
- [$500] mWeb - Compose Box - The magnifying glass moves up when words are highlighted #30594
- Web - Compose box - When moving the cursor over text using arrows in the console, errors occur #30596
- IOU - Manual IOU amount doubles after requesting #30607
- [$500] Workspace - "Added with primary logins" message remains when removing members offline #30610
- [HOLD for payment 2023-12-28] [$500] Thread - Admin lands in [Delete message] after login when employee subscribes to welcome message #30644
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
Beamanator commentedon Oct 30, 2023
Wrote this little script to help check off old items from new checklist:
Beamanator commentedon Oct 30, 2023
Output:
OSBotify commentedon Oct 30, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.93-0 🚀
kavimuru commentedon Oct 30, 2023
Checking the past build
#29931
#30049
#30192
#30270
#30363
#30397
#30402
#30403
#30417
#30461
luacmartins commentedon Oct 30, 2023
Checking off #30592. Demoted to NAB.
kavimuru commentedon Oct 30, 2023
Regression is at 40%
#27994 failing with #30546
#28587,#29338,#30497 failing with #30578
#30521 and #29434 failing with #30584
kavimuru commentedon Oct 30, 2023
Regression is at 70% progress
#27994 failing with #30546
#28587,#29338,#30497 failing with #30578
#30521 and #29434 failing with #30584
#23702 failing with #30610
mvtglobally commentedon Oct 31, 2023
Regression is at 7%. We will wrap it up early EST
Unchecked PRs
#23702 failing with #30610. Blocker label removed, Ok to check it off?
#27994 failing with #30546. Blocker label removed, Ok to check it off?
#28587 failing with #30578
#30521 and #29434 failing with #30584. Repro in PROD. Checking off
Beamanator commentedon Oct 31, 2023
It looks like there's only 1% left in testrail? It would be amazing if we could get this done this morning, but no worries of not possible
Beamanator commentedon Oct 31, 2023
Great, yes! I checked these off 👍
Beamanator commentedon Oct 31, 2023
This has a fix PR here: #30559
I'll CP then check off the list
Julesssss commentedon Oct 31, 2023
I checked off blocker #30593 as its only a console error. No need to block deploy. cc @rlinoz
kavimuru commentedon Oct 31, 2023
Regression is completed.
One open blocker #30607
unchecked PR #28587 , Seems it is fixed with this CP #30559 (comment) - OK to check it off?
Beamanator commentedon Oct 31, 2023
Thanks @kavimuru !
#30607 is being looked into currently 👍
Yes agreed, OK to check it off! 👍
Beamanator commentedon Oct 31, 2023
@kavimuru just checking, did you test #30559 on all platforms? I only tested on Web so far and it's passing
kavimuru commentedon Oct 31, 2023
@Beamanator I will test in other platform and update.
Beamanator commentedon Oct 31, 2023
Thank so much @kavimuru ! 🙏
kavimuru commentedon Oct 31, 2023
@Beamanator It's a pass in all other platforms but Android. If this is expected as per this comment #30559 (comment), good to check it off.
Beamanator commentedon Oct 31, 2023
Niiice, thanks for testing & pointing that out, let's check it off!! 👍
Beamanator commentedon Oct 31, 2023
#30607 checked off b/c it was fixed with https://github.com/Expensify/Auth/pull/9088 & tested well in staging 👍
One more DP was added so I'll try to look now!
Beamanator commentedon Oct 31, 2023
Checking off #30644 (comment) b/c we agreed it's NAB! That's the last deploy blocker!
Beamanator commentedon Oct 31, 2023