Skip to content

[HOLD for payment 2023-12-20] [HOLD for payment 2023-12-12] [Tracking] Use measureFunction from reassure to cover performance testing of important functions #30569

Closed

Description

@mountiny

Coming from here https://expensify.slack.com/archives/C05LX9D6E07/p1698193710179789

We have set up the reassure in the App with new option to use measureFunction to test performance of methods. Lets use this to cover the most crucial method in the app to ensure changes do not introduce big regressions in these methods which might already take long and are called often.

Let's focus on methods in ReportActionsUtils, SidebarUtils (getOptionData specifically) and ReportUtils

Activity

  1. changed the title [-][] Use measure[/-] [+][Tracking] Use measureFunction from reassure to cover performance testing of important functions[/+] on Oct 30, 2023
  2. self-assigned this
    on Oct 30, 2023
  3. mountiny commented on Nov 8, 2023

    @mountiny
    ContributorAuthor

    this is being worked on

  4. mountiny commented on Nov 30, 2023

    @mountiny
    ContributorAuthor

    Making a steady progress 🚀

  5. 9 remaining items

  6. OlimpiaZurek commented on Dec 8, 2023

    @OlimpiaZurek
    Contributor

    @mountiny PR is ready for review

  7. changed the title [-][HOLD for payment 2023-12-12] [Tracking] Use measureFunction from reassure to cover performance testing of important functions[/-] [+][HOLD for payment 2023-12-20] [HOLD for payment 2023-12-12] [Tracking] Use measureFunction from reassure to cover performance testing of important functions[/+] on Dec 13, 2023
  8. melvin-bot commented on Dec 13, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Dec 13, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-12-20. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR
  10. mountiny commented on Dec 13, 2023

    @mountiny
    ContributorAuthor

    Seems like we are all done here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions