Skip to content

[$500] Public room can't be seen on LHN after opening it from a link #30615

New issue
New issue
Closed
Closed
[$500] Public room can't be seen on LHN after opening it from a link#30615
Assignees
neil-marcellinijliexpensifythesahindiadukenv0307
Labels
BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Description

@lanitochka17
lanitochka17
opened on Oct 30, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.93-0
**Reproducible in staging?:**Y
**Reproducible in production?:**Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Log out
  3. Navigate to this link - https://staging.new.expensify.com/r/3504895439653267
  4. Log in with any accounts

Expected Result:

The public room should be displayed

Actual Result:

The public room can't be seen on LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Window: Chrome

Bug6257319_1698697773901!Screenshot_602

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010cd18e947fb2a8d5
  • Upwork Job ID: 1719138151952470016
  • Last Price Increase: 2023-10-30
  • Automatic offers:
    • dukenv0307 | Contributor | 27493079

Activity

  1. lanitochka17
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 30, 2023
  2. melvin-bot
    changed the title [-]Public room can't be seen on LHN after opening it from a link[/-] [+][$500] Public room can't be seen on LHN after opening it from a link[/+] on Oct 30, 2023
  3. melvin-bot
    assigned
    jliexpensify
    on Oct 30, 2023

  4. melvin-bot commented on Oct 30, 2023

    @melvin-bot
    melvin-botBot
    on Oct 30, 2023

    Job added to Upwork: https://www.upwork.com/jobs/~010cd18e947fb2a8d5

  5. melvin-bot commented on Oct 30, 2023

    @melvin-bot
    melvin-botBot
    on Oct 30, 2023

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  6. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 30, 2023

  7. melvin-bot commented on Oct 30, 2023

    @melvin-bot
    melvin-botBot
    on Oct 30, 2023

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  8. melvin-bot
    assigned
    thesahindia
    on Oct 30, 2023

  9. melvin-bot commented on Oct 30, 2023

    @melvin-bot
    melvin-botBot
    on Oct 30, 2023

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

  10. erquhart commented on Oct 31, 2023

    @erquhart
    erquhart
    on Oct 31, 2023
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    If the current chat is a public room, it should show in the left hand nav.

    What is the root cause of that problem?

    Public rooms were removed from the left hand nav in a recent PR:
    https://github.com/Expensify/App/pull/27966/files#diff-65c096044d5f69b35bcdec14c99c4fda4580759df9b1a7c36650d58eea276f1d

    What changes do you think we should make in order to solve the problem?

    Revert to fix (tested locally, works).

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  11. jliexpensify commented on Oct 31, 2023

    @jliexpensify
    jliexpensify
    on Oct 31, 2023
    Contributor

    Hmm I'm unable to repro on Staging v1.3.93-0 (Chrome) - LHN is there for me:

    image

  12. erquhart commented on Oct 31, 2023

    @erquhart
    erquhart
    on Oct 31, 2023
    Contributor

    @jliexpensify left hand nav is there, but the public channel currently being viewed isn’t in the list.

  13. jliexpensify commented on Oct 31, 2023

    @jliexpensify
    jliexpensify
    on Oct 31, 2023
    Contributor

    Ah sorry, my mistake - thanks @erquhart!

  14. 15 remaining items

  15. neil-marcellini commented on Nov 2, 2023

    @neil-marcellini
    neil-marcellini
    on Nov 2, 2023
    Contributor

    Cool, I agree that the proposal from @dukenv0307 looks good.

  16. melvin-bot
    added
    ReviewingHas a PR in review
    WeeklyKSv2
    and removed
    DailyKSv2
    on Nov 3, 2023

  17. dukenv0307 commented on Nov 3, 2023

    @dukenv0307
    dukenv0307
    on Nov 3, 2023
    Contributor

    @thesahindia The PR is ready for review.

  18. jliexpensify commented on Nov 21, 2023

    @jliexpensify
    jliexpensify
    on Nov 21, 2023
    Contributor

    Hrrrm what happened with the updater here? It looks like this hit production 2 weeks ago right? If so, I should be paying + the checklist should be worked on, right?

  19. jliexpensify
    changed the title [-][$500] Public room can't be seen on LHN after opening it from a link[/-] [+][NEED TO PAY?][$500] Public room can't be seen on LHN after opening it from a link[/+] on Nov 21, 2023

  20. dukenv0307 commented on Nov 21, 2023

    @dukenv0307
    dukenv0307
    on Nov 21, 2023
    Contributor

    Yes, seems like bot not work on this issue.

  21. jliexpensify commented on Nov 21, 2023

    @jliexpensify
    jliexpensify
    on Nov 21, 2023
    Contributor

    If we are going off #30814, here's the Payment Summary:

    • Contributor: @dukenv0307 $750 (bonus as it was merged in 3 working days)
    • C+: @thesahindia$750 (bonus as it was merged in 3 working days) - NEW.DOT PAYMENT

    Upworks job

    is this all correct? @thesahindia could you complete the checklist too?

  22. jliexpensify commented on Nov 21, 2023

    @jliexpensify
    jliexpensify
    on Nov 21, 2023
    Contributor

    Paid and job closed. Waiting on checklist to be completed!

  23. jliexpensify
    changed the title [-][NEED TO PAY?][$500] Public room can't be seen on LHN after opening it from a link[/-] [+][WAITING ON CHECKLIST][$500] Public room can't be seen on LHN after opening it from a link[/+] on Nov 21, 2023

  24. thesahindia commented on Nov 22, 2023

    @thesahindia
    thesahindia
    on Nov 22, 2023
    Member

    We just need to update the condition here to be the following. I forgot to take into account public announce rooms in my PR.

    As mentioned in #30615 (comment), this case wasn't taken into account.

    We can add a test case -

    1. Login to user A and create a public room for workspace that doesn't contain user B
    2. Log out and open the public room using the link
    3. Login to account B
    4. Verify the room is visible in the LHN
  25. jliexpensify
    changed the title [-][WAITING ON CHECKLIST][$500] Public room can't be seen on LHN after opening it from a link[/-] [+][$500] Public room can't be seen on LHN after opening it from a link[/+] on Nov 22, 2023
  26. jliexpensify
    closed this as completedon Nov 22, 2023

  27. JmillsExpensify commented on Nov 27, 2023

    @JmillsExpensify
    JmillsExpensify
    on Nov 27, 2023
    Contributor

    $750 payment approved for @thesahindia based on this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions