Repository navigation
[$500] Bank - Indian address is entered but in States section, US states drop down list is shown #30693
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
**Version Number:**1.3.94-0
**Reproducible in staging?:**Y
**Reproducible in production?:**Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
**Issue reported by:**Applause - Internal Team
Slack conversation:
Action Performed:
- Launch app
- Tap profile icon
- Tap on Workspaces
- Tap on a Workspace
- Tap Bank account
- Tap connect manually
- Enter all details and tap next
- In profile page, in company address section, enter "India"
- From suggested list, select address "India-Pakistan Border road"
- Tap State
- Scroll down the page
Expected Result:
When Indian address is entered, in States section, Indian states drop down list must be shown
Actual Result:
When Indian address is entered, in States section, US states drop down list is shown
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6259157_1698831183907.indi.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0107d7dfae949d0ead
- Upwork Job ID: 1719699161108930560
- Last Price Increase: 2023-11-01
- Automatic offers:
- s77rt | Reviewer | 27475593
- dukenv0307 | Contributor | 27475596
Activity
melvin-bot commentedon Nov 1, 2023
Triggered auto assignment to @puneetlath (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.[-]Bank - Indian address is entered but in States section, US states drop down list is shown[/-][+][$500] Bank - Indian address is entered but in States section, US states drop down list is shown[/+]melvin-bot commentedon Nov 1, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0107d7dfae949d0ead
melvin-bot commentedon Nov 1, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Nov 1, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)dukenv0307 commentedon Nov 1, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
When Indian address is entered, in States section, US states drop down list is shown
What is the root cause of that problem?
In the bank company flow, we're always showing
StatePicker, regardless of the country selected.What changes do you think we should make in order to solve the problem?
In the bank company flow, we should show
StatePickeronly if country selected is USA.We need to double check all flow that use StatePicker as well to make sure that's correct.
What alternative solutions did you explore? (Optional)
If only USA companies are allowed to create bank account, we should limit the country available in the
AddressFormto only US, this can be done by setting theisLimitedToUSAto true in this flow. And as a fallback we should show an error in the field if we select a non-US address.ishpaul777 commentedon Nov 1, 2023
Not a bug, we only allow US address in bank account flow, so we have dropdown for US states only best we can do is to show error when selected address is not US. That would require a approval from internal so not adding a proposal.
erquhart commentedon Nov 1, 2023
@dukenv0307 proposal is what I was about to say as well, the bug is that
isLimitedToUSAprop isn't set on theAddressForm, as the company info section is clearly aimed at US companies only. +1.s77rt commentedon Nov 1, 2023
@dukenv0307 Thanks for the proposal. I think passing
isLimitedToUSAmakes sense here 👍.🎀 👀 🎀 C+ reviewed
Link to proposal
melvin-bot commentedon Nov 1, 2023
Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.
melvin-bot commentedon Nov 1, 2023
📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
puneetlath commentedon Nov 1, 2023
Agreed, no point in showing options you can't choose.
melvin-bot commentedon Nov 1, 2023
📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
dukenv0307 commentedon Nov 2, 2023
@s77rt The PR is ready for review.
puneetlath commentedon Nov 21, 2023
Whoops. This has been on prod but it looks like the automation didn't run to update the issue. Paid you both, so we're good to go here. Thanks!