[$500] IOS - The app flashes after selecting 'Copy to Clipboard'

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.94.0
**Reproducible in staging?:**Y
**Reproducible in production?:**n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
**Issue reported by:**Applause - Internal Team
Slack conversation:

Issue found when executing PR #30085

Action Performed:

Open the app in either MacOS Safari v17 and above or Safari on iPhone 15 and above
Go to any chat and right click/Long press on a chat message to view the context menu
Click/Press on Copy to clipboard

Expected Result:

The app does not flash after selecting 'Copy to Clipboard'

Actual Result:

The app flashes after selecting 'Copy to Clipboard'

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6259491_1698849945657.Screen_Recording_20231101_102829_New_Expensify__2_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d6cd889f3d0aa3a9
Upwork Job ID: 1719740024722116608
Last Price Increase: 2023-11-22

Job added to Upwork: https://www.upwork.com/jobs/~01d6cd889f3d0aa3a9

@bfitzexpensify

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@aimane-chnaif

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOS - The app flashes after selecting 'Copy to Clipboard'

What is the root cause of that problem?

This is visible effect of Modal disappearing.
Now we have Modal hide time issue on iOS and Android.
This make above issue

What changes do you think we should make in order to solve the problem?

We need to fix Mobile animation issue when close Modal.

Then that effect will not appear flashes
Slow hide of Modal
This works well on iOS and Android

What alternative solutions did you explore? (Optional)

Screen.Recording.2023-11-01.at.9.27.34.PM.mov

I was not able to reproduce this on the latest iPhone 15 models or simulators, this might only be happening on older devices due to performance.

Proposal

Please re-state the problem that we are trying to solve in this issue

After selecting 'Copy to Clipboard' on a chat message via the context menu, there's a flash when the popup closes.

What is the root cause of that problem?

This was an issue of react-native-modal: react-native-modal/react-native-modal#92 for when using the modal prop useNativeDriver={true} on native which we currently do.

The solution was they added the hideModalContentWhileAnimating prop which was the chosen workaround implementation for this issue.

This is already used within our codebase, for example in the YearPickerModal to address similar performance issues:

App/src/components/NewDatePicker/CalendarPicker/YearPickerModal.js

Line 60 in 8d44cac

hideModalContentWhileAnimating

What changes do you think we should make in order to solve the problem?

Add the hideModalContentWhileAnimating (true) prop to PopoverReportActionContextMenu -> PopoverWithMeasuredContent component.

Videos

iOS: Native

Screen.Recording.2023-11-03.at.14.59.45.mov

@bfitzexpensify

@bfitzexpensify, @aimane-chnaif Huh... This is 4 days overdue. Who can take care of this?

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@lanitochka17

Bump on the questions in #30706 (comment) @lanitochka17 - thank you!

@bfitzexpensify

hi, @bfitzexpensify how do you think about my proposal?

@lanitochka17

Hi @lanitochka17, clarifying questions:

can you please clarify what "flash" means here?
"IOS" is stated in issue title but attached video is android. Does it happen on native only or mWeb as well?

@bfitzexpensify

@bfitzexpensify @aimane-chnaif this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Issue not reproducible during KI retests. (First week)

OK, considering this has been identifed as not reproducible, I think we can close this for the moment.

Navigation Menu

Repository navigation

[$500] IOS - The app flashes after selecting 'Copy to Clipboard' #30706

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Videos

16 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$500] IOS - The app flashes after selecting 'Copy to Clipboard' #30706

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 1, 2023

melvin-bot commented on Nov 1, 2023

melvin-bot commented on Nov 1, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Nov 1, 2023

yh-0218 commented on Nov 1, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

ikevin127 commented on Nov 3, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Videos

melvin-bot commented on Nov 7, 2023

16 remaining items

melvin-bot commented on Nov 15, 2023

bfitzexpensify commented on Nov 17, 2023

yh-0218 commented on Nov 17, 2023

bfitzexpensify commented on Nov 20, 2023

melvin-bot commented on Nov 22, 2023

melvin-bot commented on Nov 22, 2023

mvtglobally commented on Nov 23, 2023

bfitzexpensify commented on Nov 23, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions