Repository navigation
mWeb - Settings - Sign out option not visible in smaller size devices #3072
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Expected Result:
Sign out button is visible
Actual Result:
Sign out button isn't visible
Action Performed:
- Go to https://staging.expensify.cash
- Log in with any account
- Go to Setting
- Try to Log out
Workaround:
Unknown
Platform:
Where is this issue occurring?
Web
iOS
Android
Desktop App
Mobile Web ✔️
Version Number: 1.0.51-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Issue reproduced in iPhone 6S and iPhone8
Bug5079506_Image_From_Ios__6_-1.mp4
Expensify/Expensify Issue URL:
Activity
MelvinBot commentedon May 21, 2021
Triggered auto assignment to @bfitzexpensify (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.shawnborton commentedon May 21, 2021
Seems like we just need to make sure this page is in a scrollView, much like we do with other pages in Settings.
isagoico commentedon May 23, 2021
Issue reproducible today during KI retests
bfitzexpensify commentedon May 24, 2021
Upwork posting.
MelvinBot commentedon May 24, 2021
Triggered auto assignment to @johnmlee101 (
Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.aliabbasmalik8 commentedon May 24, 2021
PROPOSAL
We can fix this by removing
pointerEvents="box-none"at this point https://github.com/Expensify/Expensify.cash/blob/9f305176681385f2aa80f43de06fc6dffa7f0b83/src/pages/settings/InitialPage.js#L112VIDEO AFTER IMPLEMENTED SOLUTION: https://recordit.co/yfOjPUKsq3
Thanks
HunainAnis commentedon May 24, 2021
Okay, I can make the sidebar scrollable to view the signout button.
johnmlee101 commentedon May 24, 2021
@aliabbasmalik8 your proposal looks good.
aliabbasmalik8 commentedon May 24, 2021
can I start work?
johnmlee101 commentedon May 24, 2021
Let's wait for @bfitzexpensify to accept the proposal on his end
bfitzexpensify commentedon May 25, 2021
Thanks @aliabbasmalik8, hired you on Upwork! Feel free to get started on a PR.
isagoico commentedon May 26, 2021
FIxed 🎉
