You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Public Room-Anonymous user can download images #30806
**Version Number:**1.3.95-0
**Reproducible in staging?:**Y
**Reproducible in production?:**Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL:
**Issue reported by:**Applause - Internal Team Slack conversation:
Action Performed:
Log out of New Dot Expensify if previously logged in
@muttmuure can you please double check the expected behavior?
If this is not bug, I think we should update something since this is reported by QA team.
Activity
[-]Public Room-Anonymous user can download images[/-][+][$500] Public Room-Anonymous user can download images[/+]melvin-bot commentedon Nov 2, 2023
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Nov 2, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0114824716246f4944
melvin-bot commentedon Nov 2, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Nov 2, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (
External)tienifr commentedon Nov 2, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Anonymous user can download images in public rooms.
What is the root cause of that problem?
We allow Download for annonymous user here:
App/src/pages/home/report/ContextMenu/ContextMenuActions.js
Line 93 in 5ae80bd
What changes do you think we should make in order to solve the problem?
Set the above prop to
false.What alternative solutions did you explore? (Optional)
NA
yh-0218 commentedon Nov 2, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Anonymous user can download images in public rooms.
What is the root cause of that problem?
Download is allowed for annonymous user.
App/src/pages/home/report/ContextMenu/ContextMenuActions.js
Line 93 in 11a7170
What changes do you think we should make in order to solve the problem?
isAnonymousAction: false&& !Session.isAnonymousUser()hereApp/src/components/AttachmentModal.js
Line 422 in 11a7170
What alternative solutions did you explore? (Optional)
Screen.Recording.2023-11-03.at.1.39.16.AM.mov
DylanDylann commentedon Nov 3, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
fileDownloadused to handle download action in entire the app.App/src/libs/fileDownload/index.js
Line 10 in d53a03e
isAnonymousActionto this.What alternative solutions did you explore? (Optional)
dukenv0307 commentedon Nov 3, 2023
It's expected behavior that we decided here #22321
melvin-bot commentedon Nov 6, 2023
@muttmuure, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!
situchan commentedon Nov 6, 2023
@muttmuure can you please double check the expected behavior?
If this is not bug, I think we should update something since this is reported by QA team.
NisargDeveloper commentedon Nov 7, 2023
Are you searching for a resolution?
muttmuure commentedon Nov 9, 2023
Seems like expected behavior to me
muttmuure commentedon Nov 9, 2023
QA will come back to this issue and see that it is closed as expected. I'm not aware of anywhere that we say it is not.
@lanitochka17 if you find that we say that this should not happen, please let me know where and I will get it updated. Thank you!