[HOLD for payment 2023-11-13] [$500] IOU - Green dot in 1:1 DM in LHN does not disappear after paying the IOU offline

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.95.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Navigate to staging.new.expensify.com
[User B] Request money from User A.
[User A] Go offline.
[User A] Pay the IOU requested by User B.
[User A] Go to LHN.

Expected Result:

The green dot in 1:1 DM in LHN will disappear after paying the IOU.

Actual Result:

The green dot in 1:1 DM in LHN does not disappear after paying the IOU offline. It only disappears after returning online.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6262312_1699019558183.20231103_214903.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01310266fc6c713472
Upwork Job ID: 1721559941023154176
Last Price Increase: 2023-11-06
Automatic offers:

aimane-chnaif | Contributor | 27548566
DylanDylann | Contributor | 27548568

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@Li357

Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Green dot in 1:1 DM in LHN does not disappear after paying the IOU offline

What is the root cause of that problem?

We are using hasOutstandingChildRequest as a flag to display green dot

App/src/libs/ReportUtils.js

Line 1435 in 509d352

if (option.hasOutstandingChildRequest) {

In payMoneyRequest function, we don't reset hasOutstandingChildRequest to false in optimisticdata of report

App/src/libs/actions/IOU.js

Lines 2445 to 2455 in bc9cb8f

    
           onyxMethod: Onyx.METHOD.MERGE, 
        
           key: `${ONYXKEYS.COLLECTION.REPORT}${chatReport.reportID}`, 
        
           value: { 
        
               ...chatReport, 
        
               lastReadTime: DateUtils.getDBTime(), 
        
               lastVisibleActionCreated: optimisticIOUReportAction.created, 
        
               hasOutstandingIOU: false, 
        
               iouReportID: null, 
        
               lastMessageText: optimisticIOUReportAction.message[0].text, 
        
               lastMessageHtml: optimisticIOUReportAction.message[0].html, 
        
           },

What changes do you think we should make in order to solve the problem?

We need to add hasOutstandingChildRequest to false in optimisticdata here

App/src/libs/actions/IOU.js

Lines 2445 to 2455 in bc9cb8f

    
           onyxMethod: Onyx.METHOD.MERGE, 
        
           key: `${ONYXKEYS.COLLECTION.REPORT}${chatReport.reportID}`, 
        
           value: { 
        
               ...chatReport, 
        
               lastReadTime: DateUtils.getDBTime(), 
        
               lastVisibleActionCreated: optimisticIOUReportAction.created, 
        
               hasOutstandingIOU: false, 
        
               iouReportID: null, 
        
               lastMessageText: optimisticIOUReportAction.message[0].text, 
        
               lastMessageHtml: optimisticIOUReportAction.message[0].html, 
        
           },

App/src/libs/actions/IOU.js

Lines 2468 to 2476 in bc9cb8f

    
           onyxMethod: Onyx.METHOD.MERGE, 
        
           key: `${ONYXKEYS.COLLECTION.REPORT}${iouReport.reportID}`, 
        
           value: { 
        
               ...iouReport, 
        
               lastMessageText: optimisticIOUReportAction.message[0].text, 
        
               lastMessageHtml: optimisticIOUReportAction.message[0].html, 
        
               hasOutstandingIOU: false, 
        
               statusNum: CONST.REPORT.STATUS.REIMBURSED, 
        
           },

What alternative solutions did you explore? (Optional)

@DylanDylann

@DylanDylann that sounds good. Are you able to raise a PR asap?

Job added to Upwork: https://www.upwork.com/jobs/~01310266fc6c713472

@puneetlath

@puneetlath Oke I can raise PR now

@aimane-chnaif

📣 @aimane-chnaif 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@DylanDylann

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

All paid. Thanks everyone!

Navigation Menu

Repository navigation

[HOLD for payment 2023-11-13] [$500] IOU - Green dot in 1:1 DM in LHN does not disappear after paying the IOU offline #30848

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

19 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${chatReport.reportID}`,
	value: {
	...chatReport,
	lastReadTime: DateUtils.getDBTime(),
	lastVisibleActionCreated: optimisticIOUReportAction.created,
	hasOutstandingIOU: false,
	iouReportID: null,
	lastMessageText: optimisticIOUReportAction.message[0].text,
	lastMessageHtml: optimisticIOUReportAction.message[0].html,
	},

	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${iouReport.reportID}`,
	value: {
	...iouReport,
	lastMessageText: optimisticIOUReportAction.message[0].text,
	lastMessageHtml: optimisticIOUReportAction.message[0].html,
	hasOutstandingIOU: false,
	statusNum: CONST.REPORT.STATUS.REIMBURSED,
	},

[HOLD for payment 2023-11-13] [$500] IOU - Green dot in 1:1 DM in LHN does not disappear after paying the IOU offline #30848

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

OSBotify commented on Nov 3, 2023

melvin-bot commented on Nov 3, 2023

DylanDylann commented on Nov 3, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

puneetlath commented on Nov 6, 2023

melvin-bot commented on Nov 6, 2023

DylanDylann commented on Nov 6, 2023

19 remaining items

melvin-bot commented on Nov 6, 2023

melvin-bot commented on Nov 6, 2023

puneetlath commented on Nov 13, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions