Repository navigation
[HOLD for payment 2023-11-13] Android - Bank - After opening calendar for incorporation date day that comes before is selected #30871
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.3.95-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
**Issue reported by:**Applause - Internal Team
Slack conversation:
Issue found when executing PR #30845
Action Performed:
- Open the app
- Navigate to any Workspace > Bank Account
- Complete the bank connection flow until step 2 "Incorporation date"
- Tap "Incorporation date" and select a date, e.g. 01/01/1980
- Open the calendar again
Expected Result:
The previously chosen date "01/01/1980" is still selected
Actual Result:
The day that comes before is selected (12/31/1979)
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon Nov 3, 2023
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Nov 3, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Nov 3, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Nov 3, 2023
Triggered auto assignment to @tgolen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.tgolen commentedon Nov 3, 2023
@allroundexperts Do you think this has anything to do with some of the changes you've made related to #30845 ?
erquhart commentedon Nov 3, 2023
@tgolen @allroundexperts
new Date()is still in use as an ISO string parser in a few places, Android DatePicker is one of them:App/src/components/DatePicker/index.android.js
Line 64 in aa30ef2
Need to swap that for first one for date-fns
parseISO().This is the same root cause as #30792
18 remaining items
melvin-bot commentedon Nov 6, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
bfitzexpensify commentedon Nov 13, 2023
I'd like to clarify the relationship between the solution in this issue and the solution for #30792. It sounds like they had the same root cause, but there are separate PRs to fix the two issues. Are they closely enough aligned to consider them as one solution?
erquhart commentedon Nov 13, 2023
@bfitzexpensify they are exactly the same issue.
new Date()was used instead ofparseISO()in a lot of places. #30792 was fixed by updating a few of those instances, this issue was fixed by updating a few more. There are still others.tgolen commentedon Nov 15, 2023
@bfitzexpensify I think this is ready to be paid out?
situchan commentedon Nov 15, 2023
I think I am only the one for payment here. Other contributors' payments are being handled in #30792.
bfitzexpensify commentedon Nov 15, 2023
Thanks for confirming @erquhart. And yes, the other payments + BZ checklist will happen in #30792, so the only action here is payment for @situchan — the offer has been sent.
bfitzexpensify commentedon Nov 15, 2023
OK, payment complete, closing this one out.