Skip to content

[HOLD for payment 2023-12-04] [CRITICAL] Migrate the LHNOptionsList to Flashlist #30910

New issue
New issue
Closed
Closed
[HOLD for payment 2023-12-04] [CRITICAL] Migrate the LHNOptionsList to Flashlist#30910
Assignees
garrettmknightTMisiukiewiczroryabraham
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Description

@mountiny
mountiny
opened on Nov 6, 2023

HOLD on #30242

Part of #28902

Let's migrate LHNOptionsList to use Flashlist component instead of FlatList

Callstack is working on the migration right now.

Lets use this issue for daily updates on this migration

Activity

  1. mountiny
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 6, 2023
  2. mountiny
    assigned
    roryabraham
    on Nov 6, 2023
  3. mountiny
    added this to [#whatsnext] #qualityon Nov 6, 2023

  4. melvin-bot commented on Nov 6, 2023

    @melvin-bot
    melvin-botBot
    on Nov 6, 2023 – with Melvin Bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. melvin-bot
    assigned
    garrettmknight
    on Nov 6, 2023

  6. melvin-bot commented on Nov 6, 2023

    @melvin-bot
    melvin-botBot
    on Nov 6, 2023 – with Melvin Bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. mountiny
    moved this to CRITICAL in [#whatsnext] #qualityon Nov 6, 2023

  8. TMisiukiewicz commented on Nov 6, 2023

    @TMisiukiewicz
    TMisiukiewicz
    on Nov 6, 2023
    Contributor

    Hi, I'm Tomasz from Callstack, I'd like to work on that issue

  9. mountiny
    assigned
    TMisiukiewicz
    on Nov 6, 2023

  10. TMisiukiewicz commented on Nov 6, 2023

    @TMisiukiewicz
    TMisiukiewicz
    on Nov 6, 2023
    Contributor

    Waiting for #30242 to be reviewed and merged, once it's done I'll create a proper PR

  11. roryabraham commented on Nov 6, 2023

    @roryabraham
    roryabraham
    on Nov 6, 2023
    Contributor

    Ok, then let's put this one HOLD for that

  12. roryabraham
    changed the title [-][CRITICAL] Migrate the LHNOptionsList to Flashlist[/-] [+][HOLD][CRITICAL] Migrate the LHNOptionsList to Flashlist[/+] on Nov 6, 2023

  13. TMisiukiewicz commented on Nov 6, 2023

    @TMisiukiewicz
    TMisiukiewicz
    on Nov 6, 2023
    Contributor

    #30242 is merged now, we can remove hold status

  14. garrettmknight
    changed the title [-][HOLD][CRITICAL] Migrate the LHNOptionsList to Flashlist[/-] [+][CRITICAL] Migrate the LHNOptionsList to Flashlist[/+] on Nov 6, 2023

  15. 24 remaining items

  16. melvin-bot commented on Nov 27, 2023

    @melvin-bot
    melvin-botBot
    on Nov 27, 2023 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@roryabraham] The PR that introduced the bug has been identified. Link to the PR:
    • [@roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@TMisiukiewicz] Determine if we should create a regression test for this bug.
    • [@TMisiukiewicz] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Dec 3, 2023

  18. garrettmknight commented on Dec 4, 2023

    @garrettmknight
    garrettmknight
    on Dec 4, 2023
    Contributor

    @TMisiukiewicz Good to close?

  19. situchan commented on Dec 4, 2023

    @situchan
    situchan
    on Dec 4, 2023
    Contributor

    yes, only C+ payment for PR review is remaining

  20. garrettmknight commented on Dec 7, 2023

    @garrettmknight
    garrettmknight
    on Dec 7, 2023
    Contributor

    @situchan I think payment for that PR should get handled in #31610. Is there something I'm missing here?

  21. melvin-bot
    added
    Overdue
    on Dec 7, 2023

  22. melvin-bot commented on Dec 7, 2023

    @melvin-bot
    melvin-botBot
    on Dec 7, 2023 – with Melvin Bot

    @garrettmknight, @TMisiukiewicz, @roryabraham Whoops! This issue is 2 days overdue. Let's get this updated quick!

  23. garrettmknight commented on Dec 7, 2023

    @garrettmknight
    garrettmknight
    on Dec 7, 2023
    Contributor

    Not overdue, confirming which issue to pay on.

  24. melvin-bot
    removed
    Overdue
    on Dec 7, 2023

  25. situchan commented on Dec 7, 2023

    @situchan
    situchan
    on Dec 7, 2023
    Contributor

    #31610 is for #31642 (I was PR author)
    #30910 is for #31711 (I was PR reviewer)

  26. garrettmknight commented on Dec 7, 2023

    @garrettmknight
    garrettmknight
    on Dec 7, 2023
    Contributor

    Got it - thanks for clarifying. Offer's out to you.

  27. garrettmknight commented on Dec 7, 2023

    @garrettmknight
    garrettmknight
    on Dec 7, 2023
    Contributor

    And paid! Closing

  28. garrettmknight
    closed this as completedon Dec 7, 2023
  29. github-project-automation
    moved this from CRITICAL to Done in [#whatsnext] #qualityon Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions