Chat - Default avatars are shown in LHN instead of custom ones

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.96.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Go to staging.new.expensify.com or open Expensify App
Login with any account
Check user avatars in LHN

Expected Result:

Custom avatars are shown in LHN for users who have them

Actual Result:

Default avatars are shown in LHN for all users, even if custom ones are loaded

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6266648_1699313780903.Chat-default-avatars-instead-custom.mp4

View all open jobs on GitHub

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@cead22

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Discussed in slack, but I think we can fix this by removing the call to _.values here

I pushed a draft PR with another potential solution, in case we wanna go that route

@adhorodyski

Hi, I'm Tomasz from Callstack, seems like a regression from #30242 I've been working on together with @adhorodyski. I think solution proposed by @roryabraham is correct - I'll take care of creating the PR

gonna push this forwards now

@johncschuster

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@rushatgabhane

Fixed, we will have to pay @rushatgabhane for review

@mountiny

@mountiny what amount should I request on new dot?

I guess this would be $500 based on the classic rules

request here- https://staging.new.expensify.com/r/8616790277990951

I believe we can close this one now and the payer will come back here to confirm once request has been paid.

Navigation Menu

Repository navigation

Chat - Default avatars are shown in LHN instead of custom ones #30932

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

5 remaining items

Bug0 Triage Checklist (Main S/O)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Chat - Default avatars are shown in LHN instead of custom ones #30932

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

OSBotify commented on Nov 6, 2023

melvin-bot commented on Nov 6, 2023

roryabraham commented on Nov 7, 2023

cead22 commented on Nov 7, 2023

TMisiukiewicz commented on Nov 7, 2023

mountiny commented on Nov 7, 2023

5 remaining items

melvin-bot commented on Nov 7, 2023

melvin-bot commented on Nov 7, 2023

Bug0 Triage Checklist (Main S/O)

mountiny commented on Nov 7, 2023

rushatgabhane commented on Nov 12, 2023

mountiny commented on Nov 13, 2023

rushatgabhane commented on Nov 17, 2023

mountiny commented on Nov 20, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions