Repository navigation
[HOLD for payment 2023-11-17] [$500] The app crashes when taping on link https://staging.new.expensify.com/request/new/participants #30933
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.3.96.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
- Launch the app
- Log in with any account
- Tap on https://staging.new.expensify.com/request/new/participants
Expected Result:
App is not crashed
Actual Result:
The app crashes when taping on link https://staging.new.expensify.com/request/new/participants
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Screen_Recording_20231106_183139_New.Expensify.1.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01b97b835cfc1fe6d6
- Upwork Job ID: 1721768998901219328
- Last Price Increase: 2023-11-07
- Automatic offers:
- fedirjh | Reviewer | 27552830
- dukenv0307 | Contributor | 27552832
- situchan | Contributor | 27553607
Activity
kbecciv commentedon Nov 7, 2023
Issue is not reproducible in production
RPReplay_Final1699314789.MP4
OSBotify commentedon Nov 7, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Nov 7, 2023
Triggered auto assignment to @robertjchen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.dukenv0307 commentedon Nov 7, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The app crashes when taping on link https://staging.new.expensify.com/request/new/participants
What is the root cause of that problem?
When we go to the participant page directly by deep-link, the iou field on ONYX will be undefined
App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js
Line 170 in da2c79e
So that App crash because we are reading transactionID of underfined
What changes do you think we should make in order to solve the problem?
App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js
Line 170 in da2c79e
we should update like this
And then App will auto redirect to the step 1 of request flow
What alternative solutions did you explore? (Optional)
[-]The app crashes when taping on link https://staging.new.expensify.com/request/new/participants[/-][+][$500] The app crashes when taping on link https://staging.new.expensify.com/request/new/participants[/+]melvin-bot commentedon Nov 7, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01b97b835cfc1fe6d6
melvin-bot commentedon Nov 7, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (
External)robertjchen commentedon Nov 7, 2023
@dukenv0307 that makes sense! Let's go with that proposal 👍
29 remaining items
melvin-bot commentedon Nov 10, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 10, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.97-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-17. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
robertjchen commentedon Nov 21, 2023
Looks like this feel through the cracks, let me find someone here to handle the next steps. Thanks for your patience!
melvin-bot commentedon Nov 21, 2023
Triggered auto assignment to @peterdbarkerUK (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Nov 21, 2023
conorpendergrast commentedon Nov 21, 2023
@peterdbarkerUK this wasn't labelled with
Bugwhen it was created, and is due payment now (Bobby mentioned it via Slack)!peterdbarkerUK commentedon Nov 21, 2023
Payment summary:
$500 to @dukenv0307 (contributor)
$500 to @situchan (C+ / reviewer)
Job closed on UpWork. Thanks guys!