[HOLD for payment 2023-11-17] [$500] mWeb/Chrome - Start Chat- #Rooms creation menu is misaligned

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.96-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

Go to https://staging.new.expensify.com/
Tap fab
Tap start chat
Tap chat---room--chat (navigate to and fro)

Expected Result:

The room page left margin must show enough space and alignment of page must be correct.

Actual Result:

After tapping chat, if user taps room, by navigating to and fro, left margin no space is shown and alignment is not fine.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6266785_1699326229571.6room.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a9e9cfdca0e3fa3a
Upwork Job ID: 1721845296933953536
Last Price Increase: 2023-11-07
Automatic offers:

situchan | Reviewer | 27576928
tienifr | Contributor | 27576931

Job added to Upwork: https://www.upwork.com/jobs/~01a9e9cfdca0e3fa3a

@peterdbarkerUK

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@situchan

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

Not reproduced in production

Screen_Recording_20231107_103714_Chrome.mp4

PR ready for review #31063.

Reviewing label has been removed, please complete the "BugZero Checklist".

@situchan

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.97-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix: New room page is misaligned after page transition #31063

If no regressions arise, payment will be issued on 2023-11-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@situchan requires payment offer (Reviewer)
@tienifr requires payment offer (Contributor)

@situchan

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@peterdbarkerUK] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@situchan

Noice. @situchan I'm on the fence about this needing specific regression testing, what do you think?

Payments sent:

@tienifr $500 Contributor
@situchan $500 Reviewer

Job closed

The root cause is performance degrade. Handling that in #31190
This was caught by Applause team so no need specific regression testing.

Navigation Menu

Repository navigation

[HOLD for payment 2023-11-17] [$500] mWeb/Chrome - Start Chat- #Rooms creation menu is misaligned #30976

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

21 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-11-17] [$500] mWeb/Chrome - Start Chat- #Rooms creation menu is misaligned #30976

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 7, 2023

melvin-bot commented on Nov 7, 2023

melvin-bot commented on Nov 7, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Nov 7, 2023

izarutskaya commented on Nov 7, 2023

21 remaining items

tienifr commented on Nov 8, 2023

melvin-bot commented on Nov 10, 2023

melvin-bot commented on Nov 10, 2023

melvin-bot commented on Nov 10, 2023

peterdbarkerUK commented on Nov 17, 2023

situchan commented on Nov 17, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions