Skip to content

[HOLD for payment 2023-12-06] [$250] Workspace - Custom invitation message is still preserved after sending an invitation #30992

New issue
New issue
Closed
Closed
[HOLD for payment 2023-12-06] [$250] Workspace - Custom invitation message is still preserved after sending an invitation#30992
Assignees
akinwalemallenexpensifymountinyDylanDylann
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Description

@izarutskaya
izarutskaya
opened on Nov 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Found when executing PR : #30562

Version Number: v1.3.96-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

  1. Navigate to staging.new.expensify.com.
  2. Go to Settings > Workspaces > any workspace.
  3. Go to Members > Invite.
  4. Select any user and proceed to the next page.
  5. Enter a custom invitation message.
  6. Click invite.
  7. Repeat Step 1-5 with another workspace.

Expected Result:

The invitation messages are saved per workspace basis. They are reset after signout out and sign back in but while user is signed in, we keep the welcome message saved per workspace

Actual Result:

The custom invitation message is preserved across policies

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6267203_1699356178822.20231107_110919.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017cd1e2909d9808bd
  • Upwork Job ID: 1721871527814250496
  • Last Price Increase: 2023-11-14
  • Automatic offers:
    • akinwale | Contributor | 27756684
    • DylanDylann | Contributor | 27785352
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. izarutskaya
    added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 7, 2023
  2. melvin-bot
    changed the title [-]Workspace - Custom invitation message is still preserved after sending an invitation[/-] [+][$500] Workspace - Custom invitation message is still preserved after sending an invitation[/+] on Nov 7, 2023
  3. melvin-bot
    assigned
    mallenexpensify
    on Nov 7, 2023

  4. melvin-bot commented on Nov 7, 2023

    @melvin-bot
    melvin-botBot
    on Nov 7, 2023 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~017cd1e2909d9808bd

  5. melvin-bot commented on Nov 7, 2023

    @melvin-bot
    melvin-botBot
    on Nov 7, 2023 – with Melvin Bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  6. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 7, 2023

  7. melvin-bot commented on Nov 7, 2023

    @melvin-bot
    melvin-botBot
    on Nov 7, 2023 – with Melvin Bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  8. melvin-bot
    assigned
    thesahindia
    on Nov 7, 2023

  9. melvin-bot commented on Nov 7, 2023

    @melvin-bot
    melvin-botBot
    on Nov 7, 2023 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

  10. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Nov 7, 2023

  11. 63 remaining items

  12. melvin-bot
    added
    DailyKSv2
    and removed
    DailyKSv2
    on Dec 5, 2023

  13. mallenexpensify commented on Dec 8, 2023

    @mallenexpensify
    mallenexpensify
    on Dec 8, 2023
    Contributor

    Contributor: @DylanDylann paid $250 via Upwork
    Contributor+: @akinwale paid $250 via Upwork

    @akinwale can you please propose the regression test steps to add for the new feature? Thx

  14. melvin-bot
    added
    Overdue
    on Dec 11, 2023

  15. melvin-bot commented on Dec 11, 2023

    @melvin-bot
    melvin-botBot
    on Dec 11, 2023 – with Melvin Bot

    @akinwale, @mallenexpensify, @mountiny, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  16. mountiny commented on Dec 11, 2023

    @mountiny
    mountiny
    on Dec 11, 2023
    Contributor

    @akinwale bump please

  17. akinwale commented on Dec 11, 2023

    @akinwale
    akinwale
    on Dec 11, 2023
    Contributor

    @akinwale bump please

    Missed the initial notification. I'll get to it within an hour.

  18. akinwale commented on Dec 11, 2023

    @akinwale
    akinwale
    on Dec 11, 2023
    Contributor

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@akinwale] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    1. Launch Expensify
    2. Navigate to Settings > Workspaces and create at least two workspaces if there are no workspaces, or create an additional one if there is only one workspace created.
    3. Select a workspace and navigate to Members > Invite.
    4. Select any user and navigate to the next step.
    5. Enter a custom invitation message and click invite.
    6. Navigate back and repeat steps 3 through 6 for a different workspace.
    7. Verify that the invitation message is different for the other workspace.
    8. Repeat steps 3 through 8 for different workspaces
    9. Verify that the custom invitation message entered for each corresponding workspace does not change.
    10. Verify that two or more workspaces do not have the same custom invitation message (assuming all the custom invitation messages entered are different).

    Do we agree 👍 or 👎?

  19. mountiny commented on Dec 11, 2023

    @mountiny
    mountiny
    on Dec 11, 2023
    Contributor

    @akinwale I would update this to make it clear that the custom message should stay same on the particular workspace, ie its different across workspaces but remains unchanged on the same workspace

  20. akinwale commented on Dec 11, 2023

    @akinwale
    akinwale
    on Dec 11, 2023
    Contributor

    @mountiny Updated.

  21. mountiny commented on Dec 11, 2023

    @mountiny
    mountiny
    on Dec 11, 2023
    Contributor

    Thanks, @mallenexpensify all yours!

  22. mallenexpensify commented on Dec 12, 2023

    @mallenexpensify
    mallenexpensify
    on Dec 12, 2023
    Contributor

    Thanbks @akinwale !

  23. mallenexpensify
    closed this as completedon Dec 12, 2023
  24. melvin-bot
    removed
    Overdue
    on Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions