[HOLD for payment 2023-11-17] [$500] Chat – Page crashes when open attachment preview in any chat and reload the page (Ctrl+R)

@laurenreidexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

**Version Number:**1.3.96-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Log into NewDot with any account
Open any chat with an attachment
Click the attachment to open the preview modal
Reload the page (CTRL+R)

Expected Result:

Opens reloaded page

Actual Result:

Page crashes when open attachment preview in any chat and reload the page (CTRL+R)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6267282_1699359742415.CTRL_R.mp4

log.txt

Production

Recording.374.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0172058ac50f9604bf
Upwork Job ID: 1721905825731407872
Last Price Increase: 2023-11-07
Automatic offers:

situchan | Contributor | 27559652

Issue Owner

Current Issue Owner: @laurenreidexpensify

@laurenreidexpensify

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@johnmlee101

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Job added to Upwork: https://www.upwork.com/jobs/~0172058ac50f9604bf

Reviewing label has been removed, please complete the "BugZero Checklist".

@TMisiukiewicz

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.97-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] fix: correctly pass transactions and reportActions to LHN #31007

If no regressions arise, payment will be issued on 2023-11-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@TMisiukiewicz does not require payment (Contractor)
@situchan requires payment offer (Contributor)

@situchan

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Automation failed here - issuing payments now

@situchan

Payment Summary

C+ - @situchan payment issued in Upwork $500
Contributor - @TMisiukiewicz does not require payment (Contractor)

@situchan

Final Steps: @situchan to complete checklist and then we can close out

The PR that introduced the bug has been identified. Link to the PR: refactor: LHN dataflow rework #30242
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30242/files#r1399136571
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

This was caught by Applause - Internal Team so no need additional regression test

@laurenreidexpensify

@laurenreidexpensify I haven't received payment yet. Can you please check?

Navigation Menu

Repository navigation

[HOLD for payment 2023-11-17] [$500] Chat – Page crashes when open attachment preview in any chat and reload the page (Ctrl+R) #30998

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

31 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-11-17] [$500] Chat – Page crashes when open attachment preview in any chat and reload the page (Ctrl+R) #30998

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 7, 2023

melvin-bot commented on Nov 7, 2023

Bug0 Triage Checklist (Main S/O)

OSBotify commented on Nov 7, 2023

melvin-bot commented on Nov 7, 2023

melvin-bot commented on Nov 7, 2023

31 remaining items

melvin-bot commented on Nov 10, 2023

melvin-bot commented on Nov 10, 2023

melvin-bot commented on Nov 10, 2023

laurenreidexpensify commented on Nov 20, 2023

laurenreidexpensify commented on Nov 20, 2023

laurenreidexpensify commented on Nov 20, 2023

situchan commented on Nov 20, 2023

situchan commented on Dec 6, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions