[HOLD for payment 2023-12-12] Task - Assignee with custom avatar shows default avatar in the task report

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: .3.96-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #30515

Action Performed:

Navigate to staging.new.expensify.com
Go to chat with user that has a custom avatar
Click + > Assign task
Create a task and assign the same user in Step 1 as assignee
Open the task report

Expected Result:

The assignee in the task report shows the custom avatar

Actual Result:

The assignee in the task report shows the default avatar instead of the custom avatar

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6267894_1699387235985.20231108_033932.mp4

View all open jobs on GitHub

@isabelastisser

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@Li357

Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task asignee with custom avator shows the default avatar in the task report view

What is the root cause of that problem?

in the following line, the props.personalDetails is undefined because we dont connect to onyx to get the personal details object:

App/src/components/ReportActionItem/TaskView.js

Line 150 in 5d45f0f

    
           icon={OptionsListUtils.getAvatarsForAccountIDs([props.report.managerID], props.personalDetails)}

What changes do you think we should make in order to solve the problem?

either by adding:

    const personalDetails = usePersonalDetails() ?? CONST.EMPTY_OBJECT;

and update the line above to use this const

OR by connecting to the onyx in the component:

     withOnyx({
         personalDetails: {
             key: ONYXKEYS.PERSONAL_DETAILS_LIST,
         },
     }),

Or alternatively we add those in the withCurrentUserPersonalDetails hoc

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assignee with custom avatar shows default avatar in the task report

What is the root cause of that problem?

#30354

In this PR we remove personalDetails from Onyx and use hook to get this. And then we don't pass this to WrappedComponent

App/src/components/withCurrentUserPersonalDetails.tsx

Line 36 in c2e4042

const personalDetails = usePersonalDetails() ?? CONST.EMPTY_OBJECT;

That makes props.personalDetails is undefined and then default avatar is displayed

App/src/components/ReportActionItem/TaskView.js

Line 50 in c2e4042

    
           const assigneeTooltipDetails = ReportUtils.getDisplayNamesWithTooltips(OptionsListUtils.getPersonalDetailsForAccountIDs([props.report.managerID], props.personalDetails), false);

What changes do you think we should make in order to solve the problem?

If we don't want to pass personalDetails from withCurrentUserPersonalDetails to WrappedComponent, we should search all pages that are using this HOC and replace props.personalDetails with usePersonalDetails() hook
We should pass personalDetails to WrappedComponent in withCurrentUserPersonalDetails HOC

App/src/components/withCurrentUserPersonalDetails.tsx

Line 36 in c2e4042

const personalDetails = usePersonalDetails() ?? CONST.EMPTY_OBJECT;

What alternative solutions did you explore? (Optional)

@Li357

Hey @Li357, what's the next step here? Did you review the proposals above? Thanks!

Not overdue, payment on Dec 12.

@abzokhattab

@abzokhattab, can you please complete the checklist above?

Payment is due tomorrow.

@isabelastisser

Hi @isabelastisser I guess you meant @Li357 right?

@abzokhattab

Hey @abzokhattab, @Li357 is no longer working for Expensify. Can you please complete the checklist? Thanks!

Offer sent in Upwork.

@isabelastisser

Thanks @isabelastisser I don't think we need a regression test for this as the changes included minor refactoring.

Sounds good. All set!

Navigation Menu

Repository navigation

[HOLD for payment 2023-12-12] Task - Assignee with custom avatar shows default avatar in the task report #31028

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

24 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-12-12] Task - Assignee with custom avatar shows default avatar in the task report #31028

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 7, 2023

melvin-bot commented on Nov 7, 2023

Bug0 Triage Checklist (Main S/O)

OSBotify commented on Nov 7, 2023

melvin-bot commented on Nov 7, 2023

abzokhattab commented on Nov 7, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

dukenv0307 commented on Nov 8, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

isabelastisser commented on Nov 8, 2023

24 remaining items

isabelastisser commented on Dec 8, 2023

isabelastisser commented on Dec 11, 2023

abzokhattab commented on Dec 12, 2023

isabelastisser commented on Dec 13, 2023

isabelastisser commented on Dec 13, 2023

abzokhattab commented on Dec 13, 2023

isabelastisser commented on Dec 14, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions