You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Awaiting Payment 11th Jan] [$500] Chat-"Hmm... it's not here" appears after clicking Previous arrow from an attachment preview #31105
Version Number: 1.3.97-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation: @
Action Performed:
Create a request with a receipt via Request Money > Scan` (if you don't have one already)
Navigate to the IOU report
Add an attachment to the IOU report via + > Add attachment
Click on the uploaded attachment
Tap the < arrow in the attachment carousal
Observe the "Hmm it's not here" page
Expected Result:
The uploaded receipt can be seen in the attachment carousal modal
Actual Result:
The uploaded receipt can not be seen and "Hmm... it's not here" appears after clicking the < navigation arrow from an attachment preview
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Chat-"Hmm... it's not here" appears after clicking Previous arrow from an attachment preview[/-][+][$500] Chat-"Hmm... it's not here" appears after clicking Previous arrow from an attachment preview[/+]on Nov 9, 2023
Please re-state the problem that we are trying to solve in this issue.
"Hmm... it's not here" appears after clicking Previous arrow from an attachment preview
What is the root cause of that problem?
We get parent report action here to compare transactionID. But the report here is IOU report that makes parent report action is report preview action and then this check is wrong and not found page appears.
In ReportActionItemImage component, we will add an AttachmentModal, and then when we click on the receipt image we will open this modal instead of navigating to report attachment page.
We get parent report action here to compare transactionID. But the report here is IOU report that makes this check is wrong and not found page appears.
I think the proposal lacks a little specificity as to the root cause. Why does this only happen when the receipt is still scanning though? For example here I'm in a transaction thread on an iou report and the carousel works just fine:
Because originalMessage.IOUTransactionID doesn't exist on the parent report action.
What changes should be made to fix this?
We can skip the separate checking for receipt and use the same way that other attachments are checked with their source attribute because the source attribute always exists
Change the compareImage function to the following:
changed the title [-][$500] Chat-"Hmm... it's not here" appears after clicking Previous arrow from an attachment preview[/-][+][Awaiting Payment 11th Jan] [$500] Chat-"Hmm... it's not here" appears after clicking Previous arrow from an attachment preview[/+]on Jan 8, 2024
fyi, there were more than one regressions. I had helped with the proposal reviews and the review of the first PR that caused the first regression. Subsequently during my OOO it was assigned to @shubham1206agra.
Would like to request for partial compensation for the initial effort.
yes correct. @dukenv0307 should take responsible for fixing it.
And then I don't suggest to apply regression penalty given the efforts they made to fix this issue so far (just my suggestion)
@trjExpensify didn't you agree to not to apply regression reduction of payment here?
@trjExpensify didn't you agree to not to apply regression reduction of payment here?
I interpreted @situchan's suggestion as not penalising for the second regression with the follow-up PR, which would result in $0 technically, which I agreed with.
Yep! I've updated the payment summary here to add that. Go ahead and request.
Drawing a line in the sand, @dukenv0307 I've paid you $250. @shubham1206agra I've sent the offer for the same. Once accepted, I'll settle and close this out.
Activity
[-]Chat-"Hmm... it's not here" appears after clicking Previous arrow from an attachment preview[/-][+][$500] Chat-"Hmm... it's not here" appears after clicking Previous arrow from an attachment preview[/+]melvin-bot commentedon Nov 9, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01a232fe720233dddb
melvin-bot commentedon Nov 9, 2023
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Nov 9, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Nov 9, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)dukenv0307 commentedon Nov 9, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Hmm... it's not here" appears after clicking Previous arrow from an attachment preview
What is the root cause of that problem?
We get parent report action here to compare
transactionID. But the report here is IOU report that makes parent report action is report preview action and then this check is wrong and not found page appears.App/src/components/Attachments/AttachmentCarousel/index.js
Line 45 in 9862a3e
What changes do you think we should make in order to solve the problem?
We should check here if the report is IOU or Expense report we shouldn't add this action to attachemnt list
App/src/components/Attachments/AttachmentCarousel/extractAttachmentsFromReport.js
Line 49 in 9862a3e
What alternative solutions did you explore? (Optional)
We can remove the receipt image from carousal
App/src/components/Attachments/AttachmentCarousel/extractAttachmentsFromReport.js
Line 43 in d6cef83
2. remove the compare transactionID on
compareImagefunctionApp/src/components/Attachments/AttachmentCarousel/index.js
Line 42 in d6cef83
AttachmentModal, add an extra prop likeisReceiptImageand replaceisAttachmentReceiptstate with this propApp/src/components/AttachmentModal.js
Line 445 in 5e7022d
MoneyRequestView, we will pass full source of receipt intoReportActionItemImage.App/src/components/ReportActionItem/MoneyRequestView.js
Line 170 in 5e7022d
ReportActionItemImagecomponent, we will add anAttachmentModal, and then when we click on the receipt image we will open this modal instead of navigating to report attachment page.Result
Screen.Recording.2023-11-14.at.08.11.58.mov
trjExpensify commentedon Nov 9, 2023
I think the proposal lacks a little specificity as to the root cause. Why does this only happen when the receipt is still scanning though? For example here I'm in a transaction thread on an
ioureport and the carousel works just fine:ql9FfgDys6.mp4
esh-g commentedon Nov 9, 2023
Proposal
Please re-state the problem we are trying to solve
"Hmm... it's not here" appears after clicking Previous arrow from an attachment preview
What is the root cause of this problem?
Parent report action transaction ID checking is done wrong here:
App/src/components/Attachments/AttachmentCarousel/index.js
Lines 42 to 52 in 9862a3e
Because
originalMessage.IOUTransactionIDdoesn't exist on the parent report action.What changes should be made to fix this?
We can skip the separate checking for receipt and use the same way that other attachments are checked with their
sourceattribute because thesourceattribute always existsChange the
compareImagefunction to the following:What alternative did you explore?
We can remove the receipts from the attachments altogether by the following:
Remove the code to extract receipts as attachments here:
App/src/components/Attachments/AttachmentCarousel/extractAttachmentsFromReport.js
Lines 46 to 67 in 1615049
Change the
compareImagefunction as mentioned in the change above (maybe remove the function use an inline function for it)We can also remove the
isReceiptstate from the component and all the invocations where it is used.dukenv0307 commentedon Nov 9, 2023
@trjExpensify After the scan is complete we also can reproduce this issue and this issue happens on IOU report not in transaction report.
88 remaining items
[-][$500] Chat-"Hmm... it's not here" appears after clicking Previous arrow from an attachment preview[/-][+][Awaiting Payment 11th Jan] [$500] Chat-"Hmm... it's not here" appears after clicking Previous arrow from an attachment preview[/+]trjExpensify commentedon Jan 8, 2024
Sure, done!
trjExpensify commentedon Jan 12, 2024
Okay, so confirming payments as follows:
Payment has been reduced accordingly due to the regression. Sound right?
mananjadhav commentedon Jan 12, 2024
fyi, there were more than one regressions. I had helped with the proposal reviews and the review of the first PR that caused the first regression. Subsequently during my OOO it was assigned to @shubham1206agra.
Would like to request for partial compensation for the initial effort.
shubham1206agra commentedon Jan 12, 2024
@trjExpensify didn't you agree to not to apply regression reduction of payment here?
situchan commentedon Jan 12, 2024
I imagine split compensation 1k into 3 people 😄
trjExpensify commentedon Jan 12, 2024
Ah, I missed Manan reviewing the first PR.
I interpreted @situchan's suggestion as not penalising for the second regression with the follow-up PR, which would result in $0 technically, which I agreed with.
mananjadhav commentedon Jan 19, 2024
@trjExpensify Can you accommodate me ;)
trjExpensify commentedon Jan 19, 2024
Yep! I've updated the payment summary here to add that. Go ahead and request.
Drawing a line in the sand, @dukenv0307 I've paid you $250. @shubham1206agra I've sent the offer for the same. Once accepted, I'll settle and close this out.
shubham1206agra commentedon Jan 19, 2024
@trjExpensify Accepted
trjExpensify commentedon Jan 19, 2024
Settled up!
JmillsExpensify commentedon Jan 22, 2024
$250 payment approved for @mananjadhav based on this comment.