Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.3.97-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:
Precondition:
Create IOU with the receipt as employee
- Log in as the workspace admin
- Navigate to the workspace chat with the employee
- Navigate to the request conversation and fix the errors as the admin
Expected Result:
The admin is able to edit the missing information. Nothing strange doesn't happen.
Actual Result:
The admin is able to edit the missing information. Nothing strange doesn't happen.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6270184_1699546803287.flash.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0196a9e3104ad62434
- Upwork Job ID: 1722653994643566592
- Last Price Increase: 2023-11-09
Activity
[-]Web - IOU - App start flashing when any changes as the admin[/-][+][$500] Web - IOU - App start flashing when any changes as the admin[/+]melvin-bot commentedon Nov 9, 2023
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Nov 9, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0196a9e3104ad62434
melvin-bot commentedon Nov 9, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Nov 9, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)2 remaining items
melvin-bot commentedon Nov 9, 2023
Triggered auto assignment to @dangrous (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.melvin-bot commentedon Nov 9, 2023
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
dangrous commentedon Nov 9, 2023
git bisect weirdly did not help here, trying some other ways
dangrous commentedon Nov 9, 2023
It feels like this might be related? #28793
I coudl replicate this on local for a moment and now I can't anymore so weird stuff is happening
dangrous commentedon Nov 9, 2023
okay confirmed, removing
src/components/FlatList/index.web.js(which was added in #28793) fixes this. The PR mentions that there will be "glitches" until an upstream PR is fixed, I think we might want to revert until that time? Will copy this on the PR.puneetlath commentedon Nov 9, 2023
Yes, I agree. I think we need to revert as these glitches are not minor.
puneetlath commentedon Nov 10, 2023
The PR that caused this ended up getting reverted. Removing the deploy blocker label.
dangrous commentedon Nov 13, 2023
Closing, will handle on the updated PR for #23220