Skip to content

[$500] Web - IOU - App start flashing when any changes as the admin #31143

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.3.97-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

Precondition:
Create IOU with the receipt as employee

  1. Log in as the workspace admin
  2. Navigate to the workspace chat with the employee
  3. Navigate to the request conversation and fix the errors as the admin

Expected Result:

The admin is able to edit the missing information. Nothing strange doesn't happen.

Actual Result:

The admin is able to edit the missing information. Nothing strange doesn't happen.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6270184_1699546803287.flash.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0196a9e3104ad62434
  • Upwork Job ID: 1722653994643566592
  • Last Price Increase: 2023-11-09

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 9, 2023
  2. changed the title [-]Web - IOU - App start flashing when any changes as the admin[/-] [+][$500] Web - IOU - App start flashing when any changes as the admin[/+] on Nov 9, 2023
  3. melvin-bot commented on Nov 9, 2023

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Nov 9, 2023

    @melvin-bot
  5. melvin-bot commented on Nov 9, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 9, 2023
  7. melvin-bot commented on Nov 9, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

  8. 2 remaining items

  9. melvin-bot commented on Nov 9, 2023

    @melvin-bot

    Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  10. melvin-bot commented on Nov 9, 2023

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. dangrous commented on Nov 9, 2023

    @dangrous
    Contributor

    git bisect weirdly did not help here, trying some other ways

  12. dangrous commented on Nov 9, 2023

    @dangrous
    Contributor

    It feels like this might be related? #28793

    I coudl replicate this on local for a moment and now I can't anymore so weird stuff is happening

  13. dangrous commented on Nov 9, 2023

    @dangrous
    Contributor

    okay confirmed, removing src/components/FlatList/index.web.js (which was added in #28793) fixes this. The PR mentions that there will be "glitches" until an upstream PR is fixed, I think we might want to revert until that time? Will copy this on the PR.

  14. puneetlath commented on Nov 9, 2023

    @puneetlath
    Contributor

    Yes, I agree. I think we need to revert as these glitches are not minor.

  15. puneetlath commented on Nov 10, 2023

    @puneetlath
    Contributor

    The PR that caused this ended up getting reverted. Removing the deploy blocker label.

  16. dangrous commented on Nov 13, 2023

    @dangrous
    Contributor

    Closing, will handle on the updated PR for #23220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions