Skip to content

[HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] Nontification preferences - Mute option not seen in notification prefrences when immediately is selected #31192

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.98-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Open the app
  2. Navigate to any room or chat
  3. Tap the header Settings > Notification prefrences

Expected Result:

All the menu options "Mute", "Daily" and "Immediately" are visible

Actual Result:

The "Mute" option is not visible when "Immediately" is selected

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6271551_1699637970882.video_2023-11-10_12-38-54.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 10, 2023
  2. melvin-bot commented on Nov 10, 2023

    @melvin-bot

    Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Nov 10, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Nov 10, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Nov 10, 2023

    @melvin-bot

    Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. esh-g commented on Nov 10, 2023

    @esh-g
    Contributor

    Regression from #30972

  7. ishpaul777 commented on Nov 10, 2023

    @ishpaul777
    Contributor

    Proposal

    Problem

    Mute option not seen in notification prefrences when immediately is selected

    Root cause

    Here root cause behaviour of SectionList when we set initialScrollIndex to ">=" 2, Sectionlist just start at initialScrollIndex skip the rendering items before it (according to layout) and only render on scroll, in case of notification pref. page the items are limited no scroll event can be triggered so sectionlist wont render skipped items

    (above root cause can be verified if we set a max width to notification page screen Wrapper and apply overscroll auto manually)

    Screen.Recording.2023-11-11.at.3.19.08.AM.mov

    Solution

    we should apply the fix from #30972 selctively for cases when list is long and scrollable (EG. currency list) and revert back for other lists.

    Code changes :
    Introduce a prop shouldUseInitialScrollIndex and use it only for IOUCurrencySelection only (for now) until we realize to while other selectors Menus we want to use this.

      const scrollToFocusedIndexOnFirstRender = useCallback(() => {
            if (!firstLayoutRef.current) {
                return;
            }
            scrollToIndex(focusedIndex, false);
            firstLayoutRef.current = false;
        }, [focusedIndex, scrollToIndex]);
        
    <SectionList
      // other props
      onLayout={shouldUseInitialScrollIndex ? handleFirstLayout : scrollToFocusedIndexOnFirstRender}
      // eslint-disable-next-line react/jsx-props-no-spreading
      {...(shouldUseInitialScrollIndex && {initialScrollIndex: initialFocusedIndex})}
     />

    OR revert #30972 completely

  8. situchan commented on Nov 12, 2023

    @situchan
    Contributor

    Removing this line fixes this issue: (Not a real solution but just for testing purpose)

    getItemLayout={getItemLayout}

    So I can confirm that the root cause is related to combination of getItemLayout and initialScrollIndex.
    When initialScrollIndex is set, previous items (index 0 - initialScrollIndex-2) are not rendered and thus getItemLayout callback is not called.
    That's why this isn't noticeable when number of items are less than 3 (i.e. Language or Priority mode pages).

  9. 25 remaining items

  10. melvin-bot commented on Nov 14, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.98-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-11-21. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR
  11. melvin-bot commented on Nov 14, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@cead22] The PR that introduced the bug has been identified. Link to the PR:
    • [@cead22] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@cead22] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@cead22] Determine if we should create a regression test for this bug.
    • [@cead22] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  12. sophiepintoraetz commented on Nov 15, 2023

    @sophiepintoraetz
    Contributor

    All right, nothing further to do here, given it was a regression. Closing.

  13. changed the title [-][HOLD for payment 2023-11-21] Nontification preferences - Mute option not seen in notification prefrences when immediately is selected[/-] [+][HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] Nontification preferences - Mute option not seen in notification prefrences when immediately is selected[/+] on Nov 15, 2023
  14. melvin-bot commented on Nov 15, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-11-22. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR
  15. melvin-bot commented on Nov 15, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@cead22] The PR that introduced the bug has been identified. Link to the PR:
    • [@cead22] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@cead22] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@cead22] Determine if we should create a regression test for this bug.
    • [@cead22] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions