You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] Nontification preferences - Mute option not seen in notification prefrences when immediately is selected #31192
Version Number: 1.3.98-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Open the app
Navigate to any room or chat
Tap the header Settings > Notification prefrences
Expected Result:
All the menu options "Mute", "Daily" and "Immediately" are visible
Actual Result:
The "Mute" option is not visible when "Immediately" is selected
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Mute option not seen in notification prefrences when immediately is selected
Root cause
Here root cause behaviour of SectionList when we set initialScrollIndex to ">=" 2, Sectionlist just start at initialScrollIndex skip the rendering items before it (according to layout) and only render on scroll, in case of notification pref. page the items are limited no scroll event can be triggered so sectionlist wont render skipped items
(above root cause can be verified if we set a max width to notification page screen Wrapper and apply overscroll auto manually)
Screen.Recording.2023-11-11.at.3.19.08.AM.mov
Solution
we should apply the fix from #30972 selctively for cases when list is long and scrollable (EG. currency list) and revert back for other lists.
Code changes :
Introduce a prop shouldUseInitialScrollIndex and use it only for IOUCurrencySelection only (for now) until we realize to while other selectors Menus we want to use this.
constscrollToFocusedIndexOnFirstRender=useCallback(()=>{if(!firstLayoutRef.current){return;}scrollToIndex(focusedIndex,false);firstLayoutRef.current=false;},[focusedIndex,scrollToIndex]);<SectionList// other propsonLayout={shouldUseInitialScrollIndex ? handleFirstLayout : scrollToFocusedIndexOnFirstRender}// eslint-disable-next-line react/jsx-props-no-spreading{...(shouldUseInitialScrollIndex&&{initialScrollIndex: initialFocusedIndex})}/>
So I can confirm that the root cause is related to combination of getItemLayout and initialScrollIndex.
When initialScrollIndex is set, previous items (index 0 - initialScrollIndex-2) are not rendered and thus getItemLayout callback is not called.
That's why this isn't noticeable when number of items are less than 3 (i.e. Language or Priority mode pages).
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.98-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-21. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@cead22] The PR that introduced the bug has been identified. Link to the PR:
[@cead22] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@cead22] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@cead22] Determine if we should create a regression test for this bug.
[@cead22] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2023-11-21] Nontification preferences - Mute option not seen in notification prefrences when immediately is selected[/-][+][HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] Nontification preferences - Mute option not seen in notification prefrences when immediately is selected[/+]on Nov 15, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-22. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@cead22] The PR that introduced the bug has been identified. Link to the PR:
[@cead22] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@cead22] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@cead22] Determine if we should create a regression test for this bug.
[@cead22] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Nov 10, 2023
Triggered auto assignment to @sophiepintoraetz (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Nov 10, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Nov 10, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Nov 10, 2023
Triggered auto assignment to @cead22 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.esh-g commentedon Nov 10, 2023
Regression from #30972
ishpaul777 commentedon Nov 10, 2023
Proposal
Problem
Mute option not seen in notification prefrences when immediately is selected
Root cause
Here root cause behaviour of
SectionListwhen we setinitialScrollIndexto ">=" 2, Sectionlist just start at initialScrollIndex skip the rendering items before it (according to layout) and only render on scroll, in case of notification pref. page the items are limited no scroll event can be triggered so sectionlist wont render skipped items(above root cause can be verified if we set a max width to notification page screen Wrapper and apply overscroll auto manually)
Screen.Recording.2023-11-11.at.3.19.08.AM.mov
Solution
we should apply the fix from #30972 selctively for cases when list is long and scrollable (EG. currency list) and revert back for other lists.
Code changes :
Introduce a prop
shouldUseInitialScrollIndexand use it only forIOUCurrencySelectiononly (for now) until we realize to while other selectors Menus we want to use this.OR revert #30972 completely
situchan commentedon Nov 12, 2023
Removing this line fixes this issue: (Not a real solution but just for testing purpose)
App/src/components/SelectionList/BaseSelectionList.js
Line 441 in ffe1c63
So I can confirm that the root cause is related to combination of
getItemLayoutandinitialScrollIndex.When
initialScrollIndexis set, previous items (index 0 - initialScrollIndex-2) are not rendered and thusgetItemLayoutcallback is not called.That's why this isn't noticeable when number of items are less than 3 (i.e. Language or Priority mode pages).
25 remaining items
melvin-bot commentedon Nov 14, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.98-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-21. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
melvin-bot commentedon Nov 14, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
sophiepintoraetz commentedon Nov 15, 2023
All right, nothing further to do here, given it was a regression. Closing.
[-][HOLD for payment 2023-11-21] Nontification preferences - Mute option not seen in notification prefrences when immediately is selected[/-][+][HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] Nontification preferences - Mute option not seen in notification prefrences when immediately is selected[/+]melvin-bot commentedon Nov 15, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-22. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
melvin-bot commentedon Nov 15, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: