Skip to content

[$500] Workspace - Bank account setup page appears briefly when opening BA when BA is already set up #31207

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.3.98-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Go to Settings > Workspaces > any workspace.
  3. Click Bank account.
  4. Click Connect online with Plaid.
  5. Continue bank account setup with Plaid until it is successful.
  6. Return to workspace settings.
  7. Click Bank account again.

Expected Result:

User is redirected to disconnect bank account screen.

Actual Result:

Bank account setup page shows up briefly.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6271728_1699646112669.20231111_025419.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e6c09018ece00b54
  • Upwork Job ID: 1723072485931921408
  • Last Price Increase: 2023-11-10

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 10, 2023
  2. changed the title [-]Workspace - Bank account setup page appears briefly when opening BA when BA is already set up[/-] [+][$500] Workspace - Bank account setup page appears briefly when opening BA when BA is already set up[/+] on Nov 10, 2023
  3. melvin-bot commented on Nov 10, 2023

    @melvin-bot
  4. melvin-bot commented on Nov 10, 2023

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. melvin-bot commented on Nov 10, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 10, 2023
  7. melvin-bot commented on Nov 10, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

  8. 30 remaining items

  9. aldo-expensify commented on Nov 28, 2023

    @aldo-expensify
    Contributor

    I tried to find it, but the file's history is a bit messy because of a few reverts that have happen in the last couple of months.

  10. melvin-bot commented on Dec 1, 2023

    @melvin-bot

    @tylerkaraszewski @rushatgabhane @jliexpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

  11. melvin-bot commented on Dec 1, 2023

    @melvin-bot

    @tylerkaraszewski, @rushatgabhane, @jliexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  12. jliexpensify commented on Dec 3, 2023

    @jliexpensify
    Contributor

    @aldo-expensify would you recommend posting in #bug-zero and asking who worked on the PR and linking this job?

  13. aldo-expensify commented on Dec 4, 2023

    @aldo-expensify
    Contributor

    Wouldn't hurt to ask, I haven't have the time to look at it again.

  14. jliexpensify commented on Dec 4, 2023

    @jliexpensify
    Contributor
  15. ntdiary commented on Dec 5, 2023

    @ntdiary
    Contributor

    I feel this issue is caused by PR #29166. We had a similar issue #31212, which also bypassed the hasACHDataBeenLoaded condition. And we've fixed the related condition in the new PR #31439 (already merged), so I guess this issue will be resolved as well, can you please test it again?

    cc @jliexpensify @aldo-expensify @izarutskaya

  16. jliexpensify commented on Dec 5, 2023

    @jliexpensify
    Contributor

    Ooh nice, thanks so much @ntdiary - @izarutskaya do you mind confirming this is fixed?

  17. mvtglobally commented on Dec 8, 2023

    @mvtglobally

    Issue not reproducible during KI retests. (Second week)

  18. jliexpensify commented on Dec 8, 2023

    @jliexpensify
    Contributor

    Great, lets close this off!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringHelp WantedApply this label when an issue is open to proposals by contributorsInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions