You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-11-30] [$500] Web - Chat - 'Uh-oh, something went wrong!' is displayed after clicking Chat bubble #31208
Version Number: 1.3.98-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Logout out of NewDot
Login to OD Expensify
Click the message bubble in the bottom right
Verify a new tab opens and you are brought to the NewDot concierge chat
Expected Result:
NewDot concierge chat is displayed without error
Actual Result:
A new tab opens and user is brought to the NewDot Expensify, but 'Uh-oh, something went wrong!' page is displayed
Uh-oh, something went wrong!
If the problem persists, reach out to concierge@expensify.com
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Web - Chat - 'Uh-oh, something went wrong!' is displayed after clicking Chat bubble[/-][+][$500] Web - Chat - 'Uh-oh, something went wrong!' is displayed after clicking Chat bubble[/+]on Nov 10, 2023
It seems like while calling the function some null/undefined value is being passed down for sortedReportActions param,
What changes do you think we should make in order to solve the problem?
We can paste a check inside getFirstVisibleReportActionIDfunction to verify if the value passed for sortedReportActions is a valid array and only then execute the logic.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
📣 @Juggernaut-98! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-30. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@allroundexperts] Determine if we should create a regression test for this bug.
[@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
[-]Web - Chat - 'Uh-oh, something went wrong!' is displayed after clicking Chat bubble[/-][+][$500] Web - Chat - 'Uh-oh, something went wrong!' is displayed after clicking Chat bubble[/+]melvin-bot commentedon Nov 10, 2023
Job added to Upwork: https://www.upwork.com/jobs/~017b417e0df7589f4a
melvin-bot commentedon Nov 10, 2023
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Nov 10, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Nov 10, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (
External)zukilover commentedon Nov 10, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Something went wrong when transitioning from OldDot to NewDot
What is the root cause of that problem?
App is trying to execute a filter operation on array that does not exist:
App/src/libs/ReportActionsUtils.ts
Lines 463 to 465 in 4f345f8
This results in:
ReportActionsUtils.ts:458 Uncaught TypeError: sortedReportActions.filter is not a functionerror.What changes do you think we should make in order to solve the problem?
Add default value for the
sortedReportActionsargument:What alternative solutions did you explore? (Optional)
N/A
Juggernaut-98 commentedon Nov 12, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - Chat - 'Uh-oh, something went wrong!' is displayed after clicking Chat bubble
What is the root cause of that problem?
By looking at console error it is evident that problem is in following function
It seems like while calling the function some null/undefined value is being passed down for sortedReportActions param,
What changes do you think we should make in order to solve the problem?
We can paste a check inside
getFirstVisibleReportActionIDfunction to verify if the value passed forsortedReportActionsis a valid array and only then execute the logic.What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Nov 12, 2023
📣 @Juggernaut-98! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
20 remaining items
melvin-bot commentedon Nov 23, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 23, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-30. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 23, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
MitchExpensify commentedon Nov 23, 2023
Payment summary:
allroundexperts commentedon Nov 26, 2023
Checklist
deetergp commentedon Dec 4, 2023
Thank you for the update @allroundexperts 👍 @lanitochka17 Can we add your reproduction steps to the regression tests?
MitchExpensify commentedon Dec 4, 2023
Upwork offer sent for payment, @zukilover. Lemme know when you accept 👍
Added QA test update request here https://github.com/Expensify/Expensify/issues/343043
zukilover commentedon Dec 4, 2023
@MitchExpensify accepted, thank you.
MitchExpensify commentedon Dec 6, 2023
Paid and contract ended!
JmillsExpensify commentedon Dec 13, 2023
$500 payment approved for @allroundexperts based on this comment.