You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] [$500] IOU-In employee WS, in manual request, description entered is not saved in description page #31230
Version Number: 1.3.98-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation: @
Action Performed:
Launch app
Tap on Employee WS
Tap plus icon near compose
Tap request money
Enter an amount
Tap next
Enter description and tap save
Tap request
Tap manual request created
Tap on Description
Expected Result:
In employee WS, in manual request, description entered must be saved in description page.
Actual Result:
In employee WS, in manual request, description entered is not saved in description page.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]IOU-In employee WS, in manual request, description entered is not saved in description page[/-][+][$500] IOU-In employee WS, in manual request, description entered is not saved in description page[/+]on Nov 11, 2023
This is another regression from #28866, changes in EditRequestPage.
We render the edit description form twice, the first time with transaction === {}, therefore propsToParse.defaultValue === "". On the second render, when the transaction is loaded, the form value does not update, because the inputValues[inputID] is not undefined anymore here, but filled with an empty string:
changed the title [-][$500] IOU-In employee WS, in manual request, description entered is not saved in description page[/-][+][HOLD for payment 2023-11-21] [$500] IOU-In employee WS, in manual request, description entered is not saved in description page[/+]on Nov 14, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.98-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-21. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
[@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@narefyev91] Determine if we should create a regression test for this bug.
[@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2023-11-21] [$500] IOU-In employee WS, in manual request, description entered is not saved in description page[/-][+][HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] [$500] IOU-In employee WS, in manual request, description entered is not saved in description page[/+]on Nov 15, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-22. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
[@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@narefyev91] Determine if we should create a regression test for this bug.
[@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Nov 11, 2023
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.[-]IOU-In employee WS, in manual request, description entered is not saved in description page[/-][+][$500] IOU-In employee WS, in manual request, description entered is not saved in description page[/+]melvin-bot commentedon Nov 11, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01f13c7e52024929d1
melvin-bot commentedon Nov 11, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Nov 11, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (
External)paultsimura commentedon Nov 11, 2023
This is another regression from #28866, changes in
EditRequestPage.We render the edit description form twice, the first time with
transaction === {}, thereforepropsToParse.defaultValue === "". On the second render, when the transaction is loaded, the form value does not update, because theinputValues[inputID]is not undefined anymore here, but filled with an empty string:App/src/components/Form/FormProvider.js
Lines 214 to 217 in 7f44418
11 remaining items
[-][$500] IOU-In employee WS, in manual request, description entered is not saved in description page[/-][+][HOLD for payment 2023-11-21] [$500] IOU-In employee WS, in manual request, description entered is not saved in description page[/+]melvin-bot commentedon Nov 14, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 14, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.98-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-21. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 14, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2023-11-21] [$500] IOU-In employee WS, in manual request, description entered is not saved in description page[/-][+][HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] [$500] IOU-In employee WS, in manual request, description entered is not saved in description page[/+]melvin-bot commentedon Nov 15, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-22. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 15, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
zanyrenney commentedon Nov 22, 2023
Payment summary:
@narefyev91 does not require payment (Contractor)
Closing!