You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Wallet - Error appears when system attempts to verify Onfido information #31237
Version Number: 1.3.98.0 Reproducible in staging?: y Reproducible in production?: can not test on production If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The issue was not posted on Upwork, but I still tried replicating this. I did my ID verification on my iOS web browser while the staging app was running on my machine. There was no way for the error to be shown on Onfido page in my mobile as it says me to check the status on the desktop app. I initially was seeing the walletActivationPending text and after verification failed I saw walletActivationFailed.
If the message was shown while the verification was happening in the background, then the issue could be in this logic here . We need to modify the condition if(!isPendingOnfidoResult && hasFailedOnfido) so we don't see the error message while verification is happening.
📣 @anuraagdjain! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
That error is expected if the Onfido verification failed. Once we have the email that was used for testing, we can confirm whether the Onfido check failed (and why)
I'm going to remove the deploy blocker from this, since I tested on staging and couldn't reproduce it might be something specific to the applause testing account but we don't need to block on it I don't think.
For applausetester+vd_1110@applause.expensifail.com, I don't think the KYC process was ever started. Looking at the additionalData, there is no currentStep at all, it should've been set to OnfidoStep if this user passed the AdditionalDetailsStep and started the Onfido verification. Additionally, from Slack, the Enable wallet button is visible and upon clicking it, the user is taken to add their personal bank account indicating that the KYC process was never started. We do not allow a user to start wallet KYC unless they have a PBA setup.
For applausetester+vd_ios1110@applause.expensifail.com, looking at the Onfido check from the additionalData, this account failed Onfido:
In this case, this account will not be able to continue with the wallet KYC process. This is expected behavior for now, we have some ideas of allowing a user to retry Onfido at least once but that is not in place just yet.
So I think we're good to close this one out. Thoughts, @bondydaa?
Activity
OSBotify commentedon Nov 11, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Nov 11, 2023
Triggered auto assignment to @bondydaa (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.anuraagdjain commentedon Nov 12, 2023
The issue was not posted on Upwork, but I still tried replicating this. I did my ID verification on my iOS web browser while the staging app was running on my machine. There was no way for the error to be shown on Onfido page in my mobile as it says me to check the status on the desktop app. I initially was seeing the
walletActivationPendingtext and after verification failed I sawwalletActivationFailed.If the message was shown while the verification was happening in the background, then the issue could be in this logic here . We need to modify the condition
if(!isPendingOnfidoResult && hasFailedOnfido)so we don't see the error message while verification is happening.melvin-bot commentedon Nov 12, 2023
📣 @anuraagdjain! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
bondydaa commentedon Nov 13, 2023
@kbecciv looks like we had some big incident this weekend around the time you created this, can you test again now and see if you still have issues?
kbecciv commentedon Nov 13, 2023
@bondydaa The issue is still being reproduced

bondydaa commentedon Nov 13, 2023
@marcaaron @nkuoch @MariaHCD since ya'll were involved with https://github.com/Expensify/Web-Expensify/pull/39342, any ideas here?
@kbecciv what email/login is this from so we can look up logs?
MariaHCD commentedon Nov 14, 2023
That error is expected if the Onfido verification failed. Once we have the email that was used for testing, we can confirm whether the Onfido check failed (and why)
kbecciv commentedon Nov 14, 2023
@bondydaa Email provided - https://expensify.slack.com/archives/C9YU7BX5M/p1699979315601279?thread_ts=1699977627.556279&cid=C9YU7BX5M
bondydaa commentedon Nov 14, 2023
ran the query that looks up the wallet for a user.
I can't see the original images/video on the OP

but from the looks of it there is an error while trying to do the validation checks?
bondydaa commentedon Nov 14, 2023
i'm not seeing any logs for onfido and that bank accountid
bondydaa commentedon Nov 14, 2023
I tested this myself on a test account and it seemed to work.
Looking for requests for


applausetester+vd_1110@applause.expensifail.comthat I see in my network tab I'm not seeing anything of theselooks like there are some for

applausetester+vd_ios1110@applause.expensifail.comandapplausetester+vd_1109@applause.expensifail.comwhich have these logs:
which mostly looks like it worked and looking up that bankaccountid it does have the correct info
Seems like something broke before we could call onfido for
applausetester+vd_1110@applause.expensifail.comi do see requests here for

OpenPlaidBankAccountSelectorbondydaa commentedon Nov 14, 2023
oh but those are all from the 10th.
bondydaa commentedon Nov 14, 2023
went back to the thread to confirm a question i had
bondydaa commentedon Nov 14, 2023
I'm going to remove the deploy blocker from this, since I tested on staging and couldn't reproduce it might be something specific to the applause testing account but we don't need to block on it I don't think.
MariaHCD commentedon Nov 15, 2023
For
applausetester+vd_1110@applause.expensifail.com, I don't think the KYC process was ever started. Looking at the additionalData, there is no currentStep at all, it should've been set toOnfidoStepif this user passed theAdditionalDetailsStepand started the Onfido verification. Additionally, from Slack, theEnable walletbutton is visible and upon clicking it, the user is taken to add their personal bank account indicating that the KYC process was never started. We do not allow a user to start wallet KYC unless they have a PBA setup.For
applausetester+vd_ios1110@applause.expensifail.com, looking at the Onfido check from the additionalData, this account failed Onfido:In this case, this account will not be able to continue with the wallet KYC process. This is expected behavior for now, we have some ideas of allowing a user to retry Onfido at least once but that is not in place just yet.
So I think we're good to close this one out. Thoughts, @bondydaa?
bondydaa commentedon Nov 15, 2023
👍 yep agreed