[Pay meow][$1000] Legal name - When tapping on the Legal Last Name field, the error message alternates between 'This field is required' and 'Name can only include Latin characters

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Log in with any account
Go to Setting - Profile - Personal details - Legal name
Try invisible characters from this site https://invisible-characters.com/3164-HANGUL-FILLER.html
Put it on both field
Click Save
Put cursor on legal first name than on Legal Last name

Expected Result:

When tapping on the Legal Last Name field, the error message shouldn't switch between 'This field is required' and 'Name can only include Latin characters

Actual Result:

When tapping on the Legal Last Name field, the error message alternates between 'This field is required' and 'Name can only include Latin characters

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Recording.5424.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01df7fd3e27a4b1629
Upwork Job ID: 1724836966037389312
Last Price Increase: 2023-11-29
Automatic offers:

shubham1206agra | Contributor | 27985228
bernhardoj | Contributor | 28072802

Job added to Upwork: https://www.upwork.com/jobs/~01df7fd3e27a4b1629

@Christinadobrzyn

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mananjadhav

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Switching between error messages when the message is empty in the legal name page

What is the root cause of that problem?

Chained if conditions causing this error message switch, instead we can have if-else if-else blocks only.

What changes do you think we should make in order to solve the problem?

App/src/pages/settings/Profile/PersonalDetails/LegalNamePage.js

Lines 57 to 74 in 4618b39

    
           if (!ValidationUtils.isValidLegalName(values.legalFirstName)) { 
        
               ErrorUtils.addErrorMessage(errors, 'legalFirstName', 'privatePersonalDetails.error.hasInvalidCharacter'); 
        
           } else if (_.isEmpty(values.legalFirstName)) { 
        
               errors.legalFirstName = 'common.error.fieldRequired'; 
        
           } 
        
           if (values.legalFirstName.length > CONST.LEGAL_NAME.MAX_LENGTH) { 
        
               ErrorUtils.addErrorMessage(errors, 'legalFirstName', ['common.error.characterLimitExceedCounter', {length: values.legalFirstName.length, limit: CONST.LEGAL_NAME.MAX_LENGTH}]); 
        
           } 
        
           if (!ValidationUtils.isValidLegalName(values.legalLastName)) { 
        
               ErrorUtils.addErrorMessage(errors, 'legalLastName', 'privatePersonalDetails.error.hasInvalidCharacter'); 
        
           } else if (_.isEmpty(values.legalLastName)) { 
        
               errors.legalLastName = 'common.error.fieldRequired'; 
        
           } 
        
           if (values.legalLastName.length > CONST.LEGAL_NAME.MAX_LENGTH) { 
        
               ErrorUtils.addErrorMessage(errors, 'legalLastName', ['common.error.characterLimitExceedCounter', {length: values.legalLastName.length, limit: CONST.LEGAL_NAME.MAX_LENGTH}]); 
        
           }

Change the above if conditions as the below code block to

       if (_.isEmpty(values.legalFirstName)) {
            errors.legalFirstName = 'common.error.fieldRequired';
        }
       else if (!ValidationUtils.isValidLegalName(values.legalFirstName)) {
            ErrorUtils.addErrorMessage(errors, 'legalFirstName', 'privatePersonalDetails.error.hasInvalidCharacter');
        } 
        else if (values.legalFirstName.length > CONST.LEGAL_NAME.MAX_LENGTH) {
            ErrorUtils.addErrorMessage(errors, 'legalFirstName', ['common.error.characterLimitExceedCounter', {length: values.legalFirstName.length, limit: CONST.LEGAL_NAME.MAX_LENGTH}]);
        }
        else if (!ValidationUtils.isValidLegalName(values.legalLastName)) {
            ErrorUtils.addErrorMessage(errors, 'legalLastName', 'privatePersonalDetails.error.hasInvalidCharacter');
        } else if (_.isEmpty(values.legalLastName)) {
            errors.legalLastName = 'common.error.fieldRequired';
        }
        else if (values.legalLastName.length > CONST.LEGAL_NAME.MAX_LENGTH) {
            ErrorUtils.addErrorMessage(errors, 'legalLastName', ['common.error.characterLimitExceedCounter', {length: values.legalLastName.length, limit: CONST.LEGAL_NAME.MAX_LENGTH}]);
        }

What alternative solutions did you explore? (Optional)

NA

Proposal

Please re-state the problem that we are trying to solve in this issue.

Switching between error messages when the message is empty in the legal name page

What is the root cause of that problem?

We already trim value in

App/src/components/Form/FormProvider.js

Line 112 in 37ddb03

const trimmedStringValues = ValidationUtils.prepareValues(values);

but this line we did not use trimmedStringValues

Beside, when submit we call onValidate with trimmedValue

App/src/components/Form/FormProvider.js

Line 190 in 37ddb03

if (!_.isEmpty(onValidate(trimmedStringValues))) {

But when blur we just use inputeValues

App/src/components/Form/FormProvider.js

Line 272 in 37ddb03

onValidate(inputValues, !hasServerError);

What changes do you think we should make in order to solve the problem?

Use trimmedStringValues in here like we did in onSubmit

Result

@Christinadobrzyn

When tapping on the Legal Last Name field, the error message shouldn't switch between 'This field is required' and 'Name can only include Latin characters

@Christinadobrzyn I think before I choose any proposal we should clarify, which error should be shown exactly? The expected result doesn't mention this.

@Christinadobrzyn

@Christinadobrzyn this issue didn't auto update, nor remove the Reviewing label. I updated, can you issue payment plz? PR hit production a few weeks ago.

@bernhardoj

sorry for the delay, paying out now

Payouts due:

Contributor: $1000 @bernhardoj (paid in Upwork here - https://www.upwork.com/jobs/~01df7fd3e27a4b1629)
Contributor+: $1000 @shubham1206agra (paid in Upwork here - https://www.upwork.com/jobs/~01d23451bb0027d3fd)

Eligible for 50% #urgency bonus? N

The original Upwork job is closed - @shubham1206agra can you accept my offer in this Upwork job post

Accepted

@bernhardoj

Paid out @bernhardoj and @shubham1206agra based on this payment summary - #31391 (comment)

@bernhardoj do we need a regression test for this?

@Christinadobrzyn

@Christinadobrzyn I think it's easy to be broken, so adding a test would be good

cc: @shubham1206agra

@Christinadobrzyn

@Christinadobrzyn Test case

Go to Setting - Profile - Personal details - Legal name
Press Save without any blank First Name.
Enter < 😶‍🌫️>, and observe the error
Remove the space(<😶‍🌫️>), and again observe the error.
Enter spaces one by one after < and observe the error.

Created a regression test GH - https://github.com/Expensify/Expensify/issues/366323

Closing this as complete. Feel free to let me know if anything is needed.

Navigation Menu

Repository navigation

[Pay meow][$1000] Legal name - When tapping on the Legal Last Name field, the error message alternates between 'This field is required' and 'Name can only include Latin characters #31391

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

143 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (!ValidationUtils.isValidLegalName(values.legalFirstName)) {
	ErrorUtils.addErrorMessage(errors, 'legalFirstName', 'privatePersonalDetails.error.hasInvalidCharacter');
	} else if (_.isEmpty(values.legalFirstName)) {
	errors.legalFirstName = 'common.error.fieldRequired';
	}
	if (values.legalFirstName.length > CONST.LEGAL_NAME.MAX_LENGTH) {
	ErrorUtils.addErrorMessage(errors, 'legalFirstName', ['common.error.characterLimitExceedCounter', {length: values.legalFirstName.length, limit: CONST.LEGAL_NAME.MAX_LENGTH}]);
	}

	if (!ValidationUtils.isValidLegalName(values.legalLastName)) {
	ErrorUtils.addErrorMessage(errors, 'legalLastName', 'privatePersonalDetails.error.hasInvalidCharacter');
	} else if (_.isEmpty(values.legalLastName)) {
	errors.legalLastName = 'common.error.fieldRequired';
	}
	if (values.legalLastName.length > CONST.LEGAL_NAME.MAX_LENGTH) {
	ErrorUtils.addErrorMessage(errors, 'legalLastName', ['common.error.characterLimitExceedCounter', {length: values.legalLastName.length, limit: CONST.LEGAL_NAME.MAX_LENGTH}]);
	}

[Pay meow][$1000] Legal name - When tapping on the Legal Last Name field, the error message alternates between 'This field is required' and 'Name can only include Latin characters #31391

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 15, 2023

melvin-bot commented on Nov 15, 2023

melvin-bot commented on Nov 15, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Nov 15, 2023

5war00p commented on Nov 15, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

tienifr commented on Nov 15, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

mananjadhav commented on Nov 16, 2023

143 remaining items

mallenexpensify commented on Jan 31, 2024

Christinadobrzyn commented on Jan 31, 2024

shubham1206agra commented on Feb 1, 2024

Christinadobrzyn commented on Feb 1, 2024

bernhardoj commented on Feb 2, 2024

shubham1206agra commented on Feb 2, 2024

Christinadobrzyn commented on Feb 2, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions