[HOLD for payment 2023-11-30] [$500] Public room - Extra bottom padding on the header in the sign-in modal accessed from public room

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Log out if logged in.
Navigate to a public room https://staging.new.expensify.com/r/2376199970894587
on iOS or Android app.
Tap Sign in.
Scroll down the sign-in page.

Expected Result:

The padding on the header should be adequate.

Actual Result:

The bottom padding on the header is excessive.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6279149_1700143096738.RPReplay_Final1700135355__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cd50fd577deda12f
Upwork Job ID: 1725154866229444608
Last Price Increase: 2023-11-16
Automatic offers:

shubham1206agra | Reviewer | 27719696
ZhenjaHorbach | Contributor | 27719698

Job added to Upwork: https://www.upwork.com/jobs/~01cd50fd577deda12f

@alexpensify

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@shubham1206agra

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Public room - Extra bottom padding on the header in the sign-in modal accessed from public room

What is the root cause of that problem?

the main problem is that by default we always have a padding at the top
Which is not needed if at the top of the screen we have an additional element (in this case, a header with a back button)

App/src/pages/signin/SignInModal.js

Lines 22 to 30 in d220f6c

    
           <ScreenWrapper 
        
               style={[styles.highlightBG]} 
        
               includeSafeAreaPaddingBottom={false} 
        
               shouldEnableMaxHeight 
        
               testID={SignInModal.displayName} 
        
           > 
        
               <HeaderWithBackButton onBackButtonPress={Navigation.dismissModal} /> 
        
               <SignInPage isInModal /> 
        
           </ScreenWrapper>

What changes do you think we should make in order to solve the problem?

We can update these styles and add new conditions when we pass isModal(SignInPage with header is the only place where we use isModal) with true and then set paddintTop by 0

    <View style={[styles.signInPage, StyleUtils.getSafeAreaPadding({...safeAreaInsets, bottom: 0, top: isInModal ? 0 : safeAreaInsets.top}, 1)]}>

App/src/pages/signin/SignInPage.js

Line 237 in 6ea4539

    
           <View style={[styles.signInPage, StyleUtils.getSafeAreaPadding({...safeAreaInsets, bottom: 0}, 1)]}>

What alternative solutions did you explore? (Optional)

Or we can add a new property to SignInPage that will tell us if there is an additional element on top instead of the isModal in the original proposition

Or we can set the top value by 0 for StyleUtils.getSafeAreaPadding

App/src/pages/signin/SignInPage.js

Line 237 in 6ea4539

    
           <View style={[styles.signInPage, StyleUtils.getSafeAreaPadding({...safeAreaInsets, bottom: 0}, 1)]}>

and create a wrapper component instead which will have this paddingTop
And depending on the situation we will use SignInPage with a wrapper or not

Or we can add the ability to pass styles and pass paddingTop: 0 here

App/src/pages/signin/SignInModal.js

Line 29 in d220f6c

Or we can make the header with the back button part of the SignInPage
And add a new parameter
If the parameter is true, we show the header and disable paddingTop
If the parameter is false, we hide the header and add paddingTop

@shubham1206agra

@shubham1206agra - can you review this proposal and identify if it will fix the issue? Thanks!

@alexpensify

@alexpensify I have stumbled upon this problem in testing https://expensify.slack.com/archives/C02NK2DQWUX/p1700195328526319

The above proposal seems fine. I will update here once I get this through.

How can i get access to the slack channel

Reviewing label has been removed, please complete the "BugZero Checklist".

@shubham1206agra

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Extra bottom padding on the header in the sign-in modal #31517

If no regressions arise, payment will be issued on 2023-11-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@shubham1206agra requires payment offer (Reviewer)
@ZhenjaHorbach requires payment offer (Contributor)

@shubham1206agra

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
[@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@shubham1206agra] Determine if we should create a regression test for this bug.
[@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@francoisl

One thing I noticed in #15778

// There is an issue SafeAreaView on Android where wrong insets flicker on app start.
// Can be removed once https://github.com/th3rdwave/react-native-safe-area-context/issues/364 is resolved.

This comment got missing somehow. Should we add this back?
cc @francoisl

@shubham1206agra

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: Signin rhp #24083
[@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Signin rhp #24083 (comment)
[@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@shubham1206agra] Determine if we should create a regression test for this bug. Not needed as this was edge case
[@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

@ZhenjaHorbach

Here is the payment summary:

External issue reporter N/A
Contributor that fixed the issue @ZhenjaHorbach $500
Contributor+ that helped on the issue and/or PR @shubham1206agra $500

Upwork Job: https://www.upwork.com/jobs/~01cd50fd577deda12f

*If applicable, the bonuses will be applied on the final payment

Extra Notes regarding payment: No bonus

Done - everyone has been paid in Upwork!

Navigation Menu

Repository navigation

[HOLD for payment 2023-11-30] [$500] Public room - Extra bottom padding on the header in the sign-in modal accessed from public room #31445

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

13 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<ScreenWrapper
	style={[styles.highlightBG]}
	includeSafeAreaPaddingBottom={false}
	shouldEnableMaxHeight
	testID={SignInModal.displayName}
	>
	<HeaderWithBackButton onBackButtonPress={Navigation.dismissModal} />
	<SignInPage isInModal />
	</ScreenWrapper>

[HOLD for payment 2023-11-30] [$500] Public room - Extra bottom padding on the header in the sign-in modal accessed from public room #31445

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 16, 2023

melvin-bot commented on Nov 16, 2023

melvin-bot commented on Nov 16, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Nov 16, 2023

ZhenjaHorbach commented on Nov 16, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

alexpensify commented on Nov 16, 2023

shubham1206agra commented on Nov 17, 2023

shumakmanohar commented on Nov 17, 2023

13 remaining items

melvin-bot commented on Nov 23, 2023

melvin-bot commented on Nov 23, 2023

melvin-bot commented on Nov 23, 2023

shubham1206agra commented on Nov 24, 2023

shubham1206agra commented on Nov 24, 2023

alexpensify commented on Dec 1, 2023

alexpensify commented on Dec 1, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions