Skip to content

[$500] Web - Unable to move to the next input by using TAB button on keyboard #31488

New issue
New issue
Closed
Closed
[$500] Web - Unable to move to the next input by using TAB button on keyboard#31488
Assignees
s77rtisabelastisser
Labels
BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Description

@kbecciv
kbecciv
opened on Nov 17, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.0.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @allroundexperts
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1700217396857389

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with any account
  3. Go Setting - Profile - Personal details
  4. Open the Legal name page
  5. Use Tab key to move to the next input

Expected Result:

Able to move to the next input by using TAB button on keyboard

Actual Result:

Unable to move to the next input by using TAB button on keyboard

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2023-11-17.at.3.35.53.PM.mov
Recording.5453.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0196b1224492e0f053
  • Upwork Job ID: 1725503766144282624
  • Last Price Increase: 2023-11-24

Activity

  1. kbecciv
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 17, 2023
  2. melvin-bot
    changed the title [-]Web - Unable to move to the next input by using TAB button on keyboard[/-] [+][$500] Web - Unable to move to the next input by using TAB button on keyboard[/+] on Nov 17, 2023
  3. melvin-bot
    assigned
    isabelastisser
    on Nov 17, 2023

  4. melvin-bot commented on Nov 17, 2023

    @melvin-bot
    melvin-botBot
    on Nov 17, 2023 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~0196b1224492e0f053

  5. melvin-bot commented on Nov 17, 2023

    @melvin-bot
    melvin-botBot
    on Nov 17, 2023 – with Melvin Bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  6. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 17, 2023

  7. melvin-bot commented on Nov 17, 2023

    @melvin-bot
    melvin-botBot
    on Nov 17, 2023 – with Melvin Bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  8. melvin-bot
    assigned
    s77rt
    on Nov 17, 2023

  9. melvin-bot commented on Nov 17, 2023

    @melvin-bot
    melvin-botBot
    on Nov 17, 2023 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

  10. dukenv0307 commented on Nov 17, 2023

    @dukenv0307
    dukenv0307
    on Nov 17, 2023
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Unable to move to the next input by using TAB button on keyboard

    What is the root cause of that problem?

    In GenericPressable here, we're not letting the passed in tabIndex (if exists) override the tabIndex.

    So when we pass tabIndex={-1} to the pressable wrapping the Input in BaseTextInput to allow the tab navigation to go to the input, it doesn't work.

    What changes do you think we should make in order to solve the problem?

    In GenericPressable here, let the passed in tabIndex (if exists) override the tabIndex

    const tabIndex = props.tabIndex ?? (!accessible || !focusable ? -1 : 0);

    (Only added the props.tabIndex ??, so if the tabIndex exists, we'll use it)

    What alternative solutions did you explore? (Optional)

    NA

  11. dummy-1111 commented on Nov 17, 2023

    @dummy-1111
    dummy-1111
    on Nov 17, 2023
    Contributor

    Same root cause as #31203

  12. erquhart commented on Nov 17, 2023

    @erquhart
    erquhart
    on Nov 17, 2023
    Contributor

    Not just same root cause, this one is a dupe. Just worded differently.

  13. erquhart commented on Nov 17, 2023

    @erquhart
    erquhart
    on Nov 17, 2023
    Contributor

    Also this is a regression caused by #31118.

  14. 7 remaining items

  15. k-man-null commented on Nov 17, 2023

    @k-man-null
    k-man-null
    on Nov 17, 2023

    Contributor details
    Your Expensify account email: billkonchellah@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/billk8

  16. melvin-bot commented on Nov 17, 2023

    @melvin-bot
    melvin-botBot
    on Nov 17, 2023 – with Melvin Bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  17. melvin-bot
    added
    Overdue
    on Nov 20, 2023

  18. s77rt commented on Nov 20, 2023

    @s77rt
    s77rt
    on Nov 20, 2023
    Member

    @isabelastisser #31488 (comment)

  19. melvin-bot
    added
    Overdue
    and removed
    Overdue
    on Nov 20, 2023

  20. melvin-bot commented on Nov 24, 2023

    @melvin-bot
    melvin-botBot
    on Nov 24, 2023 – with Melvin Bot

    @s77rt, @isabelastisser Whoops! This issue is 2 days overdue. Let's get this updated quick!

  21. melvin-bot commented on Nov 24, 2023

    @melvin-bot
    melvin-botBot
    on Nov 24, 2023 – with Melvin Bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  22. s77rt commented on Nov 24, 2023

    @s77rt
    s77rt
    on Nov 24, 2023
    Member

    This is a dupe. Not looking for proposals here. @isabelastisser #31488 (comment)

  23. melvin-bot
    added
    Overdue
    and removed
    Overdue
    on Nov 24, 2023

  24. s77rt commented on Nov 27, 2023

    @s77rt
    s77rt
    on Nov 27, 2023
    Member

    @isabelastisser ^

  25. melvin-bot
    removed
    Overdue
    on Nov 27, 2023

  26. isabelastisser commented on Nov 27, 2023

    @isabelastisser
    isabelastisser
    on Nov 27, 2023
    Contributor

    @s77rt, sorry! I was ooo. Closing!

  27. isabelastisser
    closed this as completedon Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions