[HOLD for payment 2023-12-07] [ECARD] 🐛 HIGH: Zeros are stripped from ActivatePhysicalCard API params #31540

Activity

1. grgia

   added this to [#whatsnext] Wave 05 - Deprecate Freeon Nov 20, 2023
2. grgia

   converted this from a draft issue on Nov 20, 2023
3. grgia

   self-assigned this

   on Nov 20, 2023
4. grgia

   added

   DailyKSv2KSv2

   on Nov 20, 2023
5. pasyukevich commented on Nov 20, 2023

   

   pasyukevich

   on Nov 20, 2023

   Contributor

   More actions

   Hi,
   I'm Eugene from Callstack - an expert contributor group
   I’d like to work on this issue
6. grgia

   assigned

   pasyukevich

   on Nov 20, 2023
7. grgia

   added

   NewFeatureSomething to build that is a new item.Something to build that is a new item.

   on Nov 20, 2023
8. melvin-bot

   assigned

   bfitzexpensify

   on Nov 20, 2023
9. melvin-bot commented on Nov 20, 2023

   

   melvin-botBot

   on Nov 20, 2023 – with Melvin Bot

   More actions

   Triggered auto assignment to @bfitzexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.
10. melvin-bot

    added

    WeeklyKSv2KSv2

    and removed

    DailyKSv2KSv2

    on Nov 20, 2023
11. grgia

    added

    DailyKSv2KSv2

    ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributor

    and removed

    WeeklyKSv2KSv2

    on Nov 20, 2023
12. melvin-bot

    changed the title [-][Card Settings] 🐛 HIGH: Zeros are stripped from ActivatePhysicalCard API params[/-] [+][$500] [Card Settings] 🐛 HIGH: Zeros are stripped from ActivatePhysicalCard API params[/+] on Nov 20, 2023
13. 26 remaining items

    Load more

14. melvin-bot commented on Nov 30, 2023

    

    melvin-botBot

    on Nov 30, 2023 – with Melvin Bot

    More actions

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@parasharrajat] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
15. bfitzexpensify

    added

    DailyKSv2KSv2

    and removed

    WeeklyKSv2KSv2

    on Dec 3, 2023
16. bfitzexpensify commented on Dec 3, 2023

    

    bfitzexpensify

    on Dec 3, 2023

    Contributor

    More actions

    Moving to daily so I see this to action payment on 12/7
17. parasharrajat commented on Dec 3, 2023

    

    parasharrajat

    on Dec 3, 2023

    Member

    More actions

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: activate physical card #28313
    • [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/28313/files#r1413112498
    • [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
    • [@parasharrajat] Determine if we should create a regression test for this bug. No, It's an internal code bug.
    • [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    👍React with 👍1Reacted by Ben Fitzpatrick
18. melvin-bot

    added

    Overdue

    on Dec 6, 2023
19. grgia commented on Dec 6, 2023

    

    grgia

    on Dec 6, 2023

    ContributorAuthor

    More actions

    not overdue!
20. melvin-bot

    added

    DailyKSv2KSv2

    and removed

    Overdue

    DailyKSv2KSv2

    on Dec 6, 2023
21. bfitzexpensify commented on Dec 8, 2023

    

    bfitzexpensify

    on Dec 8, 2023

    Contributor

    More actions

    Payment summary:

    C+: @parasharrajat to be paid $500 via manual request

    BZ checklist done, so we're all finished here, thanks everyone
22. bfitzexpensify

    closed this as completedon Dec 8, 2023
23. github-project-automation

    moved this from HIGH to Done in [#whatsnext] Wave 05 - Deprecate Freeon Dec 8, 2023
24. parasharrajat commented on Apr 11, 2024

    

    parasharrajat

    on Apr 11, 2024

    Member

    More actions

    Payment requested as per #31540 (comment)
25. JmillsExpensify commented on Apr 11, 2024

    

    JmillsExpensify

    on Apr 11, 2024

    Contributor

    More actions

    $500 approved for @parasharrajat