Skip to content

[HOLD for payment 2023-11-30] [$500] Request money - Hmm it's not here page opens when click on Learn more via the banner below #31567

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.1-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any account
  3. Go to FAB -> Request -> Manually
  4. Enter any amount -> Next
  5. Click on get $250 -> Learn more

Expected Result:

The additional information page opens

Actual Result:

Hmm it's not here page opens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6284020_1700498537224.Recording__6807.mp4

Bug6284020_1700498537252!image__175_

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fc74f5c607d04925
  • Upwork Job ID: 1726668962396127232
  • Last Price Increase: 2023-11-20
  • Automatic offers:
    • ishpaul777 | Contributor | 27755628

Activity

  1. melvin-bot commented on Nov 20, 2023

    @melvin-bot

    Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. ishpaul777 commented on Nov 20, 2023

    @ishpaul777
    Contributor

    Probem

    Hmm it's not here page opens when click on Learn more via the banner below

    Root Cause

    we are using a wrong route for referral page https://help.expensify.com/articles/new-expensify/getting-started/Referral-Program instead of https://help.expensify.com/articles/new-expensify/billing-and-plan-types/Referral-Program

    Changes

    update CONST.LEARN_MORE_LINK to https://help.expensify.com/articles/new-expensify/billing-and-plan-types/Referral-Program

    Alternative

    Match the file location to the route getting-started/Referral-Program maybe not sure ?

  3. self-assigned this
    on Nov 20, 2023
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 20, 2023
  5. changed the title [-]Request money - Hmm it's not here page opens when click on Learn more via the banner below[/-] [+][$500] Request money - Hmm it's not here page opens when click on Learn more via the banner below[/+] on Nov 20, 2023
  6. melvin-bot commented on Nov 20, 2023

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 20, 2023
  8. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 20, 2023
  9. melvin-bot commented on Nov 20, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  10. 21 remaining items

  11. melvin-bot commented on Nov 23, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-11-30. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Nov 23, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
    • [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@mananjadhav] Determine if we should create a regression test for this bug.
    • [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. lschurr commented on Nov 26, 2023

    @lschurr
    Contributor

    @mananjadhav could you work on the checklist for this one if needed?

  14. lschurr commented on Nov 29, 2023

    @lschurr
    Contributor

    Payment summary:

    • Bug reporter: Applause (no payment)
    • Contributor: @ishpaul777 $500 (to be paid in Upwork)
    • Contributor+: This was reviewed by @luacmartins internally
  15. lschurr commented on Nov 29, 2023

    @lschurr
    Contributor

    Bump on the checklist @mananjadhav

  16. mananjadhav commented on Nov 29, 2023

    @mananjadhav
    Collaborator

    Contributor+: @mananjadhav $500 (to be paid in Newdot)

    @lschurr I wasn't able to review this PR. Do you want me to still work on the checklist for the payout?

  17. lschurr commented on Nov 29, 2023

    @lschurr
    Contributor

    Ah, thanks for clarifying @mananjadhav! Nope, if you didn't work on it, I'll update the payment summary.

  18. lschurr commented on Nov 29, 2023

    @lschurr
    Contributor

    @luacmartins - do we need a regression test for this one?

  19. mananjadhav commented on Nov 29, 2023

    @mananjadhav
    Collaborator

    Do you want me to still work on the checklist for the payout

    just clarifying, I meant the payout for the external contributor if it is stuck because of this.

  20. luacmartins commented on Nov 29, 2023

    @luacmartins
    Contributor

    @luacmartins - do we need a regression test for this one?

    I don't think we do. Applause caught this during regression test.

  21. lschurr commented on Nov 29, 2023

    @lschurr
    Contributor

    Cool, we're good! I'll pay @ishpaul777 tomorrow and we'll be set to close.

  22. lschurr commented on Nov 30, 2023

    @lschurr
    Contributor

    Paid! Closing this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions