You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-11-30] [$500] Request money - Hmm it's not here page opens when click on Learn more via the banner below #31567
Version Number: 1.4.1-5 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
changed the title [-]Request money - Hmm it's not here page opens when click on Learn more via the banner below[/-][+][$500] Request money - Hmm it's not here page opens when click on Learn more via the banner below[/+]on Nov 20, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-30. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@mananjadhavdoes not require payment (Eligible for Manual Requests)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
[@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mananjadhav] Determine if we should create a regression test for this bug.
[@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Nov 20, 2023
Triggered auto assignment to @hayata-suenaga (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.ishpaul777 commentedon Nov 20, 2023
Probem
Hmm it's not here page opens when click on Learn more via the banner below
Root Cause
we are using a wrong route for referral page https://help.expensify.com/articles/new-expensify/getting-started/Referral-Program instead of https://help.expensify.com/articles/new-expensify/billing-and-plan-types/Referral-Program
Changes
update
CONST.LEARN_MORE_LINKto https://help.expensify.com/articles/new-expensify/billing-and-plan-types/Referral-ProgramAlternative
Match the file location to the route
getting-started/Referral-Programmaybe not sure ?[-]Request money - Hmm it's not here page opens when click on Learn more via the banner below[/-][+][$500] Request money - Hmm it's not here page opens when click on Learn more via the banner below[/+]melvin-bot commentedon Nov 20, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01fc74f5c607d04925
melvin-bot commentedon Nov 20, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)21 remaining items
melvin-bot commentedon Nov 23, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-30. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 23, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
lschurr commentedon Nov 26, 2023
@mananjadhav could you work on the checklist for this one if needed?
lschurr commentedon Nov 29, 2023
Payment summary:
lschurr commentedon Nov 29, 2023
Bump on the checklist @mananjadhav
mananjadhav commentedon Nov 29, 2023
@lschurr I wasn't able to review this PR. Do you want me to still work on the checklist for the payout?
lschurr commentedon Nov 29, 2023
Ah, thanks for clarifying @mananjadhav! Nope, if you didn't work on it, I'll update the payment summary.
lschurr commentedon Nov 29, 2023
@luacmartins - do we need a regression test for this one?
mananjadhav commentedon Nov 29, 2023
just clarifying, I meant the payout for the external contributor if it is stuck because of this.
luacmartins commentedon Nov 29, 2023
I don't think we do. Applause caught this during regression test.
lschurr commentedon Nov 29, 2023
Cool, we're good! I'll pay @ishpaul777 tomorrow and we'll be set to close.
lschurr commentedon Nov 30, 2023
Paid! Closing this one out.