Skip to content

[HOLD for payment 2023-11-30] Update GitHub Actions best practice – use relative paths for actions #31569

Closed

Description

@roryabraham

Problem

When using our own GitHub Actions, we typically use absolute paths, like this:

- uses: Expensify/App/.github/actions/composite/setupGitForOSBotifyApp@main

But this leads to inconsistency in that:

  • Actions will run on the provided ref (i.e: main)
  • workflows will run on the ref of the event that triggered the workflow

When workflows and actions are running from different sources, things can get out-of-sync / unpredictable.

Solution

Standardize on using relative path for actions in the same repo.

Activity

  1. self-assigned this
    on Nov 20, 2023
  2. roryabraham commented on Nov 20, 2023

    @roryabraham
    ContributorAuthor

    this is done

  3. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Nov 23, 2023
  4. changed the title [-]Update GitHub Actions best practice – use relative paths for actions[/-] [+][HOLD for payment 2023-11-30] Update GitHub Actions best practice – use relative paths for actions[/+] on Nov 23, 2023
  5. melvin-bot commented on Nov 23, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  6. melvin-bot commented on Nov 23, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-11-30. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionTaskWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions