You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Bank account - Error returns when input is entered in phone number, Tax ID and SSN fields #31570
Version Number: 1.4.1-4 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
📣 @github-actions[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Activity
github-actions commentedon Nov 20, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Nov 20, 2023
Triggered auto assignment to @roryabraham (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.melvin-bot commentedon Nov 20, 2023
📣 @github-actions[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
DylanDylann commentedon Nov 20, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Bank account - Error returns when input is entered in phone number, Tax ID and SSN fields
What is the root cause of that problem?
We are validating Form when input change
What changes do you think we should make in order to solve the problem?
Should pass shouldValidateOnChange: false to FormProvider in CompanyStep Page
What alternative solutions did you explore? (Optional)
roryabraham commentedon Nov 20, 2023
I don't think this is a bug
situchan commentedon Nov 20, 2023
I think this is against Form guideline.
cc: @luacmartins
https://github.com/Expensify/App/blob/main/contributingGuides/FORMS.md#validate-on-blur-on-change-and-submit
But input is not "touched" yet.